It appears that a recent glibc update now enforces the requirement for a mode

parameter for open calls with the O_CREAT flag set.  nfs-utils support code
defines a function xflock used by exportfs and mountd that calls open with
O_CREAT but no mode parameter.  This causes exportfs and mountd to dump core,
with the error message:
*** invalid open64 call: O_CREAT without mode ***:rpc.mountd terminated

Signed-off-by: Steve Dickson <steved@redhat.com>

diff --git a/support/nfs/xio.c b/support/nfs/xio.c
index 0453ca7c0ba305122ff5353267659336fd16f9ab..f21f5f058f9d15c5fdccb601cc68e7a44fab4a7f 100644 (file)
--- a/support/nfs/xio.c
+++ b/support/nfs/xio.c
@@ -54,13 +54,19 @@ xflock(char *fname, char *type)
 {
        struct sigaction sa, oldsa;
        int             readonly = !strcmp(type, "r");
+       mode_t  mode = (S_IRUSR|S_IWUSR|S_IRGRP|S_IROTH);
        struct flock    fl = { readonly? F_RDLCK : F_WRLCK, SEEK_SET, 0, 0, 0 };
        int             fd;
 
-       if ((fd = open(fname, readonly? O_RDONLY : (O_RDWR|O_CREAT), 0644)) < 0) {
+       if (readonly)
+               fd = open(fname, O_RDONLY);
+       else
+               fd = open(fname, (O_RDWR|O_CREAT), mode);
+       if (fd < 0) {
                xlog(L_WARNING, "could not open %s for locking", fname);
                return -1;
        }
+
        sa.sa_handler = doalarm;
        sa.sa_flags = 0;
        sigemptyset(&sa.sa_mask);