Don't leak keytab entries

Free keytab entries while processing keytab file.

Signed-off-by: Kevin Coffman <kwc@citi.umich.edu>
Signed-off-by: Neil Brown <neilb@suse.de>

diff --git a/utils/gssd/krb5_util.c b/utils/gssd/krb5_util.c
index 6af286975c445f01c38904fc3c64b9248d784632..cd777e46bdab4eebd58afdd5153dee5707c77725 100644 (file)
--- a/utils/gssd/krb5_util.c
+++ b/utils/gssd/krb5_util.c
@@ -485,6 +485,7 @@ gssd_process_krb5_keytab(krb5_context context, krb5_keytab kt, char *kt_name)
                        printerr(0, "WARNING: Skipping keytab entry because "
                                    "we failed to unparse principal name: %s\n",
                                 error_message(code));
                        printerr(0, "WARNING: Skipping keytab entry because "
                                    "we failed to unparse principal name: %s\n",
                                 error_message(code));

+                       krb5_kt_free_entry(context, &kte);

                        continue;
                }
                printerr(2, "Processing keytab entry for principal '%s'\n",
                        continue;
                }
                printerr(2, "Processing keytab entry for principal '%s'\n",


@@ -510,6 +511,7 @@ gssd_process_krb5_keytab(krb5_context context, krb5_keytab kt, char *kt_name)
 #else
                                free(pname);
 #endif
 #else
                                free(pname);
 #endif

+                               krb5_kt_free_entry(context, &kte);

                                retval = ENOMEM;
                                goto out;
                        }
                                retval = ENOMEM;
                                goto out;
                        }


@@ -533,6 +535,7 @@ gssd_process_krb5_keytab(krb5_context context, krb5_keytab kt, char *kt_name)
 #else
                                free(pname);
 #endif
 #else
                                free(pname);
 #endif

+                               krb5_kt_free_entry(context, &kte);

                                retval = ENOMEM;
                                goto out;
                        }
                                retval = ENOMEM;
                                goto out;
                        }


@@ -546,6 +549,7 @@ gssd_process_krb5_keytab(krb5_context context, krb5_keytab kt, char *kt_name)
 #else
                                free(pname);
 #endif
 #else
                                free(pname);
 #endif

+                               krb5_kt_free_entry(context, &kte);

                                retval = code;
                                goto out;
                        }
                                retval = code;
                                goto out;
                        }


@@ -565,6 +569,7 @@ gssd_process_krb5_keytab(krb5_context context, krb5_keytab kt, char *kt_name)
 #else
                free(pname);
 #endif
 #else
                free(pname);
 #endif

+               krb5_kt_free_entry(context, &kte);

        }
 
        if ((code = krb5_kt_end_seq_get(context, kt, &cursor))) {
        }
 
        if ((code = krb5_kt_end_seq_get(context, kt, &cursor))) {