X-Git-Url: https://git.decadent.org.uk/gitweb/?p=nfs-utils.git;a=blobdiff_plain;f=utils%2Fstatd%2Fmonitor.c;h=98cbf4a5940ba660bda50aa944f01769b0ee9ea4;hp=3b81bdd4af1a6cc829cc9efc0d6a2c8e5ddd3d11;hb=3419e37500dfd19cb2c246260dbd2bc0ee4704d4;hpb=af93e0306d87bba3f703386fd6390e9bf8e76816 diff --git a/utils/statd/monitor.c b/utils/statd/monitor.c index 3b81bdd..98cbf4a 100644 --- a/utils/statd/monitor.c +++ b/utils/statd/monitor.c @@ -7,7 +7,9 @@ * NSM for Linux. */ -#include "config.h" +#ifdef HAVE_CONFIG_H +#include +#endif #include #include @@ -15,6 +17,7 @@ #include #include #include +#include #include #include "misc.h" #include "statd.h" @@ -172,7 +175,7 @@ sm_mon_1_svc(struct mon *argp, struct svc_req *rqstp) sprintf(path, "%s/%s", SM_DIR, mon_name); if ((fd = open(path, O_WRONLY|O_SYNC|O_CREAT, S_IRUSR|S_IWUSR)) < 0) { /* Didn't fly. We won't monitor. */ - note(N_ERROR, "creat(%s) failed: %m", path); + note(N_ERROR, "creat(%s) failed: %s", path, strerror (errno)); nlist_free(NULL, clnt); free(path); goto failure; @@ -210,9 +213,27 @@ sm_unmon_1_svc(struct mon_id *argp, struct svc_req *rqstp) char *mon_name = argp->mon_name, *my_name = argp->my_id.my_name; struct my_id *id = &argp->my_id; +#ifdef RESTRICTED_STATD + struct in_addr caller; +#endif result.state = MY_STATE; +#ifdef RESTRICTED_STATD + /* 1. Reject anyone not calling from 127.0.0.1. + * Ignore the my_name specified by the caller, and + * use "127.0.0.1" instead. + */ + caller = svc_getcaller(rqstp->rq_xprt)->sin_addr; + if (caller.s_addr != htonl(INADDR_LOOPBACK)) { + note(N_WARNING, + "Call to statd from non-local host %s", + inet_ntoa(caller)); + goto failure; + } + my_name = "127.0.0.1"; +#endif + /* Check if we're monitoring anyone. */ if (!(clnt = rtnl)) { note(N_WARNING, @@ -247,6 +268,9 @@ sm_unmon_1_svc(struct mon_id *argp, struct svc_req *rqstp) clnt = NL_NEXT(clnt); } +#ifdef RESTRICTED_STATD + failure: +#endif note(N_WARNING, "Received erroneous SM_UNMON request from %s for %s", my_name, mon_name); return (&result); @@ -259,16 +283,33 @@ sm_unmon_all_1_svc(struct my_id *argp, struct svc_req *rqstp) short int count = 0; static sm_stat result; notify_list *clnt; + char *my_name = argp->my_name; +#ifdef RESTRICTED_STATD + struct in_addr caller; + + /* 1. Reject anyone not calling from 127.0.0.1. + * Ignore the my_name specified by the caller, and + * use "127.0.0.1" instead. + */ + caller = svc_getcaller(rqstp->rq_xprt)->sin_addr; + if (caller.s_addr != htonl(INADDR_LOOPBACK)) { + note(N_WARNING, + "Call to statd from non-local host %s", + inet_ntoa(caller)); + goto failure; + } + my_name = "127.0.0.1"; +#endif result.state = MY_STATE; if (!(clnt = rtnl)) { note(N_WARNING, "Received SM_UNMON_ALL request from %s " - "while not monitoring any hosts", argp->my_name); + "while not monitoring any hosts", my_name); return (&result); } - while ((clnt = nlist_gethost(clnt, argp->my_name, 1))) { + while ((clnt = nlist_gethost(clnt, my_name, 1))) { if (NL_MY_PROC(clnt) == argp->my_proc && NL_MY_PROG(clnt) == argp->my_prog && NL_MY_VERS(clnt) == argp->my_vers) { @@ -284,7 +325,7 @@ sm_unmon_all_1_svc(struct my_id *argp, struct svc_req *rqstp) mon_name[sizeof (mon_name) - 1] = '\0'; temp = NL_NEXT(clnt); /* PRC: do the HA callout: */ - ha_callout("del-client", mon_name, argp->my_name, -1); + ha_callout("del-client", mon_name, my_name, -1); nlist_free(&rtnl, clnt); xunlink(SM_DIR, mon_name, 1); ++count; @@ -295,8 +336,10 @@ sm_unmon_all_1_svc(struct my_id *argp, struct svc_req *rqstp) if (!count) { dprintf(N_DEBUG, "SM_UNMON_ALL request from %s with no " - "SM_MON requests from it.", argp->my_name); + "SM_MON requests from it.", my_name); } - +#ifdef RESTRICTED_STATD + failure: +#endif return (&result); }