X-Git-Url: https://git.decadent.org.uk/gitweb/?p=nfs-utils.git;a=blobdiff_plain;f=utils%2Fshowmount%2Fshowmount.c;h=213a573613c3215314e71543e9d762ad012f8f30;hp=4e10a292846c50610ab636e2b2c6e618ec66d95b;hb=7f6ca07a8836dbdf30a227580441b99607639fd4;hpb=5835b1eec5a1f1e463c0762c510c6643fa2bff62 diff --git a/utils/showmount/showmount.c b/utils/showmount/showmount.c index 4e10a29..213a573 100644 --- a/utils/showmount/showmount.c +++ b/utils/showmount/showmount.c @@ -82,6 +82,8 @@ static void usage(FILE *fp, int n) * * tout contains the timeout. It will be modified to contain the time * remaining (i.e. time provided - time elasped). + * + * Returns 0 for success */ static int connect_nb(int fd, struct sockaddr_in *addr, struct timeval *tout) { @@ -177,7 +179,7 @@ static unsigned short getport(struct sockaddr_in *addr, tout.tv_sec = TIMEOUT_TCP; ret = connect_nb(sock, &saddr, &tout); - if (ret == -1) { + if (ret < 0) { close(sock); rpc_createerr.cf_stat = RPC_SYSTEMERROR; rpc_createerr.cf_error.re_errno = errno; @@ -240,6 +242,8 @@ static unsigned short getport(struct sockaddr_in *addr, rpc_createerr.cf_stat = status; clnt_destroy(client); return 0; + } else if (port == 0) { + rpc_createerr.cf_stat = RPC_PROGNOTREGISTERED; } clnt_destroy(client); @@ -350,7 +354,7 @@ int main(int argc, char **argv) MOUNTPROG, MOUNTVERS, IPPROTO_TCP); if (server_addr.sin_port) { ret = connect_nb(msock, &server_addr, 0); - if (ret != -1) + if (ret == 0) /* success */ mclient = clnttcp_create(&server_addr, MOUNTPROG, MOUNTVERS, &msock, 0, 0); @@ -364,7 +368,7 @@ int main(int argc, char **argv) server_addr.sin_port = getport(&server_addr, MOUNTPROG, MOUNTVERS, IPPROTO_UDP); if (!server_addr.sin_port) { - clnt_pcreateerror("portmap getport"); + clnt_pcreateerror("showmount"); exit(1); } msock = RPC_ANYSOCK;