]> git.decadent.org.uk Git - nfs-utils.git/blobdiff - utils/statd/sm-notify.c
sm-notify command: use static function definitions
[nfs-utils.git] / utils / statd / sm-notify.c
index bb6c2efa3f4e949191f4831757f7cf5e649eafa6..76a378c3dd53f770379234d6818d9b5c99528ed6 100644 (file)
@@ -4,6 +4,10 @@
  * Copyright (C) 2004-2006 Olaf Kirch <okir@suse.de>
  */
 
+#ifdef HAVE_CONFIG_H
+#include <config.h>
+#endif
+
 #include <sys/types.h>
 #include <sys/socket.h>
 #include <sys/stat.h>
@@ -49,13 +53,11 @@ char *_SM_BAK_PATH = DEFAULT_SM_BAK_PATH;
 #define NSM_MAX_TIMEOUT        120     /* don't make this too big */
 #define MAXMSGSIZE     256
 
-typedef struct sockaddr_storage nsm_address;
-
 struct nsm_host {
        struct nsm_host *       next;
        char *                  name;
        char *                  path;
-       nsm_address             addr;
+       struct sockaddr_storage addr;
        struct addrinfo         *ai;
        time_t                  last_used;
        time_t                  send_next;
@@ -76,22 +78,59 @@ static int          log_syslog = 0;
 
 static unsigned int    nsm_get_state(int);
 static void            notify(void);
-static void            notify_host(int, struct nsm_host *);
+static int             notify_host(int, struct nsm_host *);
 static void            recv_reply(int);
 static void            backup_hosts(const char *, const char *);
 static void            get_hosts(const char *);
 static void            insert_host(struct nsm_host *);
-struct nsm_host *      find_host(uint32_t);
-static int             addr_get_port(nsm_address *);
-static void            addr_set_port(nsm_address *, int);
-static struct addrinfo *host_lookup(int, const char *);
-void                   nsm_log(int fac, const char *fmt, ...);
-static int             record_pid();
+static struct nsm_host *find_host(uint32_t);
+static void            nsm_log(int fac, const char *fmt, ...);
+static int             record_pid(void);
 static void            drop_privs(void);
-static void set_kernel_nsm_state(int state);
+static void            set_kernel_nsm_state(int state);
 
 static struct nsm_host *       hosts = NULL;
 
+/*
+ * Address handling utilities
+ */
+
+static unsigned short smn_get_port(const struct sockaddr *sap)
+{
+       switch (sap->sa_family) {
+       case AF_INET:
+               return ntohs(((struct sockaddr_in *)sap)->sin_port);
+       case AF_INET6:
+               return ntohs(((struct sockaddr_in6 *)sap)->sin6_port);
+       }
+       return 0;
+}
+
+static void smn_set_port(struct sockaddr *sap, const unsigned short port)
+{
+       switch (sap->sa_family) {
+       case AF_INET:
+               ((struct sockaddr_in *)sap)->sin_port = htons(port);
+               break;
+       case AF_INET6:
+               ((struct sockaddr_in6 *)sap)->sin6_port = htons(port);
+               break;
+       }
+}
+
+static struct addrinfo *smn_lookup(const sa_family_t family, const char *name)
+{
+       struct addrinfo *ai, hint = {
+               .ai_family      = family,
+               .ai_protocol    = IPPROTO_UDP,
+       };
+
+       if (getaddrinfo(name, NULL, &hint, &ai) != 0)
+               return NULL;
+
+       return ai;
+}
+
 int
 main(int argc, char **argv)
 {
@@ -130,7 +169,7 @@ main(int argc, char **argv)
                            _SM_STATE_PATH == NULL ||
                            _SM_DIR_PATH == NULL ||
                            _SM_BAK_PATH == NULL) {
-                               nsm_log(LOG_WARNING, "unable to allocate memory");
+                               nsm_log(LOG_ERR, "unable to allocate memory");
                                exit(1);
                        }
                        strcat(strcpy(_SM_STATE_PATH, _SM_BASE_PATH), "/state");
@@ -147,7 +186,7 @@ main(int argc, char **argv)
 usage:         fprintf(stderr,
                        "Usage: sm-notify [-dfq] [-m max-retry-minutes] [-p srcport]\n"
                        "            [-P /path/to/state/directory] [-v my_host_name]\n");
-               return 1;
+               exit(1);
        }
 
        if (strcmp(_SM_BASE_PATH, BASEDIR) == 0) {
@@ -160,8 +199,9 @@ usage:              fprintf(stderr,
                strncpy(nsm_hostname, opt_srcaddr, sizeof(nsm_hostname)-1);
        } else
        if (gethostname(nsm_hostname, sizeof(nsm_hostname)) < 0) {
-               perror("gethostname");
-               return 1;
+               nsm_log(LOG_ERR, "Failed to obtain name of local host: %s",
+                       strerror(errno));
+               exit(1);
        }
 
        backup_hosts(_SM_DIR_PATH, _SM_BAK_PATH);
@@ -179,9 +219,9 @@ usage:              fprintf(stderr,
                log_syslog = 1;
 
                if (daemon(0, 0) < 0) {
-                       nsm_log(LOG_WARNING, "unable to background: %s",
+                       nsm_log(LOG_ERR, "unable to background: %s",
                                        strerror(errno));
-                       return 1;
+                       exit(1);
                }
 
                close(0);
@@ -200,55 +240,72 @@ usage:            fprintf(stderr,
                                "Unable to notify %s, giving up",
                                hp->name);
                }
-               return 1;
+               exit(1);
        }
 
-       return 0;
+       exit(0);
 }
 
 /*
  * Notify hosts
  */
-void
+static void
 notify(void)
 {
-       nsm_address local_addr;
+       struct sockaddr_storage address;
+       struct sockaddr *local_addr = (struct sockaddr *)&address;
        time_t  failtime = 0;
        int     sock = -1;
+       int retry_cnt = 0;
 
+ retry:
        sock = socket(AF_INET, SOCK_DGRAM, 0);
        if (sock < 0) {
-               perror("socket");
+               nsm_log(LOG_ERR, "Failed to create RPC socket: %s",
+                       strerror(errno));
                exit(1);
        }
        fcntl(sock, F_SETFL, O_NONBLOCK);
 
-       memset(&local_addr, 0, sizeof(local_addr));
-       local_addr.ss_family = AF_INET; /* Default to IPv4 */
+       memset(&address, 0, sizeof(address));
+       local_addr->sa_family = AF_INET;        /* Default to IPv4 */
 
        /* Bind source IP if provided on command line */
        if (opt_srcaddr) {
-               struct addrinfo *ai = host_lookup(AF_INET, opt_srcaddr);
+               struct addrinfo *ai = smn_lookup(AF_INET, opt_srcaddr);
                if (!ai) {
-                       nsm_log(LOG_WARNING,
-                               "Not a valid hostname or address: \"%s\"\n",
+                       nsm_log(LOG_ERR,
+                               "Not a valid hostname or address: \"%s\"",
                                opt_srcaddr);
                        exit(1);
                }
-               memcpy(&local_addr, ai->ai_addr, ai->ai_addrlen);
+
                /* We know it's IPv4 at this point */
+               memcpy(local_addr, ai->ai_addr, ai->ai_addrlen);
+
+               freeaddrinfo(ai);
        }
 
        /* Use source port if provided on the command line,
         * otherwise use bindresvport */
        if (opt_srcport) {
-               addr_set_port(&local_addr, opt_srcport);
-               if (bind(sock, (struct sockaddr *) &local_addr, sizeof(local_addr)) < 0) {
-                       perror("bind");
+               smn_set_port(local_addr, opt_srcport);
+               if (bind(sock, local_addr, sizeof(struct sockaddr_in)) < 0) {
+                       nsm_log(LOG_ERR, "Failed to bind RPC socket: %s",
+                               strerror(errno));
                        exit(1);
                }
        } else {
-               (void) bindresvport(sock, (struct sockaddr_in *) &local_addr);
+               struct servent *se;
+               struct sockaddr_in *sin = (struct sockaddr_in *)local_addr;
+               (void) bindresvport(sock, sin);
+               /* try to avoid known ports */
+               se = getservbyport(sin->sin_port, "udp");
+               if (se && retry_cnt < 100) {
+                       retry_cnt++;
+                       close(sock);
+                       goto retry;
+               }
        }
 
        if (opt_max_retry)
@@ -266,7 +323,7 @@ notify(void)
                if (failtime && now >= failtime)
                        break;
 
-               while ((wait = hosts->send_next - now) <= 0) {
+               while (hosts && ((wait = hosts->send_next - now) <= 0)) {
                        /* Never send more than 10 packets at once */
                        if (sent++ >= 10)
                                break;
@@ -275,7 +332,13 @@ notify(void)
                        hp = hosts;
                        hosts = hp->next;
 
-                       notify_host(sock, hp);
+                       if (notify_host(sock, hp)){
+                               unlink(hp->path);
+                               free(hp->name);
+                               free(hp->path);
+                               free(hp);
+                               continue;
+                       }
 
                        /* Set the timeout for this call, using an
                           exponential timeout strategy */
@@ -287,6 +350,8 @@ notify(void)
 
                        insert_host(hp);
                }
+               if (hosts == NULL)
+                       return;
 
                nsm_log(LOG_DEBUG, "Host %s due in %ld seconds",
                                hosts->name, wait);
@@ -307,11 +372,13 @@ notify(void)
 /*
  * Send notification to a single host
  */
-void
+static int
 notify_host(int sock, struct nsm_host *host)
 {
+       struct sockaddr_storage address;
+       struct sockaddr *dest = (struct sockaddr *)&address;
+       socklen_t destlen = sizeof(address);
        static unsigned int     xid = 0;
-       nsm_address             dest;
        uint32_t                msgbuf[MAXMSGSIZE], *p;
        unsigned int            len;
 
@@ -320,6 +387,16 @@ notify_host(int sock, struct nsm_host *host)
        if (!host->xid)
                host->xid = xid++;
 
+       if (host->ai == NULL) {
+               host->ai = smn_lookup(AF_UNSPEC, host->name);
+               if (host->ai == NULL) {
+                       nsm_log(LOG_WARNING,
+                               "%s doesn't seem to be a valid address,"
+                               " skipped", host->name);
+                       return 1;
+               }
+       }
+
        memset(msgbuf, 0, sizeof(msgbuf));
        p = msgbuf;
        *p++ = htonl(host->xid);
@@ -332,24 +409,29 @@ notify_host(int sock, struct nsm_host *host)
         * point.
         */
        if (host->retries >= 4) {
-               struct addrinfo *hold = host->ai;
+               struct addrinfo *first = host->ai;
                struct addrinfo **next = &host->ai;
-               *next = hold->ai_next;
+
+               /* remove the first entry from the list */
+               host->ai = first->ai_next;
+               first->ai_next = NULL;
+               /* find the end of the list */
+               next = &first->ai_next;
                while ( *next )
                        next = & (*next)->ai_next;
-               *next = hold;
-               hold->ai_next = NULL;
-               memcpy(&host->addr, hold->ai_addr, hold->ai_addrlen);
-               addr_set_port(&host->addr, 0);
+               /* put first entry at end */
+               *next = first;
+               memcpy(&host->addr, first->ai_addr, first->ai_addrlen);
+               smn_set_port((struct sockaddr *)&host->addr, 0);
                host->retries = 0;
        }
 
-       dest = host->addr;
-       if (addr_get_port(&dest) == 0) {
+       memcpy(dest, &host->addr, destlen);
+       if (smn_get_port(dest) == 0) {
                /* Build a PMAP packet */
                nsm_log(LOG_DEBUG, "Sending portmap query to %s", host->name);
 
-               addr_set_port(&dest, 111);
+               smn_set_port(dest, 111);
                *p++ = htonl(100000);
                *p++ = htonl(2);
                *p++ = htonl(3);
@@ -383,16 +465,21 @@ notify_host(int sock, struct nsm_host *host)
        }
        len = (p - msgbuf) << 2;
 
-       sendto(sock, msgbuf, len, 0, (struct sockaddr *) &dest, sizeof(dest));
+       if (sendto(sock, msgbuf, len, 0, dest, destlen) < 0)
+               nsm_log(LOG_WARNING, "Sending Reboot Notification to "
+                       "'%s' failed: errno %d (%s)", host->name, errno, strerror(errno));
+       
+       return 0;
 }
 
 /*
  * Receive reply from remote host
  */
-void
+static void
 recv_reply(int sock)
 {
        struct nsm_host *hp;
+       struct sockaddr *sap;
        uint32_t        msgbuf[MAXMSGSIZE], *p, *end;
        uint32_t        xid;
        int             res;
@@ -418,8 +505,9 @@ recv_reply(int sock)
           this reply */
        if ((hp = find_host(xid)) == NULL)
                return;
+       sap = (struct sockaddr *)&hp->addr;
 
-       if (addr_get_port(&hp->addr) == 0) {
+       if (smn_get_port(sap) == 0) {
                /* This was a portmap request */
                unsigned int    port;
 
@@ -435,7 +523,7 @@ recv_reply(int sock)
                        hp->timeout = NSM_MAX_TIMEOUT;
                        hp->send_next += NSM_MAX_TIMEOUT;
                } else {
-                       addr_set_port(&hp->addr, port);
+                       smn_set_port(sap, port);
                        if (hp->timeout >= NSM_MAX_TIMEOUT / 4)
                                hp->timeout = NSM_MAX_TIMEOUT / 4;
                }
@@ -447,7 +535,8 @@ recv_reply(int sock)
                 * packet)
                 */
                if (p <= end) {
-                       nsm_log(LOG_DEBUG, "Host %s notified successfully", hp->name);
+                       nsm_log(LOG_DEBUG, "Host %s notified successfully",
+                                       hp->name);
                        unlink(hp->path);
                        free(hp->name);
                        free(hp->path);
@@ -471,7 +560,8 @@ backup_hosts(const char *dirname, const char *bakname)
        DIR             *dir;
 
        if (!(dir = opendir(dirname))) {
-               perror(dirname);
+               nsm_log(LOG_WARNING,
+                       "Failed to open %s: %s", dirname, strerror(errno));
                return;
        }
 
@@ -493,7 +583,7 @@ backup_hosts(const char *dirname, const char *bakname)
 }
 
 /*
- * Get all entries from sm.bak and convert them to host names
+ * Get all entries from sm.bak and convert them to host entries
  */
 static void
 get_hosts(const char *dirname)
@@ -503,7 +593,8 @@ get_hosts(const char *dirname)
        DIR             *dir;
 
        if (!(dir = opendir(dirname))) {
-               perror(dirname);
+               nsm_log(LOG_WARNING,
+                       "Failed to open %s: %s", dirname, strerror(errno));
                return;
        }
 
@@ -516,20 +607,15 @@ get_hosts(const char *dirname)
                        continue;
                if (host == NULL)
                        host = calloc(1, sizeof(*host));
+               if (host == NULL) {
+                       nsm_log(LOG_WARNING, "Unable to allocate memory");
+                       return;
+               }
 
                snprintf(path, sizeof(path), "%s/%s", dirname, de->d_name);
                if (stat(path, &stb) < 0)
                        continue;
 
-               host->ai = host_lookup(AF_UNSPEC, de->d_name);
-               if (! host->ai) {
-                       nsm_log(LOG_WARNING,
-                               "%s doesn't seem to be a valid address, skipped",
-                               de->d_name);
-                       unlink(path);
-                       continue;
-               }
-
                host->last_used = stb.st_mtime;
                host->timeout = NSM_TIMEOUT;
                host->path = strdup(path);
@@ -548,7 +634,7 @@ get_hosts(const char *dirname)
 /*
  * Insert host into sorted list
  */
-void
+static void
 insert_host(struct nsm_host *host)
 {
        struct nsm_host **where, *p;
@@ -576,7 +662,7 @@ insert_host(struct nsm_host *host)
 /*
  * Find host given the XID
  */
-struct nsm_host *
+static struct nsm_host *
 find_host(uint32_t xid)
 {
        struct nsm_host **where, *p;
@@ -596,7 +682,7 @@ find_host(uint32_t xid)
 /*
  * Retrieve the current NSM state
  */
-unsigned int
+static unsigned int
 nsm_get_state(int update)
 {
        char            newfile[PATH_MAX];
@@ -629,17 +715,17 @@ nsm_get_state(int update)
                snprintf(newfile, sizeof(newfile),
                                "%s.new", _SM_STATE_PATH);
                if ((fd = open(newfile, O_CREAT|O_WRONLY, 0644)) < 0) {
-                       nsm_log(LOG_WARNING, "Cannot create %s: %m", newfile);
+                       nsm_log(LOG_ERR, "Cannot create %s: %m", newfile);
                        exit(1);
                }
                if (write(fd, &state, sizeof(state)) != sizeof(state)) {
-                       nsm_log(LOG_WARNING,
+                       nsm_log(LOG_ERR,
                                "Failed to write state to %s", newfile);
                        exit(1);
                }
                close(fd);
                if (rename(newfile, _SM_STATE_PATH) < 0) {
-                       nsm_log(LOG_WARNING,
+                       nsm_log(LOG_ERR,
                                "Cannot create %s: %m", _SM_STATE_PATH);
                        exit(1);
                }
@@ -649,53 +735,10 @@ nsm_get_state(int update)
        return state;
 }
 
-/*
- * Address handling utilities
- */
-
-int
-addr_get_port(nsm_address *addr)
-{
-       switch (((struct sockaddr *) addr)->sa_family) {
-       case AF_INET:
-               return ntohs(((struct sockaddr_in *) addr)->sin_port);
-       case AF_INET6:
-               return ntohs(((struct sockaddr_in6 *) addr)->sin6_port);
-       }
-       return 0;
-}
-
-static void
-addr_set_port(nsm_address *addr, int port)
-{
-       switch (((struct sockaddr *) addr)->sa_family) {
-       case AF_INET:
-               ((struct sockaddr_in *) addr)->sin_port = htons(port);
-               break;
-       case AF_INET6:
-               ((struct sockaddr_in6 *) addr)->sin6_port = htons(port);
-       }
-}
-
-static struct addrinfo *
-host_lookup(int af, const char *name)
-{
-       struct addrinfo hints, *ai;
-
-       memset(&hints, 0, sizeof(hints));
-       hints.ai_family = af;
-       hints.ai_protocol = IPPROTO_UDP;
-
-       if (getaddrinfo(name, NULL, &hints, &ai) != 0)
-               return NULL;
-
-       return ai;
-}
-
 /*
  * Log a message
  */
-void
+static void
 nsm_log(int fac, const char *fmt, ...)
 {
        va_list ap;
@@ -719,7 +762,7 @@ nsm_log(int fac, const char *fmt, ...)
  * program exits.
  * If file already exists, fail.
  */
-static int record_pid()
+static int record_pid(void)
 {
        char pid[20];
        int fd;
@@ -748,7 +791,7 @@ static void drop_privs(void)
 
        if (st.st_uid == 0) {
                nsm_log(LOG_WARNING,
-                       "sm-notify running as root. chown %s to choose different user\n",
+                       "sm-notify running as root. chown %s to choose different user",
                    _SM_DIR_PATH);
                return;
        }