]> git.decadent.org.uk Git - nfs-utils.git/blobdiff - utils/mount/stropts.c
text-based mount command: fix return value from po_rightmost()
[nfs-utils.git] / utils / mount / stropts.c
index 13523f8814bd00aa6319435fa374a9e0e92de293..770b5b515c494d135966497ad27ba7c73ccea7c8 100644 (file)
  *
  */
 
-#include <ctype.h>
+#ifdef HAVE_CONFIG_H
+#include <config.h>
+#endif
+
 #include <unistd.h>
-#include <stdio.h>
-#include <string.h>
-#include <stdlib.h>
 #include <errno.h>
 #include <netdb.h>
 #include <time.h>
+
 #include <sys/socket.h>
 #include <sys/mount.h>
+#include <netinet/in.h>
+#include <arpa/inet.h>
 
 #include "xcommon.h"
 #include "mount.h"
 #include "nls.h"
-#include "nfs_mount.h"
 #include "mount_constants.h"
 #include "stropts.h"
 #include "error.h"
 #include "network.h"
 #include "parse_opt.h"
+#include "version.h"
+#include "parse_dev.h"
 
-#ifdef HAVE_RPCSVC_NFS_PROT_H
-#include <rpcsvc/nfs_prot.h>
-#else
-#include <linux/nfs.h>
-#define nfsstat nfs_stat
+#ifndef NFS_PROGRAM
+#define NFS_PROGRAM    (100003)
 #endif
 
 #ifndef NFS_PORT
-#define NFS_PORT 2049
+#define NFS_PORT       (2049)
 #endif
 
 #ifndef NFS_MAXHOSTNAME
 #define NFS_MAXPATHNAME                (1024)
 #endif
 
+#ifndef NFS_DEF_FG_TIMEOUT_MINUTES
+#define NFS_DEF_FG_TIMEOUT_MINUTES     (2u)
+#endif
+
+#ifndef NFS_DEF_BG_TIMEOUT_MINUTES
+#define NFS_DEF_BG_TIMEOUT_MINUTES     (10000u)
+#endif
+
 extern int nfs_mount_data_version;
 extern char *progname;
 extern int verbose;
+extern int sloppy;
 
-static int parse_devname(const char *spec, char **hostname)
-{
-       int ret = 0;
-       char *dev, *pathname, *s;
+struct nfsmount_info {
+       const char              *spec,          /* server:/path */
+                               *node,          /* mounted-on dir */
+                               *type;          /* "nfs" or "nfs4" */
+       char                    *hostname;      /* server's hostname */
 
-       dev = xstrdup(spec);
+       struct mount_options    *options;       /* parsed mount options */
+       char                    **extra_opts;   /* string for /etc/mtab */
 
-       if (!(pathname = strchr(dev, ':'))) {
-               nfs_error(_("%s: remote share not in 'host:dir' format"),
-                               progname);
-               goto out;
-       }
-       *pathname = '\0';
-       pathname++;
+       int                     flags,          /* MS_ flags */
+                               fake,           /* actually do the mount? */
+                               child;          /* forked bg child? */
 
-       /*
-        * We don't need a copy of the pathname, but let's
-        * sanity check it anyway.
-        */
-       if (strlen(pathname) > NFS_MAXPATHNAME) {
-               nfs_error(_("%s: export pathname is too long"),
-                               progname);
-               goto out;
-       }
+       sa_family_t             family;         /* supported address family */
+};
 
-       /*
-        * Ignore all but first hostname in replicated mounts
-        * until they can be fully supported. (mack@sgi.com)
-        */
-       if ((s = strchr(dev, ','))) {
-               *s = '\0';
-               nfs_error(_("%s: warning: multiple hostnames not supported"),
-                               progname);
-               nfs_error(_("%s: ignoring hostnames that follow the first one"),
-                               progname);
-       }
-       *hostname = xstrdup(dev);
-       if (strlen(*hostname) > NFS_MAXHOSTNAME) {
-               nfs_error(_("%s: server hostname is too long"),
-                               progname);
-               free(*hostname);
-               goto out;
-       }
+/*
+ * Obtain a retry timeout value based on the value of the "retry=" option.
+ *
+ * Returns a time_t timeout timestamp, in seconds.
+ */
+static time_t nfs_parse_retry_option(struct mount_options *options,
+                                    unsigned int timeout_minutes)
+{
+       long tmp;
 
-       ret = 1;
+       switch (po_get_numeric(options, "retry", &tmp)) {
+       case PO_NOT_FOUND:
+               break;
+       case PO_FOUND:
+               if (tmp >= 0) {
+                       timeout_minutes = tmp;
+                       break;
+               }
+       case PO_BAD_VALUE:
+               if (verbose)
+                       nfs_error(_("%s: invalid retry timeout was specified; "
+                                       "using default timeout"), progname);
+               break;
+       }
 
-out:
-       free(dev);
-       return ret;
+       return time(NULL) + (time_t)(timeout_minutes * 60);
 }
 
-static int fill_ipv4_sockaddr(const char *hostname, struct sockaddr_in *addr)
+/*
+ * Convert the passed-in sockaddr-style address to presentation
+ * format, then append an option of the form "keyword=address".
+ *
+ * Returns 1 if the option was appended successfully; otherwise zero.
+ */
+static int nfs_append_generic_address_option(const struct sockaddr *sap,
+                                            const socklen_t salen,
+                                            const char *keyword,
+                                            struct mount_options *options)
 {
-       struct hostent *hp;
-       addr->sin_family = AF_INET;
+       char address[NI_MAXHOST];
+       char new_option[512];
+
+       if (!nfs_present_sockaddr(sap, salen, address, sizeof(address)))
+               goto out_err;
+
+       if (snprintf(new_option, sizeof(new_option), "%s=%s",
+                                       keyword, address) >= sizeof(new_option))
+               goto out_err;
+
+       if (po_append(options, new_option) != PO_SUCCEEDED)
+               goto out_err;
 
-       if (inet_aton(hostname, &addr->sin_addr))
-               return 1;
-       if ((hp = gethostbyname(hostname)) == NULL) {
-               nfs_error(_("%s: can't get address for %s\n"),
-                               progname, hostname);
-               return 0;
-       }
-       if (hp->h_length > sizeof(struct in_addr)) {
-               nfs_error(_("%s: got bad hp->h_length"), progname);
-               hp->h_length = sizeof(struct in_addr);
-       }
-       memcpy(&addr->sin_addr, hp->h_addr, hp->h_length);
        return 1;
+
+out_err:
+       nfs_error(_("%s: failed to construct %s option"), progname, keyword);
+       return 0;
 }
 
 /*
@@ -148,19 +162,12 @@ static int fill_ipv4_sockaddr(const char *hostname, struct sockaddr_in *addr)
  * Returns 1 if 'addr=' option appended successfully;
  * otherwise zero.
  */
-static int append_addr_option(struct sockaddr_in *saddr,
-                          struct mount_options *options)
+static int nfs_append_addr_option(const struct sockaddr *sap,
+                                 socklen_t salen,
+                                 struct mount_options *options)
 {
-       char new_option[24];
-
        po_remove_all(options, "addr");
-
-       snprintf(new_option, sizeof(new_option) - 1,
-                       "addr=%s", inet_ntoa(saddr->sin_addr));
-
-       if (po_append(options, new_option) == PO_SUCCEEDED)
-               return 1;
-       return 0;
+       return nfs_append_generic_address_option(sap, salen, "addr", options);
 }
 
 /*
@@ -170,70 +177,241 @@ static int append_addr_option(struct sockaddr_in *saddr,
  * Returns 1 if 'clientaddr=' option created successfully or if
  * 'clientaddr=' option is already present; otherwise zero.
  */
-static int append_clientaddr_option(struct sockaddr_in *saddr,
-                                   struct mount_options *options)
+static int nfs_append_clientaddr_option(const struct sockaddr *sap,
+                                       socklen_t salen,
+                                       struct mount_options *options)
 {
-       struct sockaddr_in my_addr;
-       char new_option[32];
+       struct sockaddr_storage dummy;
+       struct sockaddr *my_addr = (struct sockaddr *)&dummy;
+       socklen_t my_len = sizeof(dummy);
 
-       if (po_contains(options, "clientaddr") == PO_SUCCEEDED)
+       if (po_contains(options, "clientaddr") == PO_FOUND)
                return 1;
 
-       if (!get_client_address(saddr, &my_addr))
-               return 0;
+       nfs_callback_address(sap, salen, my_addr, &my_len);
 
-       snprintf(new_option, sizeof(new_option) - 1,
-                       "clientaddr=%s", inet_ntoa(my_addr.sin_addr));
-
-       if (po_append(options, new_option) == PO_SUCCEEDED)
-               return 1;
-       return 0;
+       return nfs_append_generic_address_option(my_addr, my_len,
+                                                       "clientaddr", options);
 }
 
 /*
  * Resolve the 'mounthost=' hostname and append a new option using
- * the resulting IPv4 address.
+ * the resulting address.
  */
-static int fix_mounthost_option(struct mount_options *options)
+static int nfs_fix_mounthost_option(const sa_family_t family,
+                                   struct mount_options *options)
 {
-       struct sockaddr_in maddr;
-       char *mounthost, new_option[32];
+       struct sockaddr_storage dummy;
+       struct sockaddr *sap = (struct sockaddr *)&dummy;
+       socklen_t salen = sizeof(dummy);
+       char *mounthost;
 
        mounthost = po_get(options, "mounthost");
        if (!mounthost)
                return 1;
 
-       if (!fill_ipv4_sockaddr(mounthost, &maddr))
+       if (!nfs_name_to_address(mounthost, family, sap, &salen)) {
+               nfs_error(_("%s: unable to determine mount server's address"),
+                               progname);
                return 0;
+       }
 
-       snprintf(new_option, sizeof(new_option) - 1,
-                       "mountaddr=%s", inet_ntoa(maddr.sin_addr));
+       return nfs_append_generic_address_option(sap, salen,
+                                                       "mountaddr", options);
+}
 
-       if (po_append(options, new_option) == PO_SUCCEEDED)
+/*
+ * Returns zero if the "lock" option is in effect, but statd
+ * can't be started.  Otherwise, returns 1.
+ */
+static const char *nfs_lock_opttbl[] = {
+       "nolock",
+       "lock",
+       NULL,
+};
+
+static int nfs_verify_lock_option(struct mount_options *options)
+{
+       if (po_rightmost(options, nfs_lock_opttbl) == 0)
                return 1;
-       return 0;
+
+       if (!start_statd()) {
+               nfs_error(_("%s: rpc.statd is not running but is "
+                           "required for remote locking."), progname);
+               nfs_error(_("%s: Either use '-o nolock' to keep "
+                           "locks local, or start statd."), progname);
+               return 0;
+       }
+
+       return 1;
+}
+
+static int nfs_append_sloppy_option(struct mount_options *options)
+{
+       if (!sloppy || linux_version_code() < MAKE_VERSION(2, 6, 27))
+               return 1;
+
+       if (po_append(options, "sloppy") == PO_FAILED)
+               return 0;
+       return 1;
 }
 
 /*
- * Set up mandatory mount options.
+ * Set up mandatory NFS mount options.
  *
  * Returns 1 if successful; otherwise zero.
  */
-static int set_mandatory_options(const char *type,
-                                struct sockaddr_in *saddr,
-                                struct mount_options *options)
+static int nfs_validate_options(struct nfsmount_info *mi)
 {
-       if (!append_addr_option(saddr, options))
+       struct sockaddr_storage dummy;
+       struct sockaddr *sap = (struct sockaddr *)&dummy;
+       socklen_t salen = sizeof(dummy);
+
+       if (!nfs_parse_devname(mi->spec, &mi->hostname, NULL))
+               return 0;
+
+       if (!nfs_name_to_address(mi->hostname, mi->family, sap, &salen))
                return 0;
 
-       if (strncmp(type, "nfs4", 4) == 0) {
-               if (!append_clientaddr_option(saddr, options))
+       if (strncmp(mi->type, "nfs4", 4) == 0) {
+               if (!nfs_append_clientaddr_option(sap, salen, mi->options))
                        return 0;
        } else {
-               if (!fix_mounthost_option(options))
+               if (!nfs_fix_mounthost_option(mi->family, mi->options))
+                       return 0;
+               if (!mi->fake && !nfs_verify_lock_option(mi->options))
+                       return 0;
+       }
+
+       if (!nfs_append_sloppy_option(mi->options))
+               return 0;
+
+       return nfs_append_addr_option(sap, salen, mi->options);
+}
+
+/*
+ * Distinguish between permanent and temporary errors.
+ *
+ * Returns 0 if the passed-in error is temporary, thus the
+ * mount system call should be retried; returns one if the
+ * passed-in error is permanent, thus the mount system call
+ * should not be retried.
+ */
+static int nfs_is_permanent_error(int error)
+{
+       switch (error) {
+       case ESTALE:
+       case ETIMEDOUT:
+       case ECONNREFUSED:
+               return 0;       /* temporary */
+       default:
+               return 1;       /* permanent */
+       }
+}
+
+/*
+ * Get NFS/mnt server addresses from mount options
+ *
+ * Returns 1 and fills in @nfs_saddr, @nfs_salen, @mnt_saddr, and @mnt_salen
+ * if all goes well; otherwise zero.
+ */
+static int nfs_extract_server_addresses(struct mount_options *options,
+                                       struct sockaddr *nfs_saddr,
+                                       socklen_t *nfs_salen,
+                                       struct sockaddr *mnt_saddr,
+                                       socklen_t *mnt_salen)
+{
+       char *option;
+
+       option = po_get(options, "addr");
+       if (option == NULL)
+               return 0;
+       if (!nfs_string_to_sockaddr(option, strlen(option),
+                                               nfs_saddr, nfs_salen))
+               return 0;
+
+       option = po_get(options, "mountaddr");
+       if (option == NULL)
+               memcpy(mnt_saddr, nfs_saddr, *nfs_salen);
+       else if (!nfs_string_to_sockaddr(option, strlen(option),
+                                               mnt_saddr, mnt_salen))
+               return 0;
+
+       return 1;
+}
+
+static int nfs_construct_new_options(struct mount_options *options,
+                                    struct pmap *nfs_pmap,
+                                    struct pmap *mnt_pmap)
+{
+       char new_option[64];
+
+       po_remove_all(options, "nfsprog");
+       po_remove_all(options, "mountprog");
+
+       po_remove_all(options, "v2");
+       po_remove_all(options, "v3");
+       po_remove_all(options, "vers");
+       po_remove_all(options, "nfsvers");
+       snprintf(new_option, sizeof(new_option) - 1,
+                "vers=%lu", nfs_pmap->pm_vers);
+       if (po_append(options, new_option) == PO_FAILED)
+               return 0;
+
+       po_remove_all(options, "proto");
+       po_remove_all(options, "udp");
+       po_remove_all(options, "tcp");
+       switch (nfs_pmap->pm_prot) {
+       case IPPROTO_TCP:
+               snprintf(new_option, sizeof(new_option) - 1,
+                        "proto=tcp");
+               if (po_append(options, new_option) == PO_FAILED)
+                       return 0;
+               break;
+       case IPPROTO_UDP:
+               snprintf(new_option, sizeof(new_option) - 1,
+                        "proto=udp");
+               if (po_append(options, new_option) == PO_FAILED)
+                       return 0;
+               break;
+       }
+
+       po_remove_all(options, "port");
+       if (nfs_pmap->pm_port != NFS_PORT) {
+               snprintf(new_option, sizeof(new_option) - 1,
+                        "port=%lu", nfs_pmap->pm_port);
+               if (po_append(options, new_option) == PO_FAILED)
+                       return 0;
+       }
+
+       po_remove_all(options, "mountvers");
+       snprintf(new_option, sizeof(new_option) - 1,
+                "mountvers=%lu", mnt_pmap->pm_vers);
+       if (po_append(options, new_option) == PO_FAILED)
+               return 0;
+
+       po_remove_all(options, "mountproto");
+       switch (mnt_pmap->pm_prot) {
+       case IPPROTO_TCP:
+               snprintf(new_option, sizeof(new_option) - 1,
+                        "mountproto=tcp");
+               if (po_append(options, new_option) == PO_FAILED)
                        return 0;
+               break;
+       case IPPROTO_UDP:
+               snprintf(new_option, sizeof(new_option) - 1,
+                        "mountproto=udp");
+               if (po_append(options, new_option) == PO_FAILED)
+                       return 0;
+               break;
        }
 
+       po_remove_all(options, "mountport");
+       snprintf(new_option, sizeof(new_option) - 1,
+                "mountport=%lu", mnt_pmap->pm_port);
+       if (po_append(options, new_option) == PO_FAILED)
+               return 0;
+
        return 1;
 }
 
@@ -244,122 +422,56 @@ static int set_mandatory_options(const char *type,
  *
  * To handle version and transport protocol fallback properly, we
  * need to parse some of the mount options in order to set up a
- * portmap probe.  Mount options that rewrite_mount_options()
+ * portmap probe.  Mount options that nfs_rewrite_mount_options()
  * doesn't recognize are left alone.
  *
  * Returns a new group of mount options if successful; otherwise
  * NULL is returned if some failure occurred.
  */
-static struct mount_options *rewrite_mount_options(char *str)
+static struct mount_options *nfs_rewrite_mount_options(char *str)
 {
        struct mount_options *options;
-       char *option, new_option[64];
-       clnt_addr_t mnt_server = { };
-       clnt_addr_t nfs_server = { };
-       int p;
+       struct sockaddr_storage nfs_address;
+       struct sockaddr *nfs_saddr = (struct sockaddr *)&nfs_address;
+       socklen_t nfs_salen;
+       struct pmap nfs_pmap;
+       struct sockaddr_storage mnt_address;
+       struct sockaddr *mnt_saddr = (struct sockaddr *)&mnt_address;
+       socklen_t mnt_salen;
+       struct pmap mnt_pmap;
 
        options = po_split(str);
-       if (!options)
+       if (!options) {
+               errno = EFAULT;
                return NULL;
-
-       option = po_get(options, "addr");
-       if (option) {
-               nfs_server.saddr.sin_family = AF_INET;
-               if (!inet_aton((const char *)option, &nfs_server.saddr.sin_addr))
-                       goto err;
-       } else
-               goto err;
-
-       option = po_get(options, "mountaddr");
-       if (option) {
-               mnt_server.saddr.sin_family = AF_INET;
-               if (!inet_aton((const char *)option, &mnt_server.saddr.sin_addr))
-                       goto err;
-       } else
-               memcpy(&mnt_server.saddr, &nfs_server.saddr,
-                               sizeof(mnt_server.saddr));
-
-       option = po_get(options, "mountport");
-       if (option)
-               mnt_server.pmap.pm_port = atoi(option);
-       mnt_server.pmap.pm_prog = MOUNTPROG;
-       option = po_get(options, "mountprog");
-       if (option)
-               mnt_server.pmap.pm_prog = atoi(option);
-       option = po_get(options, "mountvers");
-       if (option)
-               mnt_server.pmap.pm_vers = atoi(option);
-
-       option = po_get(options, "port");
-       if (option) {
-               nfs_server.pmap.pm_port = atoi(option);
-               po_remove_all(options, "port");
-       }
-       nfs_server.pmap.pm_prog = NFS_PROGRAM;
-       option = po_get(options, "nfsprog");
-       if (option)
-               nfs_server.pmap.pm_prog = atoi(option);
-
-       option = po_get(options, "nfsvers");
-       if (option) {
-               nfs_server.pmap.pm_vers = atoi(option);
-               po_remove_all(options, "nfsvers");
-       }
-       option = po_get(options, "vers");
-       if (option) {
-               nfs_server.pmap.pm_vers = atoi(option);
-               po_remove_all(options, "vers");
        }
-       option = po_get(options, "proto");
-       if (option) {
-               if (strcmp(option, "tcp") == 0) {
-                       nfs_server.pmap.pm_prot = IPPROTO_TCP;
-                       po_remove_all(options, "proto");
-               }
-               if (strcmp(option, "udp") == 0) {
-                       nfs_server.pmap.pm_prot = IPPROTO_UDP;
-                       po_remove_all(options, "proto");
-               }
-       }
-       p = po_rightmost(options, "tcp", "udp");
-       switch (p) {
-       case PO_KEY2_RIGHTMOST:
-               nfs_server.pmap.pm_prot = IPPROTO_UDP;
-               break;
-       case PO_KEY1_RIGHTMOST:
-               nfs_server.pmap.pm_prot = IPPROTO_TCP;
-               break;
-       }
-       po_remove_all(options, "tcp");
-       po_remove_all(options, "udp");
 
-       if (!probe_bothports(&mnt_server, &nfs_server)) {
-               rpc_mount_errors("rpcbind", 0, 0);
+       if (!nfs_extract_server_addresses(options, nfs_saddr, &nfs_salen,
+                                               mnt_saddr, &mnt_salen)) {
+               errno = EINVAL;
                goto err;
        }
 
-       snprintf(new_option, sizeof(new_option) - 1,
-                "nfsvers=%lu", nfs_server.pmap.pm_vers);
-       if (po_append(options, new_option) == PO_FAILED)
-               goto err;
+       nfs_options2pmap(options, &nfs_pmap, &mnt_pmap);
 
-       if (nfs_server.pmap.pm_prot == IPPROTO_TCP)
-               snprintf(new_option, sizeof(new_option) - 1,
-                        "proto=tcp");
-       else
-               snprintf(new_option, sizeof(new_option) - 1,
-                        "proto=udp");
-       if (po_append(options, new_option) == PO_FAILED)
-               goto err;
+       /* The kernel NFS client doesn't support changing the RPC program
+        * number for these services, so reset these fields before probing
+        * the server's ports.  */
+       nfs_pmap.pm_prog = NFS_PROGRAM;
+       mnt_pmap.pm_prog = MOUNTPROG;
 
-       if (nfs_server.pmap.pm_port != NFS_PORT) {
-               snprintf(new_option, sizeof(new_option) - 1,
-                        "port=%lu", nfs_server.pmap.pm_port);
-               if (po_append(options, new_option) == PO_FAILED)
-                       goto err;
+       if (!nfs_probe_bothports(mnt_saddr, mnt_salen, &mnt_pmap,
+                                nfs_saddr, nfs_salen, &nfs_pmap)) {
+               errno = ESPIPE;
+               goto err;
+       }
 
+       if (!nfs_construct_new_options(options, &nfs_pmap, &mnt_pmap)) {
+               errno = EINVAL;
+               goto err;
        }
 
+       errno = 0;
        return options;
 
 err:
@@ -367,6 +479,27 @@ err:
        return NULL;
 }
 
+/*
+ * Do the mount(2) system call.
+ *
+ * Returns 1 if successful, otherwise zero.
+ * "errno" is set to reflect the individual error.
+ */
+static int nfs_sys_mount(const struct nfsmount_info *mi, const char *type,
+                        const char *options)
+{
+       int result;
+
+       result = mount(mi->spec, mi->node, type,
+                               mi->flags & ~(MS_USER|MS_USERS), options);
+       if (verbose && result) {
+               int save = errno;
+               nfs_error(_("%s: mount(2): %s"), progname, strerror(save));
+               errno = save;
+       }
+       return !result;
+}
+
 /*
  * Retry an NFS mount that failed because the requested service isn't
  * available on the server.
@@ -378,18 +511,15 @@ err:
  * 'extra_opts' are updated to reflect the mount options that worked.
  * If the retry fails, 'options' and 'extra_opts' are left unchanged.
  */
-static int retry_nfsmount(const char *spec, const char *node,
-                       int flags, struct mount_options *options,
-                       int fake, char **extra_opts)
+static int nfs_retry_nfs23mount(struct nfsmount_info *mi)
 {
        struct mount_options *retry_options;
        char *retry_str = NULL;
+       char **extra_opts = mi->extra_opts;
 
-       retry_options = rewrite_mount_options(*extra_opts);
-       if (!retry_options) {
-               errno = EIO;
+       retry_options = nfs_rewrite_mount_options(*extra_opts);
+       if (!retry_options)
                return 0;
-       }
 
        if (po_join(retry_options, &retry_str) == PO_FAILED) {
                po_destroy(retry_options);
@@ -401,17 +531,16 @@ static int retry_nfsmount(const char *spec, const char *node,
                printf(_("%s: text-based options (retry): '%s'\n"),
                        progname, retry_str);
 
-       if (!mount(spec, node, "nfs",
-                               flags & ~(MS_USER|MS_USERS), retry_str)) {
-               free(*extra_opts);
-               *extra_opts = retry_str;
-               po_replace(options, retry_options);
-               return 1;
+       if (!nfs_sys_mount(mi, "nfs", retry_str)) {
+               po_destroy(retry_options);
+               free(retry_str);
+               return 0;
        }
 
-       po_destroy(retry_options);
-       free(retry_str);
-       return 0;
+       free(*extra_opts);
+       *extra_opts = retry_str;
+       po_replace(mi->options, retry_options);
+       return 1;
 }
 
 /*
@@ -427,11 +556,11 @@ static int retry_nfsmount(const char *spec, const char *node,
  * 'extra_opts' are updated to reflect the mount options that worked.
  * If the retry fails, 'options' and 'extra_opts' are left unchanged.
  */
-static int try_nfs23mount(const char *spec, const char *node,
-                         int flags, struct mount_options *options,
-                         int fake, char **extra_opts)
+static int nfs_try_nfs23mount(struct nfsmount_info *mi)
 {
-       if (po_join(options, extra_opts) == PO_FAILED) {
+       char **extra_opts = mi->extra_opts;
+
+       if (po_join(mi->options, extra_opts) == PO_FAILED) {
                errno = EIO;
                return 0;
        }
@@ -440,11 +569,10 @@ static int try_nfs23mount(const char *spec, const char *node,
                printf(_("%s: text-based options: '%s'\n"),
                        progname, *extra_opts);
 
-       if (fake)
+       if (mi->fake)
                return 1;
 
-       if (!mount(spec, node, "nfs",
-                               flags & ~(MS_USER|MS_USERS), *extra_opts))
+       if (nfs_sys_mount(mi, "nfs", *extra_opts))
                return 1;
 
        /*
@@ -454,7 +582,7 @@ static int try_nfs23mount(const char *spec, const char *node,
        if (errno != EOPNOTSUPP && errno != EPROTONOSUPPORT)
                return 0;
 
-       return retry_nfsmount(spec, node, flags, options, fake, extra_opts);
+       return nfs_retry_nfs23mount(mi);
 }
 
 /*
@@ -463,11 +591,11 @@ static int try_nfs23mount(const char *spec, const char *node,
  * Returns 1 if successful.  Otherwise, returns zero.
  * "errno" is set to reflect the individual error.
  */
-static int try_nfs4mount(const char *spec, const char *node,
-                        int flags, struct mount_options *options,
-                        int fake, char **extra_opts)
+static int nfs_try_nfs4mount(struct nfsmount_info *mi)
 {
-       if (po_join(options, extra_opts) == PO_FAILED) {
+       char **extra_opts = mi->extra_opts;
+
+       if (po_join(mi->options, extra_opts) == PO_FAILED) {
                errno = EIO;
                return 0;
        }
@@ -476,31 +604,162 @@ static int try_nfs4mount(const char *spec, const char *node,
                printf(_("%s: text-based options: '%s'\n"),
                        progname, *extra_opts);
 
-       if (fake)
+       if (mi->fake)
                return 1;
 
-       if (!mount(spec, node, "nfs4",
-                               flags & ~(MS_USER|MS_USERS), *extra_opts))
-               return 1;
-       return 0;
+       return nfs_sys_mount(mi, "nfs4", *extra_opts);
 }
 
 /*
- * Try the mount(2) system call.
+ * Perform either an NFSv2/3 mount, or an NFSv4 mount system call.
  *
  * Returns 1 if successful.  Otherwise, returns zero.
  * "errno" is set to reflect the individual error.
  */
-static int try_mount(const char *spec, const char *node, const char *type,
-                    int flags, struct mount_options *options, int fake,
-                    char **extra_opts)
+static int nfs_try_mount(struct nfsmount_info *mi)
 {
-       if (strncmp(type, "nfs4", 4) == 0)
-               return try_nfs4mount(spec, node, flags,
-                                       options, fake, extra_opts);
+       if (strncmp(mi->type, "nfs4", 4) == 0)
+               return nfs_try_nfs4mount(mi);
        else
-               return try_nfs23mount(spec, node, flags,
-                                       options, fake, extra_opts);
+               return nfs_try_nfs23mount(mi);
+}
+
+/*
+ * Handle "foreground" NFS mounts.
+ *
+ * Retry the mount request for as long as the 'retry=' option says.
+ *
+ * Returns a valid mount command exit code.
+ */
+static int nfsmount_fg(struct nfsmount_info *mi)
+{
+       unsigned int secs = 1;
+       time_t timeout;
+
+       timeout = nfs_parse_retry_option(mi->options,
+                                        NFS_DEF_FG_TIMEOUT_MINUTES);
+       if (verbose)
+               printf(_("%s: timeout set for %s"),
+                       progname, ctime(&timeout));
+
+       for (;;) {
+               if (nfs_try_mount(mi))
+                       return EX_SUCCESS;
+
+               if (nfs_is_permanent_error(errno))
+                       break;
+
+               if (time(NULL) > timeout) {
+                       errno = ETIMEDOUT;
+                       break;
+               }
+
+               if (errno != ETIMEDOUT) {
+                       if (sleep(secs))
+                               break;
+                       secs <<= 1;
+                       if (secs > 10)
+                               secs = 10;
+               }
+       };
+
+       mount_error(mi->spec, mi->node, errno);
+       return EX_FAIL;
+}
+
+/*
+ * Handle "background" NFS mount [first try]
+ *
+ * Returns a valid mount command exit code.
+ *
+ * EX_BG should cause the caller to fork and invoke nfsmount_child.
+ */
+static int nfsmount_parent(struct nfsmount_info *mi)
+{
+       if (nfs_try_mount(mi))
+               return EX_SUCCESS;
+
+       if (nfs_is_permanent_error(errno)) {
+               mount_error(mi->spec, mi->node, errno);
+               return EX_FAIL;
+       }
+
+       sys_mount_errors(mi->hostname, errno, 1, 1);
+       return EX_BG;
+}
+
+/*
+ * Handle "background" NFS mount [retry daemon]
+ *
+ * Returns a valid mount command exit code: EX_SUCCESS if successful,
+ * EX_FAIL if a failure occurred.  There's nothing to catch the
+ * error return, though, so we use sys_mount_errors to log the
+ * failure.
+ */
+static int nfsmount_child(struct nfsmount_info *mi)
+{
+       unsigned int secs = 1;
+       time_t timeout;
+
+       timeout = nfs_parse_retry_option(mi->options,
+                                        NFS_DEF_BG_TIMEOUT_MINUTES);
+
+       for (;;) {
+               if (sleep(secs))
+                       break;
+               secs <<= 1;
+               if (secs > 120)
+                       secs = 120;
+
+               if (nfs_try_mount(mi))
+                       return EX_SUCCESS;
+
+               if (nfs_is_permanent_error(errno))
+                       break;
+
+               if (time(NULL) > timeout)
+                       break;
+
+               sys_mount_errors(mi->hostname, errno, 1, 1);
+       };
+
+       sys_mount_errors(mi->hostname, errno, 1, 0);
+       return EX_FAIL;
+}
+
+/*
+ * Handle "background" NFS mount
+ *
+ * Returns a valid mount command exit code.
+ */
+static int nfsmount_bg(struct nfsmount_info *mi)
+{
+       if (!mi->child)
+               return nfsmount_parent(mi);
+       else
+               return nfsmount_child(mi);
+}
+
+/*
+ * Process mount options and try a mount system call.
+ *
+ * Returns a valid mount command exit code.
+ */
+static const char *nfs_background_opttbl[] = {
+       "bg",
+       "fg",
+       NULL,
+};
+
+static int nfsmount_start(struct nfsmount_info *mi)
+{
+       if (!nfs_validate_options(mi))
+               return EX_FAIL;
+
+       if (po_rightmost(mi->options, nfs_background_opttbl) == 0)
+               return nfsmount_bg(mi);
+       else
+               return nfsmount_fg(mi);
 }
 
 /**
@@ -517,35 +776,29 @@ static int try_mount(const char *spec, const char *node, const char *type,
 int nfsmount_string(const char *spec, const char *node, const char *type,
                    int flags, char **extra_opts, int fake, int child)
 {
-       struct mount_options *options = NULL;
-       struct sockaddr_in saddr;
-       char *hostname;
-       int err, retval = EX_FAIL;
-
-       if (!parse_devname(spec, &hostname))
-               goto out;
-       err = fill_ipv4_sockaddr(hostname, &saddr);
-       free(hostname);
-       if (!err)
-               goto out;
-
-       options = po_split(*extra_opts);
-       if (!options) {
-               nfs_error(_("%s: internal option parsing error"), progname);
-               goto out;
-       }
-
-       if (!set_mandatory_options(type, &saddr, options))
-               goto out;
-
-       if (try_mount(spec, node, type, flags, options, fake, extra_opts)) {
-               mount_error(spec, node, errno);
-               goto out;
-       }
+       struct nfsmount_info mi = {
+               .spec           = spec,
+               .node           = node,
+               .type           = type,
+               .extra_opts     = extra_opts,
+               .flags          = flags,
+               .fake           = fake,
+               .child          = child,
+#ifdef IPV6_SUPPORTED
+               .family         = AF_UNSPEC,    /* either IPv4 or v6 */
+#else
+               .family         = AF_INET,      /* only IPv4 */
+#endif
+       };
+       int retval = EX_FAIL;
 
-       retval = EX_SUCCESS;
+       mi.options = po_split(*extra_opts);
+       if (mi.options) {
+               retval = nfsmount_start(&mi);
+               po_destroy(mi.options);
+       } else
+               nfs_error(_("%s: internal option parsing error"), progname);
 
-out:
-       po_destroy(options);
+       free(mi.hostname);
        return retval;
 }