mountd: fix exporting of "/" with sec= setting.

[nfs-utils.git] / support / nfs / exports.c

diff --git a/support/nfs/exports.c b/support/nfs/exports.c
index 50e83a8ec38987d5122f6b07d9b75e3ca0a8024b..dea040f1006eb830f13a031d1a55dce80555867d 100644 (file)
--- a/support/nfs/exports.c
+++ b/support/nfs/exports.c
@@ -39,12 +39,6 @@ struct flav_info flav_map[] = {
        { "krb5",       RPC_AUTH_GSS_KRB5       },
        { "krb5i",      RPC_AUTH_GSS_KRB5I      },
        { "krb5p",      RPC_AUTH_GSS_KRB5P      },
-       { "lipkey",     RPC_AUTH_GSS_LKEY       },
-       { "lipkey-i",   RPC_AUTH_GSS_LKEYI      },
-       { "lipkey-p",   RPC_AUTH_GSS_LKEYP      },
-       { "spkm3",      RPC_AUTH_GSS_SPKM       },
-       { "spkm3i",     RPC_AUTH_GSS_SPKMI      },
-       { "spkm3p",     RPC_AUTH_GSS_SPKMP      },
        { "unix",       AUTH_UNIX               },
        { "sys",        AUTH_SYS                },
        { "null",       AUTH_NULL               },
@@ -84,6 +78,32 @@ setexportent(char *fname, char *type)
        first = 1;
 }
 
+static void init_exportent (struct exportent *ee, int fromkernel)
+{
+       ee->e_flags = EXPORT_DEFAULT_FLAGS;
+       /* some kernels assume the default is sync rather than
+        * async.  More recent kernels always report one or other,
+        * but this test makes sure we assume same as kernel
+        * Ditto for wgather
+        */
+       if (fromkernel) {
+               ee->e_flags &= ~NFSEXP_ASYNC;
+               ee->e_flags &= ~NFSEXP_GATHERED_WRITES;
+       }
+       ee->e_anonuid = 65534;
+       ee->e_anongid = 65534;
+       ee->e_squids = NULL;
+       ee->e_sqgids = NULL;
+       ee->e_mountpoint = NULL;
+       ee->e_fslocmethod = FSLOC_NONE;
+       ee->e_fslocdata = NULL;
+       ee->e_secinfo[0].flav = NULL;
+       ee->e_nsquids = 0;
+       ee->e_nsqgids = 0;
+       ee->e_uuid = NULL;
+       ee->e_ttl = DEFAULT_TTL;
+}
+
 struct exportent *
 getexportent(int fromkernel, int fromexports)
 {
@@ -102,26 +122,7 @@ getexportent(int fromkernel, int fromexports)
                has_default_opts = 0;
                has_default_subtree_opts = 0;
        
-               def_ee.e_flags = EXPORT_DEFAULT_FLAGS;
-               /* some kernels assume the default is sync rather than
-                * async.  More recent kernels always report one or other,
-                * but this test makes sure we assume same as kernel
-                * Ditto for wgather
-                */
-               if (fromkernel) {
-                       def_ee.e_flags &= ~NFSEXP_ASYNC;
-                       def_ee.e_flags &= ~NFSEXP_GATHERED_WRITES;
-               }
-               def_ee.e_anonuid = 65534;
-               def_ee.e_anongid = 65534;
-               def_ee.e_squids = NULL;
-               def_ee.e_sqgids = NULL;
-               def_ee.e_mountpoint = NULL;
-               def_ee.e_fslocmethod = FSLOC_NONE;
-               def_ee.e_fslocdata = NULL;
-               def_ee.e_secinfo[0].flav = NULL;
-               def_ee.e_nsquids = 0;
-               def_ee.e_nsqgids = 0;
+               init_exportent(&def_ee, fromkernel);
 
                ok = getpath(def_ee.e_path, sizeof(def_ee.e_path));
                if (ok <= 0)
@@ -135,9 +136,14 @@ getexportent(int fromkernel, int fromexports)
                return NULL;
        }
        first = 0;
-               
-       /* Check for default options */
-       if (exp[0] == '-') {
+
+       /*
+        * Check for default options.  The kernel will never have default
+        * options in /proc/fs/nfs/exports, however due to the initial '-' in
+        * the -test-client- string from the test export we have to check that
+        * we're not reading from the kernel.
+        */
+       if (exp[0] == '-' && !fromkernel) {
                if (parseopts(exp + 1, &def_ee, 0, &has_default_subtree_opts) < 0)
                        return NULL;
                
@@ -326,6 +332,8 @@ dupexportent(struct exportent *dst, struct exportent *src)
                dst->e_mountpoint = strdup(src->e_mountpoint);
        if (src->e_fslocdata)
                dst->e_fslocdata = strdup(src->e_fslocdata);
+       if (src->e_uuid)
+               dst->e_uuid = strdup(src->e_uuid);
        dst->e_hostname = NULL;
 }
 
@@ -334,18 +342,7 @@ mkexportent(char *hname, char *path, char *options)
 {
        static struct exportent ee;
 
-       ee.e_flags = EXPORT_DEFAULT_FLAGS;
-       ee.e_anonuid = 65534;
-       ee.e_anongid = 65534;
-       ee.e_squids = NULL;
-       ee.e_sqgids = NULL;
-       ee.e_mountpoint = NULL;
-       ee.e_fslocmethod = FSLOC_NONE;
-       ee.e_fslocdata = NULL;
-       ee.e_secinfo[0].flav = NULL;
-       ee.e_nsquids = 0;
-       ee.e_nsqgids = 0;
-       ee.e_uuid = NULL;
+       init_exportent(&ee, 0);
 
        xfree(ee.e_hostname);
        ee.e_hostname = xstrdup(hname);
@@ -472,7 +469,7 @@ static void clearflags(int mask, unsigned int active, struct exportent *ep)
  * ensure that the export flags agree with the flags on each
  * pseudoflavor:
  */
-static void fix_pseudoflavor_flags(struct exportent *ep)
+void fix_pseudoflavor_flags(struct exportent *ep)
 {
        struct export_features *ef;
        struct sec_entry *p;
@@ -646,12 +643,8 @@ bad_option:
                        cp++;
        }
 
-       /*
-        * Turn on nohide which will allow this export to cross over
-        * the 'mount --bind' mount point.
-        */
-       if (ep->e_fslocdata)
-               setflags(NFSEXP_NOHIDE, active, ep);
+       if (ep->e_secinfo[0].flav == NULL)
+               secinfo_addflavor(find_flavor("sys"), ep);
        fix_pseudoflavor_flags(ep);
        ep->e_squids = squids;
        ep->e_sqgids = sqgids;
@@ -787,8 +780,9 @@ struct export_features *get_export_features(void)
        fd = open(path, O_RDONLY);
        if (fd == -1)
                goto good;
-       fd = read(fd, buf, 50);
-       if (fd == -1)
+       c = read(fd, buf, 50);
+       close(fd);
+       if (c == -1)
                goto err;
        c = sscanf(buf, "%x %x", &ef.flags, &ef.secinfo_flags);
        if (c != 2)