Fix various issues discovered by Coverity

[nfs-utils.git] / support / misc / mountpoint.c

diff --git a/support/misc/mountpoint.c b/support/misc/mountpoint.c
index 6d0f34eab4954826fd636dcf3a5dd4f1eef6b35f..2cf1324fb17a9674109221fd49dde2643f65577a 100644 (file)
--- a/support/misc/mountpoint.c
+++ b/support/misc/mountpoint.c
@@ -20,15 +20,21 @@ is_mountpoint(char *path)
         */
        char *dotdot;
        struct stat stb, pstb;
+       int rv;
 
        dotdot = malloc(strlen(path)+4);
+       if (!dotdot)
+               return 0;
        strcat(strcpy(dotdot, path), "/..");
        if (lstat(path, &stb) != 0 ||
            lstat(dotdot, &pstb) != 0)
-               return 0;
-
-       if (stb.st_dev != pstb.st_dev
-           || stb.st_ino == pstb.st_ino)
-               return 1;
-       return 0;
+               rv = 0;
+       else
+               if (stb.st_dev != pstb.st_dev ||
+                   stb.st_ino == pstb.st_ino)
+                       rv = 1;
+               else
+                       rv = 0;
+       free(dotdot);
+       return rv;
 }