From: Mark Hymers <mhy@debian.org>
Date: Tue, 26 Jul 2011 13:42:41 +0000 (+0100)
Subject: Don't use Dinstall::BugServer unless it's configured
X-Git-Url: https://git.decadent.org.uk/gitweb/?p=dak.git;a=commitdiff_plain;h=f5fccfa53b6fe1434765513652f5e255a4cf9b9a

Don't use Dinstall::BugServer unless it's configured

Signed-off-by: Mark Hymers <mhy@debian.org>
---

diff --git a/dak/override.py b/dak/override.py
index 410a3d3d..e6d47db2 100755
--- a/dak/override.py
+++ b/dak/override.py
@@ -286,6 +286,11 @@ def main ():
     session.commit()
 
     if Options.has_key("Done"):
+        if not cnf.has_key("Dinstall::BugServer"):
+            utils.warn("Asked to send Done message but Dinstall::BugServer is not configured")
+            Logger.close()
+            return
+
         Subst = {}
         Subst["__OVERRIDE_ADDRESS__"] = cnf["Dinstall::MyEmailAddress"]
         Subst["__BUG_SERVER__"] = cnf["Dinstall::BugServer"]
diff --git a/dak/rm.py b/dak/rm.py
index 2e023b7e..e8d25900 100755
--- a/dak/rm.py
+++ b/dak/rm.py
@@ -335,7 +335,10 @@ def main ():
     carbon_copy = []
     for copy_to in utils.split_args(Options.get("Carbon-Copy")):
         if copy_to.isdigit():
-            carbon_copy.append(copy_to + "@" + cnf["Dinstall::BugServer"])
+            if cnf.has_key("Dinstall::BugServer"):
+                carbon_copy.append(copy_to + "@" + cnf["Dinstall::BugServer"])
+            else:
+                utils.fubar("Asked to send mail to #%s in BTS but Dinstall::BugServer is not configured" % copy_to)
         elif copy_to == 'package':
             for package in arguments:
                 if cnf.has_key("Dinstall::PackagesServer"):
@@ -586,6 +589,19 @@ def main ():
     session.commit()
     print "done."
 
+    # If we don't have a Bug server configured, we're done
+    if not cnf.has_key("Dinstall::BugServer"):
+        if Options["Done"] or Options["Do-Close"]:
+            print "Cannot send mail to BugServer as Dinstall::BugServer is not configured"
+
+        logfile.write("=========================================================================\n")
+        logfile.close()
+
+        logfile822.write("\n")
+        logfile822.close()
+
+        return
+
     # read common subst variables for all bug closure mails
     Subst_common = {}
     Subst_common["__RM_ADDRESS__"] = cnf["Dinstall::MyEmailAddress"]