From: Ansgar Burchardt <ansgar@debian.org>
Date: Sun, 20 Dec 2015 00:43:26 +0000 (+0100)
Subject: PackageLists do not quite behave like a list of actual binaries
X-Git-Url: https://git.decadent.org.uk/gitweb/?p=dak.git;a=commitdiff_plain;h=eaeb6e11bb70258da5ca64a2acad15ae07960e18

PackageLists do not quite behave like a list of actual binaries
---

diff --git a/daklib/archive.py b/daklib/archive.py
index 010fbf7e..0174bea9 100644
--- a/daklib/archive.py
+++ b/daklib/archive.py
@@ -780,20 +780,25 @@ class ArchiveUpload(object):
 
     def _check_new_binary_overrides(self, suite):
         new = False
-
-        binaries = self.changes.binaries
         source = self.changes.source
+
         if source is not None and not source.package_list.fallback:
             packages = source.package_list.packages_for_suite(suite)
             binaries = [ entry for entry in packages ]
-
-        for b in binaries:
-            if utils.is_in_debug_section(b.control) and suite.debug_suite is not None:
-                continue
-            override = self._binary_override(suite, b)
-            if override is None:
-                self.warnings.append('binary:{0} is NEW.'.format(b.name))
-                new = True
+            for b in binaries:
+                override = self._binary_override(suite, b)
+                if override is None:
+                    self.warnings.append('binary:{0} is NEW.'.format(b.name))
+                    new = True
+        else:
+            binaries = self.changes.binaries
+            for b in binaries:
+                if utils.is_in_debug_section(b.control) and suite.debug_suite is not None:
+                    continue
+                override = self._binary_override(suite, b)
+                if override is None:
+                    self.warnings.append('binary:{0} is NEW.'.format(b.name))
+                    new = True
 
         return new