From: David Baird Date: Tue, 8 Nov 2005 18:03:58 +0000 (+0000) Subject: A few micro-edits, esp. wishlist.txt X-Git-Tag: 2.11~96 X-Git-Url: https://git.decadent.org.uk/gitweb/?a=commitdiff_plain;h=dc0c8b4a91ac443404c0a397cd53d2a78f23f97e;p=maypole.git A few micro-edits, esp. wishlist.txt git-svn-id: http://svn.maypole.perl.org/Maypole/trunk@422 48953598-375a-da11-a14b-00016c27c3ee --- diff --git a/Changes b/Changes index e7b6d37..8a93719 100644 --- a/Changes +++ b/Changes @@ -7,7 +7,7 @@ For information about current developments and future releases, see: Deprecated: Directly accessing the attributes of the request object, or the parameters in $r->params, or anything else, is DEPRECATED and likely to break in future - releases. + releases. Be good, and use proper method calls. Incompatible API changes: Maypole: diff --git a/lib/Maypole.pm b/lib/Maypole.pm index 8fead4d..9f1af35 100644 --- a/lib/Maypole.pm +++ b/lib/Maypole.pm @@ -431,7 +431,8 @@ sub handler : method $self->get_request($req); $self->parse_location; - # hook useful for declining static requests e.g. images + # hook useful for declining static requests e.g. images, or perhaps for + # sanitizing request parameters my $status = $self->start_request_hook; return $status unless $status == Maypole::Constants::OK(); diff --git a/lib/Maypole/Model/CDBI/Plain.pm b/lib/Maypole/Model/CDBI/Plain.pm index 7833c7b..37abc67 100644 --- a/lib/Maypole/Model/CDBI/Plain.pm +++ b/lib/Maypole/Model/CDBI/Plain.pm @@ -27,8 +27,6 @@ Maypole::Model::CDBI::Plain - Class::DBI model without ::Loader package Foo; use 'Maypole::Application'; - use Foo::SomeTable; - use Foo::Other::Table; Foo->config->model("Maypole::Model::CDBI::Plain"); Foo->setup([qw/ Foo::SomeTable Foo::Other::Table /]); diff --git a/wishlist.txt b/wishlist.txt index 8a73797..63e0ba3 100644 --- a/wishlist.txt +++ b/wishlist.txt @@ -10,6 +10,7 @@ send_output() should return a status code Move template test out of process() and into handler_guts() - maybe Fix bug 14570 - returning error codes breaks CGI::Maypole Write Maypole::Manual::Exceptions +Test and refactor external_redirect() Fix Mp::P::USC @@ -18,15 +19,28 @@ Fix Mp::P::USC Maypole::instance() Better plugin architecture, for models and bits of models. Investigate problems reported with adopt() - rt 15598 +Re-implement Maypole::Cache as Maypole::Plugin::Cache, probably using + start_request_hook, and not overriding handler_guts() +Handle repeat form submissions. +Implement internal_redirect(). +Build a more sophisticated app for testing. 3.0 ==== -encapsulate all request data in HTTP::Request object, and all response data +Encapsulate all request data in HTTP::Request object, and all response data in HTTP::Response object -add email handling - like Rails - via model plugins +Add email handling - like Rails - via model plugins. -add validation layer(s), or just an API +An e-commerce model plugin would be nice - or proof of concept. + +Add validation layer(s), or just an API killer apps: SVN model; mitiki; Pet Shop; +Multiple views - HTML, text-only, PDF, SOAP, XML - use request data to switch +to an alternate view_object - switch via a factory method. + +Maybe rename the model to PModel (Presentation Model)? + +