From: Pavel Shilovsky <piastry@etersoft.ru>
Date: Tue, 7 Jun 2011 17:18:13 +0000 (-0400)
Subject: mountd: Fix missing varialble assignment in auth_unix_gid
X-Git-Tag: nfs-utils-1-2-4-rc9~8
X-Git-Url: https://git.decadent.org.uk/gitweb/?a=commitdiff_plain;h=40aed2c3fb5164195a9975ae7f15ebd4b992839d;p=nfs-utils.git

mountd: Fix missing varialble assignment in auth_unix_gid

When we get into auth_unix_gid at the second time, groups_len
is not 0 and ngroups variable leave as 0. Then we use ngroups
in getgrouplist that fails in this case. This patch fixes it.

Signed-off-by: Pavel Shilovsky <piastry@etersoft.ru>
Signed-off-by: Steve Dickson <steved@redhat.com>
---

diff --git a/utils/mountd/cache.c b/utils/mountd/cache.c
index 0c4a03d..68cccdf 100644
--- a/utils/mountd/cache.c
+++ b/utils/mountd/cache.c
@@ -138,7 +138,7 @@ static void auth_unix_gid(FILE *f)
 	static gid_t *groups = NULL;
 	static int groups_len = 0;
 	gid_t *more_groups;
-	int ngroups = 0;
+	int ngroups;
 	int rv, i;
 	char *cp;
 
@@ -147,9 +147,11 @@ static void auth_unix_gid(FILE *f)
 		if (!groups)
 			return;
 
-		groups_len = ngroups = INITIAL_MANAGED_GROUPS;
+		groups_len = INITIAL_MANAGED_GROUPS;
 	}
 
+	ngroups = groups_len;
+
 	if (readline(fileno(f), &lbuf, &lbuflen) != 1)
 		return;