From: Chris Lamb <lamby@debian.org>
Date: Fri, 30 Oct 2009 13:49:48 +0000 (+0000)
Subject: Update comment about our monkeypatching of commands.getstatusoutput.
X-Git-Url: https://git.decadent.org.uk/gitweb/?a=commitdiff_plain;h=3a541681a420745b36e6b6d025ef6b649c03e7c8;hp=2738598ffe0f2913c49bc6fc6d1612f4e81bb26f;p=dak.git

Update comment about our monkeypatching of commands.getstatusoutput.

Signed-off-by: Chris Lamb <lamby@debian.org>
---

diff --git a/daklib/utils.py b/daklib/utils.py
index 0c628fb4..50a0682d 100755
--- a/daklib/utils.py
+++ b/daklib/utils.py
@@ -62,8 +62,9 @@ key_uid_email_cache = {}  #: Cache for email addresses from gpg key uids
 known_hashes = [("sha1", apt_pkg.sha1sum, (1, 8)),
                 ("sha256", apt_pkg.sha256sum, (1, 8))] #: hashes we accept for entries in .changes/.dsc
 
-# Monkeypatch commands.getstatusoutput as it returns a "0" exit code in
-# all situations under lenny's Python.
+# Monkeypatch commands.getstatusoutput as it may not return the correct exit
+# code in lenny's Python. This also affects commands.getoutput and
+# commands.getstatus.
 def dak_getstatusoutput(cmd):
     pipe = subprocess.Popen(cmd, shell=True, universal_newlines=True,
         stdout=subprocess.PIPE, stderr=subprocess.STDOUT)