From: Joerg Jaspert <joerg@debian.org>
Date: Sat, 25 Apr 2009 22:39:22 +0000 (+0200)
Subject: Merge commit 'buxy/bugfixes' into merge
X-Git-Url: https://git.decadent.org.uk/gitweb/?a=commitdiff_plain;h=35cd0972b5e14dc8727403e13fccd30776f3ae02;hp=6237cc158b46ecd9303d1a09bec56b22983bc968;p=dak.git

Merge commit 'buxy/bugfixes' into merge

* commit 'buxy/bugfixes':
  dak update-db: fixes to make it work on a fresh install
  dak init-db: properly initialize suite_architectures

Signed-off-by: Joerg Jaspert <joerg@debian.org>
---

diff --git a/dak/dakdb/update3.py b/dak/dakdb/update3.py
index c91ecf56..406cc89b 100755
--- a/dak/dakdb/update3.py
+++ b/dak/dakdb/update3.py
@@ -36,7 +36,12 @@ def do_update(self):
 
     try:
         c = self.db.cursor()
-        c.execute("DROP FUNCTION versioncmp(text, text);")
+        try:
+            # This might not exist on a fresh install, so don't fail
+            # needlessly
+            c.execute("DROP FUNCTION versioncmp(text, text);")
+        except:
+            pass
         c.execute("UPDATE config SET value = '3' WHERE name = 'db_revision'")
 
         self.db.commit()
diff --git a/dak/dakdb/update5.py b/dak/dakdb/update5.py
index beb961cc..49e33891 100755
--- a/dak/dakdb/update5.py
+++ b/dak/dakdb/update5.py
@@ -36,7 +36,6 @@ def do_update(self):
     print "Fixing bin_assoc_by_arch view"
     try:
         c = self.db.cursor()
-        c.execute("DROP VIEW bin_assoc_by_arch")
 
         c.execute("""CREATE OR REPLACE VIEW bin_assoc_by_arch AS
         SELECT ba.suite, ba.bin, a.id AS arch
diff --git a/dak/init_db.py b/dak/init_db.py
index 31a2a5a7..e15d7680 100755
--- a/dak/init_db.py
+++ b/dak/init_db.py
@@ -139,7 +139,7 @@ class InitDB(object):
             origin = sql_get(suite_config, "Origin")
             description = sql_get(suite_config, "Description")
             c.execute(suite_add, [suite.lower(), version, origin, description])
-            for architecture in self.Cnf.ValueList("Suite::%s::Architectures" % (suite)):
+            for architecture in self.Cnf.SubTree("Architectures").List():
                 architecture_id = self.projectB.get_architecture_id (architecture)
                 if architecture_id < 0:
                     utils.fubar("architecture '%s' not found in architecture"
diff --git a/docs/README.first b/docs/README.first
index 9b7aa9cb..237d63cf 100644
--- a/docs/README.first
+++ b/docs/README.first
@@ -114,6 +114,7 @@ o If you have an existing archive:
      which are needed for this.  After changing all occurences of "projectb"
      to the name of your database (as defined in DB::Name) you can run:
          psql <DB::Name> < init_pool.sql
+   * Run 'dak update-db' to upgrade the database schema.
    * Run 'dak init-db': it will populate your database with the values from
      dak.conf and apt.conf.
    * Run 'psql <DB::Name> < add_constraints.sql'.