X-Git-Url: https://git.decadent.org.uk/gitweb/?a=blobdiff_plain;f=utils%2Fmountd%2Fauth.c;h=4e1cdbd800527e40825f534781227d0867dfd0c6;hb=e873a11144f5cbfa6b54a3b2eb3af131cbd5ebbd;hp=e92138918d4b36b91201628f3e1ed884c9954910;hpb=1275be70ca6cd6c4bec07a3381f7b510086c5526;p=nfs-utils.git

diff --git a/utils/mountd/auth.c b/utils/mountd/auth.c
index e921389..4e1cdbd 100644
--- a/utils/mountd/auth.c
+++ b/utils/mountd/auth.c
@@ -30,6 +30,8 @@ enum auth_error
 
 static void		auth_fixpath(char *path);
 static char	*export_file = NULL;
+static nfs_export my_exp;
+static nfs_client my_client;
 
 extern int new_cache;
 
@@ -55,6 +57,7 @@ auth_reload()
 	last_modified = stb.st_mtime;
 
 	export_freeall();
+	memset(&my_client, 0, sizeof(my_client));
 	// export_read(export_file);
 	xtab_export_read();
 
@@ -69,8 +72,6 @@ auth_authenticate_internal(char *what, struct sockaddr_in *caller,
 	nfs_export		*exp;
 
 	if (new_cache) {
-		static nfs_export my_exp;
-		static nfs_client my_client;
 		int i;
 		/* return static nfs_export with details filled in */
 		if (my_client.m_naddr != 1 ||
@@ -80,6 +81,7 @@ auth_authenticate_internal(char *what, struct sockaddr_in *caller,
 			my_client.m_naddr = 0;
 			my_client.m_addrlist[0] = caller->sin_addr;
 			n = client_compose(caller->sin_addr);
+			*error = unknown_host;
 			if (!n)
 				return NULL;
 			strcpy(my_client.m_hostname, *n?n:"DEFAULT");
@@ -114,13 +116,12 @@ auth_authenticate_internal(char *what, struct sockaddr_in *caller,
 			*error = not_exported;
 			return NULL;
 		}
-
-		if (!(exp->m_export.e_flags & NFSEXP_INSECURE_PORT) &&
+	}
+	if (!(exp->m_export.e_flags & NFSEXP_INSECURE_PORT) &&
 		    (ntohs(caller->sin_port) <  IPPORT_RESERVED/2 ||
 		     ntohs(caller->sin_port) >= IPPORT_RESERVED)) {
-			*error = illegal_port;
-			return NULL;
-		}
+		*error = illegal_port;
+		return NULL;
 	}
 	*error = success;
 
@@ -167,7 +168,6 @@ auth_authenticate(char *what, struct sockaddr_in *caller, char *path)
 		if (p == epath) p++;
 		*p = '\0';
 	}
-	free(hp);
 
 	switch (error) {
 	case bad_path: