X-Git-Url: https://git.decadent.org.uk/gitweb/?a=blobdiff_plain;f=melanie;h=3b2596ccc4170ec5ed67d9c252efcd7301a2a910;hb=9540d873fa78598454af57f5f8a4875969ed0439;hp=805118b6298dbc73dc4eaa54f287b544db389718;hpb=7325ae11c65a454411f37bd1cf04f419480195c6;p=dak.git diff --git a/melanie b/melanie index 805118b6..3b2596cc 100755 --- a/melanie +++ b/melanie @@ -1,8 +1,8 @@ #!/usr/bin/env python # General purpose package removal tool for ftpmaster -# Copyright (C) 2000, 2001, 2002 James Troup -# $Id: melanie,v 1.28 2002-07-14 15:01:51 troup Exp $ +# Copyright (C) 2000, 2001, 2002, 2003, 2004 James Troup +# $Id: melanie,v 1.44 2005-11-15 09:50:32 ajt Exp $ # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by @@ -29,8 +29,8 @@ # o OpenBSD team decide to switch to different packet filter under BSD # license. Because Project Goal: Every user should be able to make # changes to source tree. IPF license bad!! -# o Darren try get back: says, NetBSD, FreeBSD allowed! MUAHAHAHAH!!! -# o Theo say: no care, pf much better than ipf! +# o Darren try get back: says, NetBSD, FreeBSD allowed! MUAHAHAHAH!!! +# o Theo say: no care, pf much better than ipf! # o Darren changes mind: changes license. But OpenBSD will not change # back to ipf. Darren even much more bitter. # o Darren so bitterbitter. Decides: I'LL GET BACK BY FORKING OPENBSD AND @@ -40,17 +40,19 @@ ################################################################################ -import commands, os, pg, re, string, sys, tempfile -import utils, db_access +import commands, os, pg, re, sys; +import utils, db_access; import apt_pkg, apt_inst; ################################################################################ re_strip_source_version = re.compile (r'\s+.*$'); +re_build_dep_arch = re.compile(r"\[[^]]+\]"); ################################################################################ Cnf = None; +Options = None; projectB = None; ################################################################################ @@ -64,33 +66,159 @@ Remove PACKAGE(s) from suite(s). -c, --component=COMPONENT act on this component -C, --carbon-copy=EMAIL send a CC of removal message to EMAIL -d, --done=BUG# send removal message as closure to bug# + -h, --help show this help and exit -m, --reason=MSG reason for removal -n, --no-action don't do anything -p, --partial don't affect override files + -R, --rdep-check check reverse dependencies -s, --suite=SUITE act on this suite -S, --source-only remove source only - -h, --help show this help and exit -ARCH, BUG#, COMPONENT and SUITE can be space seperated lists, e.g. - --architecture=\"m68k i386\"""" +ARCH, BUG#, COMPONENT and SUITE can be comma (or space) separated lists, e.g. + --architecture=m68k,i386""" sys.exit(exit_code) ################################################################################ -# "That's just fucking great! Game over, man! What the fuck are we -# going to do now?" +# "Hudson: What that's great, that's just fucking great man, now what +# the fuck are we supposed to do? We're in some real pretty shit now +# man...That's it man, game over man, game over, man! Game over! What +# the fuck are we gonna do now? What are we gonna do?" def game_over(): - answer = string.lower(utils.our_raw_input("Continue (y/N)? ")); + answer = utils.our_raw_input("Continue (y/N)? ").lower(); if answer != "y": print "Aborted." sys.exit(1); ################################################################################ +def reverse_depends_check(removals, suites): + print "Checking reverse dependencies..." + components = Cnf.ValueList("Suite::%s::Components" % suites[0]) + dep_problem = 0 + p2c = {}; + for architecture in Cnf.ValueList("Suite::%s::Architectures" % suites[0]): + if architecture in ["source", "all"]: + continue + deps = {}; + virtual_packages = {}; + for component in components: + filename = "%s/dists/%s/%s/binary-%s/Packages.gz" % (Cnf["Dir::Root"], suites[0], component, architecture) + # apt_pkg.ParseTagFile needs a real file handle and can't handle a GzipFile instance... + temp_filename = utils.temp_filename(); + (result, output) = commands.getstatusoutput("gunzip -c %s > %s" % (filename, temp_filename)); + if (result != 0): + utils.fubar("Gunzip invocation failed!\n%s\n" % (output), result); + packages = utils.open_file(temp_filename); + Packages = apt_pkg.ParseTagFile(packages) + while Packages.Step(): + package = Packages.Section.Find("Package") + depends = Packages.Section.Find("Depends") + if depends: + deps[package] = depends + provides = Packages.Section.Find("Provides") + # Maintain a counter for each virtual package. If a + # Provides: exists, set the counter to 0 and count all + # provides by a package not in the list for removal. + # If the counter stays 0 at the end, we know that only + # the to-be-removed packages provided this virtual + # package. + if provides: + for virtual_pkg in provides.split(","): + virtual_pkg = virtual_pkg.strip() + if virtual_pkg == package: continue + if not virtual_packages.has_key(virtual_pkg): + virtual_packages[virtual_pkg] = 0 + if package not in removals: + virtual_packages[virtual_pkg] += 1 + p2c[package] = component; + packages.close() + os.unlink(temp_filename); + + # If a virtual package is only provided by the to-be-removed + # packages, treat the virtual package as to-be-removed too. + for virtual_pkg in virtual_packages.keys(): + if virtual_packages[virtual_pkg] == 0: + removals.append(virtual_pkg) + + # Check binary dependencies (Depends) + for package in deps.keys(): + if package in removals: continue + parsed_dep = [] + try: + parsed_dep += apt_pkg.ParseDepends(deps[package]) + except ValueError, e: + print "Error for package %s: %s" % (package, e) + for dep in parsed_dep: + # Check for partial breakage. If a package has a ORed + # dependency, there is only a dependency problem if all + # packages in the ORed depends will be removed. + unsat = 0 + for dep_package, _, _ in dep: + if dep_package in removals: + unsat += 1 + if unsat == len(dep): + component = p2c[package]; + if component != "main": + what = "%s/%s" % (package, component); + else: + what = "** %s" % (package); + print "%s has an unsatisfied dependency on %s: %s" % (what, architecture, utils.pp_deps(dep)); + dep_problem = 1 + + # Check source dependencies (Build-Depends and Build-Depends-Indep) + for component in components: + filename = "%s/dists/%s/%s/source/Sources.gz" % (Cnf["Dir::Root"], suites[0], component) + # apt_pkg.ParseTagFile needs a real file handle and can't handle a GzipFile instance... + temp_filename = utils.temp_filename(); + result, output = commands.getstatusoutput("gunzip -c %s > %s" % (filename, temp_filename)) + if result != 0: + sys.stderr.write("Gunzip invocation failed!\n%s\n" % (output)) + sys.exit(result) + sources = utils.open_file(temp_filename, "r") + Sources = apt_pkg.ParseTagFile(sources) + while Sources.Step(): + source = Sources.Section.Find("Package") + if source in removals: continue + parsed_dep = [] + for build_dep_type in ["Build-Depends", "Build-Depends-Indep"]: + build_dep = Sources.Section.get(build_dep_type) + if build_dep: + # Remove [arch] information since we want to see breakage on all arches + build_dep = re_build_dep_arch.sub("", build_dep) + try: + parsed_dep += apt_pkg.ParseDepends(build_dep) + except ValueError, e: + print "Error for source %s: %s" % (source, e) + for dep in parsed_dep: + unsat = 0 + for dep_package, _, _ in dep: + if dep_package in removals: + unsat += 1 + if unsat == len(dep): + if component != "main": + source = "%s/%s" % (source, component); + else: + source = "** %s" % (source); + print "%s has an unsatisfied build-dependency: %s" % (source, utils.pp_deps(dep)) + dep_problem = 1 + sources.close() + os.unlink(temp_filename) + + if dep_problem: + print "Dependency problem found." + if not Options["No-Action"]: + game_over() + else: + print "No dependency problem found." + print + +################################################################################ + def main (): - global Cnf, projectB; + global Cnf, Options, projectB; Cnf = utils.get_conf() @@ -100,6 +228,7 @@ def main (): ('c',"component", "Melanie::Options::Component", "HasArg"), ('C',"carbon-copy", "Melanie::Options::Carbon-Copy", "HasArg"), # Bugs to Cc ('d',"done","Melanie::Options::Done", "HasArg"), # Bugs fixed + ('R',"rdep-check", "Melanie::Options::Rdep-Check"), ('m',"reason", "Melanie::Options::Reason", "HasArg"), # Hysterical raisins; -m is old-dinstall option for rejection reason ('n',"no-action","Melanie::Options::No-Action"), ('p',"partial", "Melanie::Options::Partial"), @@ -107,7 +236,9 @@ def main (): ('S',"source-only", "Melanie::Options::Source-Only"), ]; - for i in ["help", "architecture", "binary-only", "component", "carbon-copy", "done", "reason", "no-action", "partial", "source-only" ]: + for i in [ "architecture", "binary-only", "carbon-copy", "component", + "done", "help", "no-action", "partial", "rdep-check", "reason", + "source-only" ]: if not Cnf.has_key("Melanie::Options::%s" % (i)): Cnf["Melanie::Options::%s" % (i)] = ""; if not Cnf.has_key("Melanie::Options::Suite"): @@ -135,6 +266,12 @@ def main (): utils.warn("-a/--architecture implies -p/--partial."); Options["Partial"] = "true"; + # Force the admin to tell someone if we're not doing a rene-led removal + # (or closing a bug, which counts as telling someone). + if not Options["No-Action"] and not Options["Carbon-Copy"] \ + and not Options["Done"] and Options["Reason"].find("[rene]") == -1: + utils.fubar("Need a -C/--carbon-copy if not closing a bug and not doing a rene-led removal."); + # Process -C/--carbon-copy # # Accept 3 types of arguments (space separated): @@ -143,7 +280,7 @@ def main (): # 3) contains a '@' - assumed to be an email address, used unmofidied # carbon_copy = []; - for copy_to in string.split(Options.get("Carbon-Copy")): + for copy_to in utils.split_args(Options.get("Carbon-Copy")): if utils.str_isnum(copy_to): carbon_copy.append(copy_to + "@" + Cnf["Dinstall::BugServer"]); elif copy_to == 'package': @@ -160,16 +297,20 @@ def main (): field = "b.package"; else: field = "s.source"; - con_packages = "AND %s IN (%s)" % (field, string.join(map(repr, arguments), ", ")); + con_packages = "AND %s IN (%s)" % (field, ", ".join(map(repr, arguments))); (con_suites, con_architectures, con_components, check_source) = \ utils.parse_args(Options); # Additional suite checks - suites = string.split(Options["Suite"]); + suite_ids_list = []; + suites = utils.split_args(Options["Suite"]); suites_list = utils.join_with_commas_and(suites); if not Options["No-Action"]: for suite in suites: + suite_id = db_access.get_suite_id(suite); + if suite_id != -1: + suite_ids_list.append(suite_id); if suite == "stable": print "**WARNING** About to remove from the stable suite!" print "This should only be done just prior to a (point) release and not at" @@ -186,7 +327,7 @@ def main (): utils.warn("'source' in -a/--argument makes no sense and is ignored."); # Additional component processing - over_con_components = string.replace(con_components, "c.id", "component"); + over_con_components = con_components.replace("c.id", "component"); print "Working...", sys.stdout.flush(); @@ -214,19 +355,19 @@ def main (): # Source + Binary binary_packages = {}; # First get a list of binary package names we suspect are linked to the source - q = projectB.query("SELECT DISTINCT package FROM binaries WHERE EXISTS (SELECT s.source, s.version, l.path, f.filename FROM source s, src_associations sa, suite su, files f, location l, component c WHERE binaries.source = s.id AND sa.source = s.id AND sa.suite = su.id AND s.file = f.id AND f.location = l.id AND l.component = c.id %s %s %s)" % (con_packages, con_suites, con_components)); + q = projectB.query("SELECT DISTINCT b.package FROM binaries b, source s, src_associations sa, suite su, files f, location l, component c WHERE b.source = s.id AND sa.source = s.id AND sa.suite = su.id AND s.file = f.id AND f.location = l.id AND l.component = c.id %s %s %s" % (con_packages, con_suites, con_components)); for i in q.getresult(): binary_packages[i[0]] = ""; # Then parse each .dsc that we found earlier to see what binary packages it thinks it produces for i in source_packages.keys(): - filename = string.join(source_packages[i], '/'); + filename = "/".join(source_packages[i]); try: dsc = utils.parse_changes(filename); except utils.cant_open_exc: utils.warn("couldn't open '%s'." % (filename)); continue; - for package in string.split(dsc.get("binary"), ','): - package = string.strip(package); + for package in dsc.get("binary").split(','): + package = package.strip(); binary_packages[package] = ""; # Then for each binary package: find any version in # unstable, check the Source: field in the deb matches our @@ -235,7 +376,7 @@ def main (): for package in binary_packages.keys(): q = projectB.query("SELECT l.path, f.filename, b.package, b.version, a.arch_string, b.id, b.maintainer FROM binaries b, bin_associations ba, architecture a, suite su, files f, location l, component c WHERE ba.bin = b.id AND ba.suite = su.id AND b.architecture = a.id AND b.file = f.id AND f.location = l.id AND l.component = c.id %s %s %s AND b.package = '%s'" % (con_suites, con_components, con_architectures, package)); for i in q.getresult(): - filename = string.join(i[:2], '/'); + filename = "/".join(i[:2]); control = apt_pkg.ParseSection(apt_inst.debExtractControl(utils.open_file(filename))) source = control.Find("Source", control.Find("Package")); source = re_strip_source_version.sub('', source); @@ -250,16 +391,15 @@ def main (): # If we don't have a reason; spawn an editor so the user can add one # Write the rejection email out as the .reason file if not Options["Reason"] and not Options["No-Action"]: - temp_filename = tempfile.mktemp(); - fd = os.open(temp_filename, os.O_RDWR|os.O_CREAT|os.O_EXCL, 0700); - os.close(fd); + temp_filename = utils.temp_filename(); editor = os.environ.get("EDITOR","vi") result = os.system("%s %s" % (editor, temp_filename)) if result != 0: utils.fubar ("vi invocation failed for `%s'!" % (temp_filename), result) - file = utils.open_file(temp_filename); - for line in file.readlines(): - Options["Reason"] = Options["Reason"] + line; + temp_file = utils.open_file(temp_filename); + for line in temp_file.readlines(): + Options["Reason"] += line; + temp_file.close(); os.unlink(temp_filename); # Generate the summary of what's to be removed @@ -281,31 +421,36 @@ def main (): for maintainer_id in maintainers.keys(): maintainer_list.append(db_access.get_maintainer(maintainer_id)); summary = ""; - packages = d.keys(); - packages.sort(); - for package in packages: + removals = d.keys(); + removals.sort(); + for package in removals: versions = d[package].keys(); - versions.sort(); + versions.sort(apt_pkg.VersionCompare); for version in versions: - summary = summary + "%10s | %10s | %s\n" % (package, version, string.join(d[package][version], ", ")); + d[package][version].sort(utils.arch_compare_sw); + summary += "%10s | %10s | %s\n" % (package, version, ", ".join(d[package][version])); print "Will remove the following packages from %s:" % (suites_list); print print summary - print "Maintainer: %s" % string.join(maintainer_list, ", ") + print "Maintainer: %s" % ", ".join(maintainer_list) if Options["Done"]: print "Will also close bugs: "+Options["Done"]; if carbon_copy: - print "Will also send CCs to:" + string.join(carbon_copy, ", ") + print "Will also send CCs to: " + ", ".join(carbon_copy) print print "------------------- Reason -------------------" print Options["Reason"]; print "----------------------------------------------" print + if Options["Rdep-Check"]: + reverse_depends_check(removals, suites); + # If -n/--no-action, drop out here if Options["No-Action"]: sys.exit(0); + print "Going to remove the packages now." game_over(); whoami = utils.whoami(); @@ -361,12 +506,12 @@ def main (): if Cnf.Find("Melanie::Bcc") != "": bcc.append(Cnf["Melanie::Bcc"]); if bcc: - Subst["__BCC__"] = "Bcc: " + string.join(bcc, ", "); + Subst["__BCC__"] = "Bcc: " + ", ".join(bcc); else: Subst["__BCC__"] = "X-Filler: 42"; - Subst["__CC__"] = "X-Melanie: $Revision: 1.28 $"; + Subst["__CC__"] = "X-Katie: melanie $Revision: 1.44 $"; if carbon_copy: - Subst["__CC__"] = Subst["__CC__"] + "\nCc: " + string.join(carbon_copy, ", "); + Subst["__CC__"] += "\nCc: " + ", ".join(carbon_copy); Subst["__SUITE_LIST__"] = suites_list; Subst["__SUMMARY__"] = summary; Subst["__ADMIN_ADDRESS__"] = Cnf["Dinstall::MyAdminAddress"]; @@ -376,10 +521,10 @@ def main (): Archive = Cnf.SubTree("Archive::%s" % (whereami)); Subst["__MASTER_ARCHIVE__"] = Archive["OriginServer"]; Subst["__PRIMARY_MIRROR__"] = Archive["PrimaryMirror"]; - for bug in string.split(Options["Done"]): + for bug in utils.split_args(Options["Done"]): Subst["__BUG_NUMBER__"] = bug; mail_message = utils.TemplateSubst(Subst,Cnf["Dir::Templates"]+"/melanie.bug-close"); - utils.send_mail (mail_message, "") + utils.send_mail(mail_message); logfile.write("=========================================================================\n"); logfile.close();