X-Git-Url: https://git.decadent.org.uk/gitweb/?a=blobdiff_plain;f=melanie;h=3b2596ccc4170ec5ed67d9c252efcd7301a2a910;hb=9540d873fa78598454af57f5f8a4875969ed0439;hp=38b81b3733c590057ae2d623f2c8a2a87293efd8;hpb=4cb4df2ea33374acb5f6f04eaddea06977dfb620;p=dak.git diff --git a/melanie b/melanie index 38b81b37..3b2596cc 100755 --- a/melanie +++ b/melanie @@ -1,8 +1,8 @@ #!/usr/bin/env python # General purpose package removal tool for ftpmaster -# Copyright (C) 2000, 2001, 2002, 2003 James Troup -# $Id: melanie,v 1.39 2003-05-02 13:53:57 troup Exp $ +# Copyright (C) 2000, 2001, 2002, 2003, 2004 James Troup +# $Id: melanie,v 1.44 2005-11-15 09:50:32 ajt Exp $ # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by @@ -40,17 +40,19 @@ ################################################################################ -import commands, os, pg, re, sys, tempfile -import utils, db_access +import commands, os, pg, re, sys; +import utils, db_access; import apt_pkg, apt_inst; ################################################################################ re_strip_source_version = re.compile (r'\s+.*$'); +re_build_dep_arch = re.compile(r"\[[^]]+\]"); ################################################################################ Cnf = None; +Options = None; projectB = None; ################################################################################ @@ -68,6 +70,7 @@ Remove PACKAGE(s) from suite(s). -m, --reason=MSG reason for removal -n, --no-action don't do anything -p, --partial don't affect override files + -R, --rdep-check check reverse dependencies -s, --suite=SUITE act on this suite -S, --source-only remove source only @@ -91,8 +94,131 @@ def game_over(): ################################################################################ +def reverse_depends_check(removals, suites): + print "Checking reverse dependencies..." + components = Cnf.ValueList("Suite::%s::Components" % suites[0]) + dep_problem = 0 + p2c = {}; + for architecture in Cnf.ValueList("Suite::%s::Architectures" % suites[0]): + if architecture in ["source", "all"]: + continue + deps = {}; + virtual_packages = {}; + for component in components: + filename = "%s/dists/%s/%s/binary-%s/Packages.gz" % (Cnf["Dir::Root"], suites[0], component, architecture) + # apt_pkg.ParseTagFile needs a real file handle and can't handle a GzipFile instance... + temp_filename = utils.temp_filename(); + (result, output) = commands.getstatusoutput("gunzip -c %s > %s" % (filename, temp_filename)); + if (result != 0): + utils.fubar("Gunzip invocation failed!\n%s\n" % (output), result); + packages = utils.open_file(temp_filename); + Packages = apt_pkg.ParseTagFile(packages) + while Packages.Step(): + package = Packages.Section.Find("Package") + depends = Packages.Section.Find("Depends") + if depends: + deps[package] = depends + provides = Packages.Section.Find("Provides") + # Maintain a counter for each virtual package. If a + # Provides: exists, set the counter to 0 and count all + # provides by a package not in the list for removal. + # If the counter stays 0 at the end, we know that only + # the to-be-removed packages provided this virtual + # package. + if provides: + for virtual_pkg in provides.split(","): + virtual_pkg = virtual_pkg.strip() + if virtual_pkg == package: continue + if not virtual_packages.has_key(virtual_pkg): + virtual_packages[virtual_pkg] = 0 + if package not in removals: + virtual_packages[virtual_pkg] += 1 + p2c[package] = component; + packages.close() + os.unlink(temp_filename); + + # If a virtual package is only provided by the to-be-removed + # packages, treat the virtual package as to-be-removed too. + for virtual_pkg in virtual_packages.keys(): + if virtual_packages[virtual_pkg] == 0: + removals.append(virtual_pkg) + + # Check binary dependencies (Depends) + for package in deps.keys(): + if package in removals: continue + parsed_dep = [] + try: + parsed_dep += apt_pkg.ParseDepends(deps[package]) + except ValueError, e: + print "Error for package %s: %s" % (package, e) + for dep in parsed_dep: + # Check for partial breakage. If a package has a ORed + # dependency, there is only a dependency problem if all + # packages in the ORed depends will be removed. + unsat = 0 + for dep_package, _, _ in dep: + if dep_package in removals: + unsat += 1 + if unsat == len(dep): + component = p2c[package]; + if component != "main": + what = "%s/%s" % (package, component); + else: + what = "** %s" % (package); + print "%s has an unsatisfied dependency on %s: %s" % (what, architecture, utils.pp_deps(dep)); + dep_problem = 1 + + # Check source dependencies (Build-Depends and Build-Depends-Indep) + for component in components: + filename = "%s/dists/%s/%s/source/Sources.gz" % (Cnf["Dir::Root"], suites[0], component) + # apt_pkg.ParseTagFile needs a real file handle and can't handle a GzipFile instance... + temp_filename = utils.temp_filename(); + result, output = commands.getstatusoutput("gunzip -c %s > %s" % (filename, temp_filename)) + if result != 0: + sys.stderr.write("Gunzip invocation failed!\n%s\n" % (output)) + sys.exit(result) + sources = utils.open_file(temp_filename, "r") + Sources = apt_pkg.ParseTagFile(sources) + while Sources.Step(): + source = Sources.Section.Find("Package") + if source in removals: continue + parsed_dep = [] + for build_dep_type in ["Build-Depends", "Build-Depends-Indep"]: + build_dep = Sources.Section.get(build_dep_type) + if build_dep: + # Remove [arch] information since we want to see breakage on all arches + build_dep = re_build_dep_arch.sub("", build_dep) + try: + parsed_dep += apt_pkg.ParseDepends(build_dep) + except ValueError, e: + print "Error for source %s: %s" % (source, e) + for dep in parsed_dep: + unsat = 0 + for dep_package, _, _ in dep: + if dep_package in removals: + unsat += 1 + if unsat == len(dep): + if component != "main": + source = "%s/%s" % (source, component); + else: + source = "** %s" % (source); + print "%s has an unsatisfied build-dependency: %s" % (source, utils.pp_deps(dep)) + dep_problem = 1 + sources.close() + os.unlink(temp_filename) + + if dep_problem: + print "Dependency problem found." + if not Options["No-Action"]: + game_over() + else: + print "No dependency problem found." + print + +################################################################################ + def main (): - global Cnf, projectB; + global Cnf, Options, projectB; Cnf = utils.get_conf() @@ -102,6 +228,7 @@ def main (): ('c',"component", "Melanie::Options::Component", "HasArg"), ('C',"carbon-copy", "Melanie::Options::Carbon-Copy", "HasArg"), # Bugs to Cc ('d',"done","Melanie::Options::Done", "HasArg"), # Bugs fixed + ('R',"rdep-check", "Melanie::Options::Rdep-Check"), ('m',"reason", "Melanie::Options::Reason", "HasArg"), # Hysterical raisins; -m is old-dinstall option for rejection reason ('n',"no-action","Melanie::Options::No-Action"), ('p',"partial", "Melanie::Options::Partial"), @@ -109,7 +236,9 @@ def main (): ('S',"source-only", "Melanie::Options::Source-Only"), ]; - for i in ["help", "architecture", "binary-only", "component", "carbon-copy", "done", "reason", "no-action", "partial", "source-only" ]: + for i in [ "architecture", "binary-only", "carbon-copy", "component", + "done", "help", "no-action", "partial", "rdep-check", "reason", + "source-only" ]: if not Cnf.has_key("Melanie::Options::%s" % (i)): Cnf["Melanie::Options::%s" % (i)] = ""; if not Cnf.has_key("Melanie::Options::Suite"): @@ -139,8 +268,8 @@ def main (): # Force the admin to tell someone if we're not doing a rene-led removal # (or closing a bug, which counts as telling someone). - if not Options["Carbon-Copy"] and not Options["Done"] \ - and Options["Reason"].find("[rene]") == -1: + if not Options["No-Action"] and not Options["Carbon-Copy"] \ + and not Options["Done"] and Options["Reason"].find("[rene]") == -1: utils.fubar("Need a -C/--carbon-copy if not closing a bug and not doing a rene-led removal."); # Process -C/--carbon-copy @@ -262,16 +391,15 @@ def main (): # If we don't have a reason; spawn an editor so the user can add one # Write the rejection email out as the .reason file if not Options["Reason"] and not Options["No-Action"]: - temp_filename = tempfile.mktemp(); - fd = os.open(temp_filename, os.O_RDWR|os.O_CREAT|os.O_EXCL, 0700); - os.close(fd); + temp_filename = utils.temp_filename(); editor = os.environ.get("EDITOR","vi") result = os.system("%s %s" % (editor, temp_filename)) if result != 0: utils.fubar ("vi invocation failed for `%s'!" % (temp_filename), result) - file = utils.open_file(temp_filename); - for line in file.readlines(): + temp_file = utils.open_file(temp_filename); + for line in temp_file.readlines(): Options["Reason"] += line; + temp_file.close(); os.unlink(temp_filename); # Generate the summary of what's to be removed @@ -293,9 +421,9 @@ def main (): for maintainer_id in maintainers.keys(): maintainer_list.append(db_access.get_maintainer(maintainer_id)); summary = ""; - packages = d.keys(); - packages.sort(); - for package in packages: + removals = d.keys(); + removals.sort(); + for package in removals: versions = d[package].keys(); versions.sort(apt_pkg.VersionCompare); for version in versions: @@ -315,10 +443,14 @@ def main (): print "----------------------------------------------" print + if Options["Rdep-Check"]: + reverse_depends_check(removals, suites); + # If -n/--no-action, drop out here if Options["No-Action"]: sys.exit(0); + print "Going to remove the packages now." game_over(); whoami = utils.whoami(); @@ -377,7 +509,7 @@ def main (): Subst["__BCC__"] = "Bcc: " + ", ".join(bcc); else: Subst["__BCC__"] = "X-Filler: 42"; - Subst["__CC__"] = "X-Katie: melanie $Revision: 1.39 $"; + Subst["__CC__"] = "X-Katie: melanie $Revision: 1.44 $"; if carbon_copy: Subst["__CC__"] += "\nCc: " + ", ".join(carbon_copy); Subst["__SUITE_LIST__"] = suites_list;