X-Git-Url: https://git.decadent.org.uk/gitweb/?a=blobdiff_plain;f=melanie;h=23b89e5413723dc32efc4a0a47bae63089b72c80;hb=3686a00f1001f2d5692fa5e706b898053e39191a;hp=4042ef195485d9659b2e724e5940e5ffd858639f;hpb=258ca5e76f4c66976b363a00d7bef40d4bd6f277;p=dak.git diff --git a/melanie b/melanie index 4042ef19..23b89e54 100755 --- a/melanie +++ b/melanie @@ -1,8 +1,8 @@ #!/usr/bin/env python # General purpose package removal tool for ftpmaster -# Copyright (C) 2000, 2001, 2002 James Troup -# $Id: melanie,v 1.30 2002-08-29 22:56:29 troup Exp $ +# Copyright (C) 2000, 2001, 2002, 2003, 2004 James Troup +# $Id: melanie,v 1.40 2004-04-01 17:13:11 troup Exp $ # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by @@ -40,8 +40,8 @@ ################################################################################ -import commands, os, pg, re, string, sys, tempfile -import utils, db_access +import commands, os, pg, re, sys; +import utils, db_access; import apt_pkg, apt_inst; ################################################################################ @@ -64,25 +64,27 @@ Remove PACKAGE(s) from suite(s). -c, --component=COMPONENT act on this component -C, --carbon-copy=EMAIL send a CC of removal message to EMAIL -d, --done=BUG# send removal message as closure to bug# + -h, --help show this help and exit -m, --reason=MSG reason for removal -n, --no-action don't do anything -p, --partial don't affect override files -s, --suite=SUITE act on this suite -S, --source-only remove source only - -h, --help show this help and exit -ARCH, BUG#, COMPONENT and SUITE can be space seperated lists, e.g. - --architecture=\"m68k i386\"""" +ARCH, BUG#, COMPONENT and SUITE can be comma (or space) separated lists, e.g. + --architecture=m68k,i386""" sys.exit(exit_code) ################################################################################ -# "That's just fucking great! Game over, man! What the fuck are we -# going to do now?" +# "Hudson: What that's great, that's just fucking great man, now what +# the fuck are we supposed to do? We're in some real pretty shit now +# man...That's it man, game over man, game over, man! Game over! What +# the fuck are we gonna do now? What are we gonna do?" def game_over(): - answer = string.lower(utils.our_raw_input("Continue (y/N)? ")); + answer = utils.our_raw_input("Continue (y/N)? ").lower(); if answer != "y": print "Aborted." sys.exit(1); @@ -135,6 +137,12 @@ def main (): utils.warn("-a/--architecture implies -p/--partial."); Options["Partial"] = "true"; + # Force the admin to tell someone if we're not doing a rene-led removal + # (or closing a bug, which counts as telling someone). + if not Options["Carbon-Copy"] and not Options["Done"] \ + and Options["Reason"].find("[rene]") == -1: + utils.fubar("Need a -C/--carbon-copy if not closing a bug and not doing a rene-led removal."); + # Process -C/--carbon-copy # # Accept 3 types of arguments (space separated): @@ -143,7 +151,7 @@ def main (): # 3) contains a '@' - assumed to be an email address, used unmofidied # carbon_copy = []; - for copy_to in string.split(Options.get("Carbon-Copy")): + for copy_to in utils.split_args(Options.get("Carbon-Copy")): if utils.str_isnum(copy_to): carbon_copy.append(copy_to + "@" + Cnf["Dinstall::BugServer"]); elif copy_to == 'package': @@ -160,14 +168,14 @@ def main (): field = "b.package"; else: field = "s.source"; - con_packages = "AND %s IN (%s)" % (field, string.join(map(repr, arguments), ", ")); + con_packages = "AND %s IN (%s)" % (field, ", ".join(map(repr, arguments))); (con_suites, con_architectures, con_components, check_source) = \ utils.parse_args(Options); # Additional suite checks suite_ids_list = []; - suites = string.split(Options["Suite"]); + suites = utils.split_args(Options["Suite"]); suites_list = utils.join_with_commas_and(suites); if not Options["No-Action"]: for suite in suites: @@ -190,7 +198,7 @@ def main (): utils.warn("'source' in -a/--argument makes no sense and is ignored."); # Additional component processing - over_con_components = string.replace(con_components, "c.id", "component"); + over_con_components = con_components.replace("c.id", "component"); print "Working...", sys.stdout.flush(); @@ -223,14 +231,14 @@ def main (): binary_packages[i[0]] = ""; # Then parse each .dsc that we found earlier to see what binary packages it thinks it produces for i in source_packages.keys(): - filename = string.join(source_packages[i], '/'); + filename = "/".join(source_packages[i]); try: dsc = utils.parse_changes(filename); except utils.cant_open_exc: utils.warn("couldn't open '%s'." % (filename)); continue; - for package in string.split(dsc.get("binary"), ','): - package = string.strip(package); + for package in dsc.get("binary").split(','): + package = package.strip(); binary_packages[package] = ""; # Then for each binary package: find any version in # unstable, check the Source: field in the deb matches our @@ -239,7 +247,7 @@ def main (): for package in binary_packages.keys(): q = projectB.query("SELECT l.path, f.filename, b.package, b.version, a.arch_string, b.id, b.maintainer FROM binaries b, bin_associations ba, architecture a, suite su, files f, location l, component c WHERE ba.bin = b.id AND ba.suite = su.id AND b.architecture = a.id AND b.file = f.id AND f.location = l.id AND l.component = c.id %s %s %s AND b.package = '%s'" % (con_suites, con_components, con_architectures, package)); for i in q.getresult(): - filename = string.join(i[:2], '/'); + filename = "/".join(i[:2]); control = apt_pkg.ParseSection(apt_inst.debExtractControl(utils.open_file(filename))) source = control.Find("Source", control.Find("Package")); source = re_strip_source_version.sub('', source); @@ -254,16 +262,14 @@ def main (): # If we don't have a reason; spawn an editor so the user can add one # Write the rejection email out as the .reason file if not Options["Reason"] and not Options["No-Action"]: - temp_filename = tempfile.mktemp(); - fd = os.open(temp_filename, os.O_RDWR|os.O_CREAT|os.O_EXCL, 0700); - os.close(fd); + temp_filename = utils.temp_filename(); editor = os.environ.get("EDITOR","vi") result = os.system("%s %s" % (editor, temp_filename)) if result != 0: utils.fubar ("vi invocation failed for `%s'!" % (temp_filename), result) file = utils.open_file(temp_filename); for line in file.readlines(): - Options["Reason"] = Options["Reason"] + line; + Options["Reason"] += line; os.unlink(temp_filename); # Generate the summary of what's to be removed @@ -289,17 +295,18 @@ def main (): packages.sort(); for package in packages: versions = d[package].keys(); - versions.sort(); + versions.sort(apt_pkg.VersionCompare); for version in versions: - summary = summary + "%10s | %10s | %s\n" % (package, version, string.join(d[package][version], ", ")); + d[package][version].sort(utils.arch_compare_sw); + summary += "%10s | %10s | %s\n" % (package, version, ", ".join(d[package][version])); print "Will remove the following packages from %s:" % (suites_list); print print summary - print "Maintainer: %s" % string.join(maintainer_list, ", ") + print "Maintainer: %s" % ", ".join(maintainer_list) if Options["Done"]: print "Will also close bugs: "+Options["Done"]; if carbon_copy: - print "Will also send CCs to:" + string.join(carbon_copy, ", ") + print "Will also send CCs to: " + ", ".join(carbon_copy) print print "------------------- Reason -------------------" print Options["Reason"]; @@ -365,12 +372,12 @@ def main (): if Cnf.Find("Melanie::Bcc") != "": bcc.append(Cnf["Melanie::Bcc"]); if bcc: - Subst["__BCC__"] = "Bcc: " + string.join(bcc, ", "); + Subst["__BCC__"] = "Bcc: " + ", ".join(bcc); else: Subst["__BCC__"] = "X-Filler: 42"; - Subst["__CC__"] = "X-Melanie: $Revision: 1.30 $"; + Subst["__CC__"] = "X-Katie: melanie $Revision: 1.40 $"; if carbon_copy: - Subst["__CC__"] = Subst["__CC__"] + "\nCc: " + string.join(carbon_copy, ", "); + Subst["__CC__"] += "\nCc: " + ", ".join(carbon_copy); Subst["__SUITE_LIST__"] = suites_list; Subst["__SUMMARY__"] = summary; Subst["__ADMIN_ADDRESS__"] = Cnf["Dinstall::MyAdminAddress"]; @@ -380,10 +387,10 @@ def main (): Archive = Cnf.SubTree("Archive::%s" % (whereami)); Subst["__MASTER_ARCHIVE__"] = Archive["OriginServer"]; Subst["__PRIMARY_MIRROR__"] = Archive["PrimaryMirror"]; - for bug in string.split(Options["Done"]): + for bug in utils.split_args(Options["Done"]): Subst["__BUG_NUMBER__"] = bug; mail_message = utils.TemplateSubst(Subst,Cnf["Dir::Templates"]+"/melanie.bug-close"); - utils.send_mail (mail_message, "") + utils.send_mail(mail_message); logfile.write("=========================================================================\n"); logfile.close();