X-Git-Url: https://git.decadent.org.uk/gitweb/?a=blobdiff_plain;f=lib%2FMaypole.pm;h=d5d932c4816a32c8e78c4650e6042ffc9b04f938;hb=81b617ffe75c0d5924595fc5b832733c7bfbcc28;hp=9a86489b8127d7cbb0914409d88ca0a415948415;hpb=74800a709376d0ce878cabd9db6b3578c002606c;p=maypole.git diff --git a/lib/Maypole.pm b/lib/Maypole.pm index 9a86489..d5d932c 100644 --- a/lib/Maypole.pm +++ b/lib/Maypole.pm @@ -2,7 +2,6 @@ package Maypole; use base qw(Class::Accessor Class::Data::Inheritable); use attributes (); use UNIVERSAL::require; -use Apache::Constants ":common"; use strict; use warnings; our $VERSION = "1.1"; @@ -12,6 +11,11 @@ args action template )); __PACKAGE__->config({}); __PACKAGE__->init_done(0); +# Ape Apache::Constants interface +use constant OK => 0; +use constant DECLINED => -1; + +sub debug { 0 } sub setup { my $calling_class = shift; @@ -56,6 +60,10 @@ sub handler { my $status = $r->is_applicable; if ($status == OK) { $status = $r->call_authenticate; + if ($r->debug and $status != OK and $status != DECLINED) { + $r->view_object->error($r, + "Got unexpected status $status from calling authentication"); + } return $status unless $status == OK; $r->additional_data(); @@ -67,25 +75,31 @@ sub handler { $r->{path} =~ s{/}{}; # De-absolutify $r->template($r->{path}); } - return $r->view_object->process($r); + $status = OK; + if (!$r->{output}) { # You might want to do it yourself + $status = $r->view_object->process($r); + } + $r->send_output; + return $status; } sub is_applicable { my $self = shift; my $config = $self->config; $config->{ok_tables} = {map {$_ => 1} @{$config->{display_tables}}}; - #warn "We don't have that table ($self->{table})" - # unless $config->{ok_tables}{$self->{table}}; + warn "We don't have that table ($self->{table})" + if $self->debug and not $config->{ok_tables}{$self->{table}}; return DECLINED() unless exists $config->{ok_tables}{$self->{table}}; # Does the action method exist? my $cv = $self->model_class->can($self->{action}); - #warn "We don't have that action ($self->{action})" unless $cv; + warn "We don't have that action ($self->{action})" + if $self->debug and not $cv; return DECLINED() unless $cv; # Is it exported? $self->{method_attribs} = join " ", attributes::get($cv); - do { # warn "$self->{action} not exported"; + do { warn "$self->{action} not exported" if $self->debug; return DECLINED() } unless $self->{method_attribs} =~ /\bExported\b/i; return OK(); @@ -219,14 +233,17 @@ class which does not specify how to communicate with the outside world. The most popular subclass of Maypole is L, which interfaces the Maypole framework to Apache mod_perl. -If you are implementing Maypole subclasses, you need to provide at least -the C and C methods. See the +If you are implementing Maypole subclasses, you need to provide at least +the C and C methods. You may also want to +provide C and C. See the L documentation for what these are expected to do. =cut -sub get_request { die "Do not use Maypole directly; use Apache::MVC or similar" } +sub get_template_root { "." } +sub get_request { } sub parse_location { die "Do not use Maypole directly; use Apache::MVC or similar" } +sub send_output{ die "Do not use Maypole directly; use Apache::MVC or similar" } =head1 AUTHOR