X-Git-Url: https://git.decadent.org.uk/gitweb/?a=blobdiff_plain;f=daklib%2Fqueue.py;h=8ab693a86e89bbe72c30916ace7916687c01ca75;hb=6794769445e4dab2f87a87137190b17af739e0c7;hp=a18af9819180d025ec93c5c9e65aa0c5fffa87e4;hpb=efce802a6ec81a0c9fa877cd6bd213b1db40fd23;p=dak.git diff --git a/daklib/queue.py b/daklib/queue.py index a18af981..8ab693a8 100755 --- a/daklib/queue.py +++ b/daklib/queue.py @@ -1197,6 +1197,8 @@ class Upload(object): ########################################################################### def check_lintian(self): + cnf = Config() + # Only check some distributions valid_dist = False for dist in ('unstable', 'experimental'): @@ -1207,13 +1209,78 @@ class Upload(object): if not valid_dist: return - self.ensure_all_source_exists() - - cnf = Config() tagfile = cnf.get("Dinstall::LintianTags") if tagfile is None: # We don't have a tagfile, so just don't do anything. return + + # Try and find all orig mentioned in the .dsc + target_dir = '.' + symlinked = [] + for filename, entry in self.pkg.dsc_files.iteritems(): + if not re_is_orig_source.match(filename): + # File is not an orig; ignore + continue + + if os.path.exists(filename): + # File exists, no need to continue + continue + + def symlink_if_valid(path): + f = utils.open_file(path) + md5sum = apt_pkg.md5sum(f) + f.close() + + fingerprint = (os.stat(path)[stat.ST_SIZE], md5sum) + expected = (int(entry['size']), entry['md5sum']) + + if fingerprint != expected: + return False + + dest = os.path.join(target_dir, filename) + + os.symlink(path, dest) + symlinked.append(dest) + + return True + + session = DBConn().session() + found = False + + # Look in the pool + for poolfile in get_poolfile_like_name('/%s' % filename, session): + poolfile_path = os.path.join( + poolfile.location.path, poolfile.filename + ) + + if symlink_if_valid(poolfile_path): + found = True + break + + session.close() + + if found: + continue + + # Look in some other queues for the file + queues = ('Accepted', 'New', 'Byhand', 'ProposedUpdates', + 'OldProposedUpdates', 'Embargoed', 'Unembargoed') + + for queue in queues: + if 'Dir::Queue::%s' % directory not in cnf: + continue + + queuefile_path = os.path.join( + cnf['Dir::Queue::%s' % directory], filename + ) + + if not os.path.exists(queuefile_path): + # Does not exist in this queue + continue + + if symlink_if_valid(queuefile_path): + break + # Parse the yaml file sourcefile = file(tagfile, 'r') sourcecontent = sourcefile.read() @@ -1243,8 +1310,12 @@ class Upload(object): # to then parse it. command = "lintian --show-overrides --tags-from-file %s %s" % (temp_filename, self.pkg.changes_file) (result, output) = commands.getstatusoutput(command) - # We are done with lintian, remove our tempfile + + # We are done with lintian, remove our tempfile and any symlinks we created os.unlink(temp_filename) + for symlink in symlinked: + os.unlink(symlink) + if (result == 2): utils.warn("lintian failed for %s [return code: %s]." % (self.pkg.changes_file, result)) utils.warn(utils.prefix_multi_line_string(output, " [possible output:] ")) @@ -1254,9 +1325,7 @@ class Upload(object): def log(*txt): if self.logger: - args = [self.pkg.changes_file, "check_lintian"] - args.extend(txt) - self.logger.log(args) + self.logger.log([self.pkg.changes_file, "check_lintian"] + list(txt)) # We have output of lintian, this package isn't clean. Lets parse it and see if we # are having a victim for a reject.