X-Git-Url: https://git.decadent.org.uk/gitweb/?a=blobdiff_plain;f=daklib%2Fqueue.py;h=6accba0696faa3b84134e95df6e293764fe81302;hb=7aad4c6ec0c430b8f885f8237a0b33274c641258;hp=a13c0416d4a5f278437d6fd9abb9e66b4464ea03;hpb=4c7eee9642e82b6286f807ad92a93e7ef30288e6;p=dak.git diff --git a/daklib/queue.py b/daklib/queue.py index a13c0416..6accba06 100755 --- a/daklib/queue.py +++ b/daklib/queue.py @@ -6,7 +6,7 @@ Queue utility functions for dak @contact: Debian FTP Master @copyright: 2001 - 2006 James Troup -@copyright: 2009 Joerg Jaspert +@copyright: 2009, 2010 Joerg Jaspert @license: GNU General Public License version 2 or later """ @@ -231,17 +231,6 @@ def check_valid(new): ############################################################################### -def check_status(files): - new = byhand = 0 - for f in files.keys(): - if files[f].has_key("byhand"): - byhand = 1 - elif files[f].has_key("new"): - new = 1 - return (new, byhand) - -############################################################################### - # Used by Upload.check_timestamps class TarTime(object): def __init__(self, future_cutoff, past_cutoff): @@ -361,8 +350,14 @@ class Upload(object): ########################################################################### def load_changes(self, filename): """ + Load a changes file and setup a dictionary around it. Also checks for mandantory + fields within. + + @type filename: string + @param filename: Changes filename, full path. + @rtype: boolean - @rvalue: whether the changes file was valid or not. We may want to + @return: whether the changes file was valid or not. We may want to reject even if this is True (see what gets put in self.rejects). This is simply to prevent us even trying things later which will fail because we couldn't properly parse the file. @@ -459,7 +454,7 @@ class Upload(object): # Check the .changes is non-empty if not self.pkg.files: - self.rejects.append("%s: nothing to do (Files field is empty)." % (base_filename)) + self.rejects.append("%s: nothing to do (Files field is empty)." % (os.path.basename(self.pkg.changes_file))) return False # Changes was syntactically valid even if we'll reject @@ -934,7 +929,7 @@ class Upload(object): # Parse the .dsc file try: - self.pkg.dsc.update(utils.parse_changes(dsc_filename, signing_rules=1)) + self.pkg.dsc.update(utils.parse_changes(dsc_filename, signing_rules=1, dsc_file=1)) except CantOpenError: # if not -n copy_to_holding() will have done this for us... if not action: @@ -1096,9 +1091,7 @@ class Upload(object): def check_source(self): # Bail out if: # a) there's no source - # or c) the orig files are MIA - if not self.pkg.changes["architecture"].has_key("source") \ - or len(self.pkg.orig_files) == 0: + if not self.pkg.changes["architecture"].has_key("source"): return tmpdir = utils.temp_dirname() @@ -1232,7 +1225,7 @@ class Upload(object): found = False # Look in the pool - for poolfile in get_poolfile_like_name('/%s' % filename, session_): + for poolfile in get_poolfile_like_name('%s' % filename, session_): poolfile_path = os.path.join( poolfile.location.path, poolfile.filename ) @@ -1906,6 +1899,9 @@ distribution.""" # Make sure that our source object is up-to-date session.expire(source) + # Add changelog information to the database + self.store_changelog() + # Install the files into the pool for newfile, entry in self.pkg.files.items(): destination = os.path.join(cnf["Dir::Pool"], entry["pool name"], newfile) @@ -1944,14 +1940,7 @@ distribution.""" ## Helper stuff for DebBugs Version Tracking if cnf.Find("Dir::Queue::BTSVersionTrack"): - # ??? once queue/* is cleared on *.d.o and/or reprocessed - # the conditionalization on dsc["bts changelog"] should be - # dropped. - - # Write out the version history from the changelog - if self.pkg.changes["architecture"].has_key("source") and \ - self.pkg.dsc.has_key("bts changelog"): - + if self.pkg.changes["architecture"].has_key("source"): (fd, temp_filename) = utils.temp_filename(cnf["Dir::Queue::BTSVersionTrack"], prefix=".") version_history = os.fdopen(fd, 'w') version_history.write(self.pkg.dsc["bts changelog"]) @@ -2061,8 +2050,8 @@ distribution.""" directory it will be moved to the morgue to make way for the new file. - @type files: dict - @param files: file dictionary + @type reject_files: dict + @param reject_files: file dictionary """ @@ -2078,17 +2067,17 @@ distribution.""" try: dest_fd = os.open(dest_file, os.O_RDWR | os.O_CREAT | os.O_EXCL, 0644) except OSError, e: - # File exists? Let's try and move it to the morgue + # File exists? Let's find a new name by adding a number if e.errno == errno.EEXIST: - morgue_file = os.path.join(cnf["Dir::Morgue"], cnf["Dir::MorgueReject"], file_entry) try: - morgue_file = utils.find_next_free(morgue_file) + dest_file = utils.find_next_free(dest_file, 255) except NoFreeFilenameError: # Something's either gone badly Pete Tong, or # someone is trying to exploit us. - utils.warn("**WARNING** failed to move %s from the reject directory to the morgue." % (file_entry)) + utils.warn("**WARNING** failed to find a free filename for %s in %s." % (file_entry, cnf["Dir::Queue::Reject"])) return - utils.move(dest_file, morgue_file, perms=0660) + + # Make sure we really got it try: dest_fd = os.open(dest_file, os.O_RDWR|os.O_CREAT|os.O_EXCL, 0644) except OSError, e: @@ -2686,3 +2675,26 @@ distribution.""" os.chdir(cwd) return too_new + + def store_changelog(self): + + # Skip binary-only upload if it is not a bin-NMU + if not self.pkg.changes['architecture'].has_key('source'): + from daklib.regexes import re_bin_only_nmu + if not re_bin_only_nmu.search(self.pkg.changes['version']): + return + + session = DBConn().session() + + # Add current changelog text into changelogs_text table, return created ID + query = "INSERT INTO changelogs_text (changelog) VALUES (:changelog) RETURNING id" + ID = session.execute(query, {'changelog': self.pkg.changes['changes']}).fetchone()[0] + + # Link ID to the upload available in changes table + query = """UPDATE changes SET changelog_id = :id WHERE source = :source + AND version = :version AND architecture = :architecture""" + session.execute(query, {'id': ID, 'source': self.pkg.changes['source'], \ + 'version': self.pkg.changes['version'], \ + 'architecture': " ".join(self.pkg.changes['architecture'].keys())}) + + session.commit()