X-Git-Url: https://git.decadent.org.uk/gitweb/?a=blobdiff_plain;f=dak%2Ftransitions.py;h=d9da5c420b5906062d5853bf28b27245667c69ba;hb=ac862714876c84c71c909341354ea1ac9b36e6d8;hp=2c7d3d8333071b61f41448806f8fc4e007b60e9e;hpb=7c40371fd5e818e0bad7edfa92267d663adf4993;p=dak.git diff --git a/dak/transitions.py b/dak/transitions.py index 2c7d3d83..d9da5c42 100755 --- a/dak/transitions.py +++ b/dak/transitions.py @@ -29,7 +29,6 @@ Display, edit and check the release manager's transition file. ################################################################################ import os -import pg import sys import time import errno @@ -37,7 +36,8 @@ import fcntl import tempfile import pwd import apt_pkg -from daklib import database + +from daklib.dbconn import * from daklib import utils from daklib.dak_exceptions import TransitionsError from daklib.regexes import re_broken_package @@ -46,7 +46,6 @@ import yaml # Globals Cnf = None #: Configuration, apt_pkg.Configuration Options = None #: Parsed CommandLine arguments -projectB = None #: database connection, pgobject ################################################################################ @@ -60,7 +59,7 @@ def init(): @attention: This function may run B{within sudo} """ - global Cnf, Options, projectB + global Cnf, Options apt_pkg.init() @@ -85,15 +84,13 @@ def init(): if Options["help"]: usage() - whoami = os.getuid() - whoamifull = pwd.getpwuid(whoami) - username = whoamifull[0] + username = utils.getusername() if username != "dak": print "Non-dak user: %s" % username Options["sudo"] = "y" - projectB = pg.connect(Cnf["DB::Name"], Cnf["DB::Host"], int(Cnf["DB::Port"])) - database.init(Cnf, projectB) + # Initialise DB connection + DBConn() ################################################################################ @@ -399,22 +396,26 @@ def check_transitions(transitions): to_dump = 0 to_remove = [] info = {} + + session = DBConn().session() + # Now look through all defined transitions for trans in transitions: t = transitions[trans] source = t["source"] expected = t["new"] - # Will be None if nothing is in testing. - current = database.get_suite_version(source, "testing") + # Will be an empty list if nothing is in testing. + sources = get_source_in_suite(source, "testing", session) info[trans] = get_info(trans, source, expected, t["rm"], t["reason"], t["packages"]) print info[trans] - if current == None: + if len(sources) < 1: # No package in testing print "Transition source %s not in testing, transition still ongoing." % (source) else: + current = sources[0].version compare = apt_pkg.VersionCompare(current, expected) if compare < 0: # This is still valid, the current version in database is older than @@ -510,7 +511,7 @@ New Version: %s Responsible: %s Description: %s Blocked Packages (total: %d): %s -""" % (trans, source, expected, rm, reason, len(packages), ", ".join(packages)) +""" % (trans, source.source, expected, rm, reason, len(packages), ", ".join(packages)) ################################################################################ @@ -523,29 +524,32 @@ def transition_info(transitions): @type transitions: dict @param transitions: defined transitions """ + + session = DBConn().session() + for trans in transitions: t = transitions[trans] source = t["source"] expected = t["new"] # Will be None if nothing is in testing. - current = database.get_suite_version(source, "testing") + source = get_source_in_suite(source, "testing", session) print get_info(trans, source, expected, t["rm"], t["reason"], t["packages"]) - if current == None: + if source is None: # No package in testing print "Transition source %s not in testing, transition still ongoing." % (source) else: - compare = apt_pkg.VersionCompare(current, expected) + compare = apt_pkg.VersionCompare(source.version, expected) print "Apt compare says: %s" % (compare) if compare < 0: # This is still valid, the current version in database is older than # the new version we wait for - print "This transition is still ongoing, we currently have version %s" % (current) + print "This transition is still ongoing, we currently have version %s" % (source.version) else: print "This transition is over, the target package reached testing, should be removed" - print "%s wanted version: %s, has %s" % (source, expected, current) + print "%s wanted version: %s, has %s" % (source, expected, source.version) print "-------------------------------------------------------------------------" ################################################################################