X-Git-Url: https://git.decadent.org.uk/gitweb/?a=blobdiff_plain;f=dak%2Frm.py;h=6844738fda4c2a5509ecb3a2fe7acf9832e2638c;hb=1af0343f2bcab92549d41426be7acd4fe7361206;hp=df11a53b83340186873326b7aefb3d35e47d485f;hpb=05e649f2cfaa94ac361cb2df2e9a810adeb9c943;p=dak.git diff --git a/dak/rm.py b/dak/rm.py index df11a53b..6844738f 100755 --- a/dak/rm.py +++ b/dak/rm.py @@ -1,6 +1,6 @@ #!/usr/bin/env python -# General purpose package removal tool for ftpmaster +""" General purpose package removal tool for ftpmaster """ # Copyright (C) 2000, 2001, 2002, 2003, 2004, 2006 James Troup # This program is free software; you can redistribute it and/or modify @@ -39,16 +39,17 @@ ################################################################################ -import commands, os, pg, re, sys -import apt_pkg, apt_inst -import daklib.database as database -import daklib.utils as utils +import commands +import os +import pg +import re +import sys +import apt_pkg +import apt_inst +from daklib import database +from daklib import utils from daklib.dak_exceptions import * - -################################################################################ - -re_strip_source_version = re.compile (r'\s+.*$') -re_build_dep_arch = re.compile(r"\[[^]]+\]") +from daklib.regexes import re_strip_source_version, re_build_dep_arch ################################################################################ @@ -95,20 +96,25 @@ def game_over(): ################################################################################ -def reverse_depends_check(removals, suites): +def reverse_depends_check(removals, suites, arches=None): print "Checking reverse dependencies..." components = Cnf.ValueList("Suite::%s::Components" % suites[0]) dep_problem = 0 p2c = {} - for architecture in Cnf.ValueList("Suite::%s::Architectures" % suites[0]): - if architecture in ["source", "all"]: - continue + all_broken = {} + if arches: + all_arches = set(arches) + else: + all_arches = set(database.get_suite_architectures(suites[0])) + all_arches -= set(["source", "all"]) + for architecture in all_arches: deps = {} + sources = {} virtual_packages = {} for component in components: filename = "%s/dists/%s/%s/binary-%s/Packages.gz" % (Cnf["Dir::Root"], suites[0], component, architecture) # apt_pkg.ParseTagFile needs a real file handle and can't handle a GzipFile instance... - temp_filename = utils.temp_filename() + (fd, temp_filename) = utils.temp_filename() (result, output) = commands.getstatusoutput("gunzip -c %s > %s" % (filename, temp_filename)) if (result != 0): utils.fubar("Gunzip invocation failed!\n%s\n" % (output), result) @@ -116,6 +122,12 @@ def reverse_depends_check(removals, suites): Packages = apt_pkg.ParseTagFile(packages) while Packages.Step(): package = Packages.Section.Find("Package") + source = Packages.Section.Find("Source") + if not source: + source = package + elif ' ' in source: + source = source.split(' ', 1)[0] + sources[package] = source depends = Packages.Section.Find("Depends") if depends: deps[package] = depends @@ -162,18 +174,32 @@ def reverse_depends_check(removals, suites): unsat += 1 if unsat == len(dep): component = p2c[package] + source = sources[package] if component != "main": - what = "%s/%s" % (package, component) - else: - what = "** %s" % (package) - print "%s has an unsatisfied dependency on %s: %s" % (what, architecture, utils.pp_deps(dep)) + source = "%s/%s" % (source, component) + all_broken.setdefault(source, {}).setdefault(package, set()).add(architecture) dep_problem = 1 + if all_broken: + print "# Broken Depends:" + for source, bindict in sorted(all_broken.items()): + lines = [] + for binary, arches in sorted(bindict.items()): + if arches == all_arches: + lines.append(binary) + else: + lines.append('%s [%s]' % (binary, ' '.join(sorted(arches)))) + print '%s: %s' % (source, lines[0]) + for line in lines[1:]: + print ' ' * (len(source) + 2) + line + print + # Check source dependencies (Build-Depends and Build-Depends-Indep) + all_broken.clear() for component in components: filename = "%s/dists/%s/%s/source/Sources.gz" % (Cnf["Dir::Root"], suites[0], component) # apt_pkg.ParseTagFile needs a real file handle and can't handle a GzipFile instance... - temp_filename = utils.temp_filename() + (fd, temp_filename) = utils.temp_filename() result, output = commands.getstatusoutput("gunzip -c %s > %s" % (filename, temp_filename)) if result != 0: sys.stderr.write("Gunzip invocation failed!\n%s\n" % (output)) @@ -201,13 +227,20 @@ def reverse_depends_check(removals, suites): if unsat == len(dep): if component != "main": source = "%s/%s" % (source, component) - else: - source = "** %s" % (source) - print "%s has an unsatisfied build-dependency: %s" % (source, utils.pp_deps(dep)) + all_broken.setdefault(source, set()).add(utils.pp_deps(dep)) dep_problem = 1 sources.close() os.unlink(temp_filename) + if all_broken: + print "# Broken Build-Depends:" + for source, bdeps in sorted(all_broken.items()): + bdeps = sorted(bdeps) + print '%s: %s' % (source, bdeps[0]) + for bdep in bdeps[1:]: + print ' ' * (len(source) + 2) + bdep + print + if dep_problem: print "Dependency problem found." if not Options["No-Action"]: @@ -258,7 +291,7 @@ def main (): if not arguments: utils.fubar("need at least one package name as an argument.") if Options["Architecture"] and Options["Source-Only"]: - utils.fubar("can't use -a/--architecutre and -S/--source-only options simultaneously.") + utils.fubar("can't use -a/--architecture and -S/--source-only options simultaneously.") if Options["Binary-Only"] and Options["Source-Only"]: utils.fubar("can't use -b/--binary-only and -S/--source-only options simultaneously.") if Options.has_key("Carbon-Copy") and not Options.has_key("Done"): @@ -393,7 +426,7 @@ def main (): # If we don't have a reason; spawn an editor so the user can add one # Write the rejection email out as the .reason file if not Options["Reason"] and not Options["No-Action"]: - temp_filename = utils.temp_filename() + (fd, temp_filename) = utils.temp_filename() editor = os.environ.get("EDITOR","vi") result = os.system("%s %s" % (editor, temp_filename)) if result != 0: @@ -446,7 +479,8 @@ def main (): print if Options["Rdep-Check"]: - reverse_depends_check(removals, suites) + arches = utils.split_args(Options["Architecture"]) + reverse_depends_check(removals, suites, arches) # If -n/--no-action, drop out here if Options["No-Action"]: @@ -511,7 +545,7 @@ def main (): Subst["__BCC__"] = "Bcc: " + ", ".join(bcc) else: Subst["__BCC__"] = "X-Filler: 42" - Subst["__CC__"] = "X-DAK: dak rm\nX-Katie: melanie $Revision: 1.44 $" + Subst["__CC__"] = "X-DAK: dak rm\nX-Katie: melanie" if carbon_copy: Subst["__CC__"] += "\nCc: " + ", ".join(carbon_copy) Subst["__SUITE_LIST__"] = suites_list