@@ -216,10 +237,12 @@ def footer(): """ def table_header(type, source_count, total_count): - print "

Summary for: %s

" % (type) + print "

Summary for: %s

" % (type) + print "" % (type) print """ -

" -def table_row(source, version, arch, last_mod, maint, distribution, closes, fingerprint, sponsor, changedby): +def find_bug_severities(bugnrs): + """Take a list of bug numbers and + return a dictionary with bug number - severity pairs.""" + statuses = None + try: statuses = debianbts.get_status(bugnrs) + except Exception: + return None + severities = {} + for bug_status in statuses: + severities[bug_status.bug_num] = bug_status.severity + return severities + +def rcbug_close_check(closes): + """Take a list of bug numbers and determine if at least one of them + is release critical.""" + severity_list = find_bug_severities(closes) + if severity_list: + severities = severity_list.values() + return ('critical' in severities) or \ + ('serious' in severities) or \ + ('grave' in severities) + return False + +def table_row(source, version, arch, last_mod, maint, distribution, closes, fingerprint, sponsor, changedby, fixes_rcbug): global row_number trclass = "sid" + session = DBConn().session() for dist in distribution: if dist == "experimental": trclass = "exp" + if fixes_rcbug: + trclass = "rcfix" + + if not len(session.query(DBSource).filter_by(source = source).all()): + trclass += " binNEW" + session.commit() + if row_number % 2 != 0: print "" % (trclass) else: @@ -259,7 +313,7 @@ def table_row(source, version, arch, last_mod, maint, distribution, closes, fing print "%s" % (source) print "" for vers in version.split(): - print "%s
" % (source, utils.html_escape(vers), utils.html_escape(vers)) + print "%s
" % (source, utils.html_escape(vers), utils.html_escape(vers)) print "" print "%s" % (arch) print "" @@ -267,18 +321,19 @@ def table_row(source, version, arch, last_mod, maint, distribution, closes, fing print "%s
" % (dist) print "" print "%s" % (last_mod) - (name, mail) = maint.split(":") + (name, mail) = maint.split(":", 1) print "" print "Maintainer: %s
" % (utils.html_escape(mail), utils.html_escape(name)) - (name, mail) = changedby.split(":") + (name, mail) = changedby.split(":", 1) print "Changed-By: %s
" % (utils.html_escape(mail), utils.html_escape(name)) - try: - (login, domain) = sponsor.split("@") - print "@debian.org
" % (utils.html_escape(login), utils.html_escape(login)) - except: - pass + if sponsor: + try: + (login, domain) = sponsor.split("@", 1) + print "@debian.org
" % (utils.html_escape(login), utils.html_escape(login)) + except Exception, e: + pass print "Fingerprint: %s" % (fingerprint) print "" @@ -292,18 +347,19 @@ def table_row(source, version, arch, last_mod, maint, distribution, closes, fing ############################################################ def process_changes_files(changes_files, type, log): + session = DBConn().session() msg = "" cache = {} # Read in all the .changes files for filename in changes_files: try: - Upload.pkg.changes_file = filename - Upload.init_vars() - Upload.update_vars() - cache[filename] = copy.copy(Upload.pkg.changes) + u = Upload() + u.load_changes(filename) + cache[filename] = copy(u.pkg.changes) cache[filename]["filename"] = filename - except: - break + except Exception, e: + print "WARNING: Exception %s" % e + continue # Divide the .changes into per-source groups per_source = {} for filename in cache.keys(): @@ -326,7 +382,7 @@ def process_changes_files(changes_files, type, log): else: if mtime < oldest: oldest = mtime - have_note += (d.has_key("process-new note")) + have_note += has_new_comment(d["source"], d["version"]) per_source[source]["oldest"] = oldest if not have_note: per_source[source]["note_state"] = 0; # none @@ -350,18 +406,28 @@ def process_changes_files(changes_files, type, log): changeby = {} changedby="" sponsor="" + filename=i[1]["list"][0]["filename"] last_modified = time.time()-i[1]["oldest"] source = i[1]["list"][0]["source"] if len(source) > max_source_len: max_source_len = len(source) + binary_list = i[1]["list"][0]["binary"].keys() + binary = ', '.join(binary_list) arches = {} versions = {} for j in i[1]["list"]: + changesbase = os.path.basename(j["filename"]) + try: + dbc = session.query(DBChange).filter_by(changesname=changesbase).one() + except Exception, e: + print "Can't find changes file in NEW for %s (%s)" % (changesbase, e) + dbc = None + if Cnf.has_key("Queue-Report::Options::New") or Cnf.has_key("Queue-Report::Options::822"): try: (maintainer["maintainer822"], maintainer["maintainer2047"], maintainer["maintainername"], maintainer["maintaineremail"]) = \ - utils.fix_maintainer (j["maintainer"]) + fix_maintainer (j["maintainer"]) except ParseMaintError, msg: print "Problems while parsing maintainer address\n" maintainer["maintainername"] = "Unknown" @@ -371,7 +437,7 @@ def process_changes_files(changes_files, type, log): try: (changeby["changedby822"], changeby["changedby2047"], changeby["changedbyname"], changeby["changedbyemail"]) = \ - utils.fix_maintainer (j["changed-by"]) + fix_maintainer (j["changed-by"]) except ParseMaintError, msg: (changeby["changedby822"], changeby["changedby2047"], changeby["changedbyname"], changeby["changedbyemail"]) = \ @@ -380,9 +446,14 @@ def process_changes_files(changes_files, type, log): distribution=j["distribution"].keys() closes=j["closes"].keys() - fingerprint=j["fingerprint"] - if j.has_key("sponsoremail"): - sponsor=j["sponsoremail"] + if dbc: + fingerprint = dbc.fingerprint + sponsor_name = get_uid_from_fingerprint(fingerprint).name + sponsor_email = get_uid_from_fingerprint(fingerprint).uid + "@debian.org" + if sponsor_name != maintainer["maintainername"] and sponsor_name != changeby["changedbyname"] and \ + sponsor_email != maintainer["maintaineremail"] and sponsor_name != changeby["changedbyemail"]: + sponsor = sponsor_email + for arch in j["architecture"].keys(): arches[arch] = "" version = j["version"] @@ -399,7 +470,8 @@ def process_changes_files(changes_files, type, log): note = " | [N]" else: note = "" - entries.append([source, version_list, arch_list, note, last_modified, maint, distribution, closes, fingerprint, sponsor, changedby]) + fixes_rcbug = rcbug_close_check(closes) + entries.append([source, binary, version_list, arch_list, note, last_modified, maint, distribution, closes, fingerprint, sponsor, changedby, filename, fixes_rcbug]) # direction entry consists of "Which field, which direction, time-consider" where # time-consider says how we should treat last_modified. Thats all. @@ -410,16 +482,16 @@ def process_changes_files(changes_files, type, log): age = Cnf["Queue-Report::Options::Age"] if Cnf.has_key("Queue-Report::Options::New"): # If we produce html we always have oldest first. - direction.append([4,-1,"ao"]) + direction.append([5,-1,"ao"]) else: if Cnf.has_key("Queue-Report::Options::Sort"): for i in Cnf["Queue-Report::Options::Sort"].split(","): if i == "ao": # Age, oldest first. - direction.append([4,-1,age]) + direction.append([5,-1,age]) elif i == "an": # Age, newest first. - direction.append([4,1,age]) + direction.append([5,1,age]) elif i == "na": # Name, Ascending. direction.append([0,1,0]) @@ -428,10 +500,10 @@ def process_changes_files(changes_files, type, log): direction.append([0,-1,0]) elif i == "nl": # Notes last. - direction.append([3,1,0]) + direction.append([4,1,0]) elif i == "nf": # Notes first. - direction.append([3,-1,0]) + direction.append([4,-1,0]) entries.sort(lambda x, y: sortfunc(x, y)) # Yes, in theory you can add several sort options at the commandline with. But my mind is to small # at the moment to come up with a real good sorting function that considers all the sidesteps you @@ -441,11 +513,12 @@ def process_changes_files(changes_files, type, log): if Cnf.has_key("Queue-Report::Options::822"): # print stuff out in 822 format for entry in entries: - (source, version_list, arch_list, note, last_modified, maint, distribution, closes, fingerprint, sponsor, changedby) = entry + (source, binary, version_list, arch_list, note, last_modified, maint, distribution, closes, fingerprint, sponsor, changedby, changes_file, fixes_rcbug) = entry # We'll always have Source, Version, Arch, Mantainer, and Dist # For the rest, check to see if we have them, then print them out log.write("Source: " + source + "\n") + log.write("Binary: " + binary + "\n") log.write("Version: " + version_list + "\n") log.write("Architectures: ") log.write( (", ".join(arch_list.split(" "))) + "\n") @@ -453,10 +526,10 @@ def process_changes_files(changes_files, type, log): log.write("Last-Modified: " + str(int(time.time()) - int(last_modified)) + "\n") log.write("Queue: " + type + "\n") - (name, mail) = maint.split(":") + (name, mail) = maint.split(":", 1) log.write("Maintainer: " + name + " <"+mail+">" + "\n") if changedby: - (name, mail) = changedby.split(":") + (name, mail) = changedby.split(":", 1) log.write("Changed-By: " + name + " <"+mail+">" + "\n") if sponsor: log.write("Sponsored-By: " + sponsor + "\n") @@ -470,10 +543,11 @@ def process_changes_files(changes_files, type, log): for bugs in closes: bug_string += "#"+bugs+", " log.write("Closes: " + bug_string[:-2] + "\n") + log.write("Changes-File: " + os.path.basename(changes_file) + "\n") log.write("\n") if Cnf.has_key("Queue-Report::Options::New"): - direction.append([4,1,"ao"]) + direction.append([5,1,"ao"]) entries.sort(lambda x, y: sortfunc(x, y)) # Output for a html file. First table header. then table_footer. # Any line between them is then a printed from subroutine table_row. @@ -482,8 +556,8 @@ def process_changes_files(changes_files, type, log): source_count = len(per_source_items) table_header(type.upper(), source_count, total_count) for entry in entries: - (source, version_list, arch_list, note, last_modified, maint, distribution, closes, fingerprint, sponsor, changedby) = entry - table_row(source, version_list, arch_list, time_pp(last_modified), maint, distribution, closes, fingerprint, sponsor, changedby) + (source, binary, version_list, arch_list, note, last_modified, maint, distribution, closes, fingerprint, sponsor, changedby, undef, fixes_rcbug) = entry + table_row(source, version_list, arch_list, time_pp(last_modified), maint, distribution, closes, fingerprint, sponsor, changedby, entries, fixes_rcbug) table_footer(type.upper()) elif not Cnf.has_key("Queue-Report::Options::822"): # The "normal" output without any formatting. @@ -491,7 +565,7 @@ def process_changes_files(changes_files, type, log): msg = "" for entry in entries: - (source, version_list, arch_list, note, last_modified, undef, undef, undef, undef, undef, undef) = entry + (source, binary, version_list, arch_list, note, last_modified, undef, undef, undef, undef, undef, undef, undef, fixes_rcbug) = entry msg += format % (source, version_list, arch_list, note, time_pp(last_modified)) if msg: @@ -508,14 +582,15 @@ def process_changes_files(changes_files, type, log): ################################################################################ def main(): - global Cnf, Upload + global Cnf Cnf = utils.get_conf() Arguments = [('h',"help","Queue-Report::Options::Help"), ('n',"new","Queue-Report::Options::New"), ('8','822',"Queue-Report::Options::822"), ('s',"sort","Queue-Report::Options::Sort", "HasArg"), - ('a',"age","Queue-Report::Options::Age", "HasArg")] + ('a',"age","Queue-Report::Options::Age", "HasArg"), + ('d',"directories","Queue-Report::Options::Directories", "HasArg")] for i in [ "help" ]: if not Cnf.has_key("Queue-Report::Options::%s" % (i)): Cnf["Queue-Report::Options::%s" % (i)] = "" @@ -526,13 +601,20 @@ def main(): if Options["Help"]: usage() - Upload = queue.Upload(Cnf) - if Cnf.has_key("Queue-Report::Options::New"): header() - directories = Cnf.ValueList("Queue-Report::Directories") - if not directories: + # Initialize db so we can get the NEW comments + dbconn = DBConn() + + directories = [ ] + + if Cnf.has_key("Queue-Report::Options::Directories"): + for i in Cnf["Queue-Report::Options::Directories"].split(","): + directories.append(i) + elif Cnf.has_key("Queue-Report::Directories"): + directories = Cnf.ValueList("Queue-Report::Directories") + else: directories = [ "byhand", "new" ] f = None

Summary for: %s

Summary for: %s

Summary for: binary-%s only