X-Git-Url: https://git.decadent.org.uk/gitweb/?a=blobdiff_plain;f=dak%2Fprocess_upload.py;h=84186c57186a792a7a3e66bd59fd3d864474f05f;hb=af72c901d49515105812b8ef46ce98b55d4072ba;hp=13474071c34600cb82d3eae1d7a1e37df857ef21;hpb=9c66ac39be80ceb4fdcc58823852df090c10a029;p=dak.git diff --git a/dak/process_upload.py b/dak/process_upload.py index 13474071..84186c57 100755 --- a/dak/process_upload.py +++ b/dak/process_upload.py @@ -207,6 +207,8 @@ def byebye(): def action(u, session): + global Logger + cnf = Config() holding = Holding() @@ -293,7 +295,7 @@ def action(u, session): u.do_reject(0, pi) elif answer == 'A': if not chg: - chg = u.pkg.add_known_changes(holding.holding_dir, session=session) + chg = u.pkg.add_known_changes(holding.holding_dir, session=session, logger=Logger) session.commit() u.accept(summary, short_summary, session) u.check_override() @@ -302,13 +304,13 @@ def action(u, session): u.remove() elif answer == 'P': if not chg: - chg = u.pkg.add_known_changes(holding.holding_dir, session=session) + chg = u.pkg.add_known_changes(holding.holding_dir, session=session, logger=Logger) package_to_queue(u, summary, short_summary, policyqueue, chg, session) session.commit() u.remove() elif answer == queuekey: if not chg: - chg = u.pkg.add_known_changes(holding.holding_dir, session=session) + chg = u.pkg.add_known_changes(holding.holding_dir, session=session, logger=Logger) QueueInfo[qu]["process"](u, summary, short_summary, chg, session) session.commit() u.remove() @@ -422,7 +424,6 @@ def main(): cnf = Config() summarystats = SummaryStats() - log_urgency = False DBConn() @@ -454,7 +455,7 @@ def main(): # Obtain lock if not in no-action mode and initialize the log if not Options["No-Action"]: - lock_fd = os.open(cnf["Dinstall::LockFile"], os.O_RDWR | os.O_CREAT) + lock_fd = os.open(os.path.join(cnf["Dir::Lock"], 'dinstall.lock'), os.O_RDWR | os.O_CREAT) try: fcntl.lockf(lock_fd, fcntl.LOCK_EX | fcntl.LOCK_NB) except IOError, e: @@ -462,12 +463,12 @@ def main(): utils.fubar("Couldn't obtain lock; assuming another 'dak process-upload' is already running.") else: raise - if cnf.get("Dir::UrgencyLog"): - # Initialise UrgencyLog() - log_urgency = True - UrgencyLog() - Logger = daklog.Logger(cnf, "process-upload", Options["No-Action"]) + # Initialise UrgencyLog() - it will deal with the case where we don't + # want to log urgencies + urgencylog = UrgencyLog() + + Logger = daklog.Logger("process-upload", Options["No-Action"]) # If we have a directory flag, use it to find our files if cnf["Dinstall::Options::Directory"] != "": @@ -501,11 +502,17 @@ def main(): utils.size_type(int(summarystats.accept_bytes))) Logger.log(["total", summarystats.accept_count, summarystats.accept_bytes]) + if summarystats.reject_count: + sets = "set" + if summarystats.reject_count > 1: + sets = "sets" + print "Rejected %d package %s." % (summarystats.reject_count, sets) + Logger.log(["rejected", summarystats.reject_count]) + byebye() if not Options["No-Action"]: - if log_urgency: - UrgencyLog().close() + urgencylog.close() Logger.close()