X-Git-Url: https://git.decadent.org.uk/gitweb/?a=blobdiff_plain;f=dak%2Fprocess_upload.py;h=727e2e802ea27f5ddfed10157c3a542619699dd6;hb=691ed711258ec04185e9ba8994e9c301564eb847;hp=74229e2f482b46d5f58ee351886766c6699bd4ca;hpb=cec8f2c1492f4ba27babfcc16bf2ecc5fbf9d9ec;p=dak.git

diff --git a/dak/process_upload.py b/dak/process_upload.py
index 74229e2f..727e2e80 100755
--- a/dak/process_upload.py
+++ b/dak/process_upload.py
@@ -265,10 +265,7 @@ def subst_for_upload(upload):
 
         '__BUG_SERVER__': cnf.get('Dinstall::BugServer'),
 
-        # TODO: don't use private member
-        '__FILE_CONTENTS__': upload.changes._signed_file.contents,
-
-        # __REJECT_MESSAGE__
+        '__FILE_CONTENTS__': open(upload.changes.path, 'r').read(),
         }
 
     override_maintainer = cnf.get('Dinstall::OverrideMaintainer')
@@ -302,24 +299,23 @@ def accept(directory, upload):
     utils.send_mail(message)
 
     # send mail to announce lists and tracking server
-    subst = subst_for_upload(upload)
-    announce = set()
-    for suite in upload.final_suites:
-        if suite.policy_queue is not None:
-            continue
-        announce.update(suite.announce or [])
-    announce_address = ", ".join(announce)
-
-    tracking = cnf.get('Dinstall::TrackingServer')
-    if tracking and 'source' in upload.changes.architectures:
-        announce_address = '{0}\nBcc: {1}@{2}'.format(announce_address, control['Source'], tracking)
+    if  accepted_to_real_suite:
+        subst = subst_for_upload(upload)
+        announce = set()
+        for suite in upload.final_suites:
+            if suite.policy_queue is not None:
+                continue
+            announce.update(suite.announce or [])
+        announce_address = ", ".join(announce)
 
-    subst['__ANNOUNCE_LIST_ADDRESS__'] = announce_address
+        tracking = cnf.get('Dinstall::TrackingServer')
+        if tracking and 'source' in upload.changes.architectures:
+            announce_address = '{0}\nBcc: {1}@{2}'.format(announce_address, control['Source'], tracking)
 
-    message = utils.TemplateSubst(subst, os.path.join(cnf['Dir::Templates'], 'process-unchecked.announce'))
-    utils.send_mail(message)
+        subst['__ANNOUNCE_LIST_ADDRESS__'] = announce_address
 
-    del subst['__ANNOUNCE_LIST_ADDRESS__']
+        message = utils.TemplateSubst(subst, os.path.join(cnf['Dir::Templates'], 'process-unchecked.announce'))
+        utils.send_mail(message)
 
     # Only close bugs for uploads that were not redirected to a policy queue.
     # process-policy will close bugs for those once they are accepted.