X-Git-Url: https://git.decadent.org.uk/gitweb/?a=blobdiff_plain;f=dak%2Fprocess_new.py;h=1c2231a305709baf6ff7379fd55fbbe9868ce1d0;hb=dd80b169287a128cd9e3b833852fbf68106385b5;hp=11e9bf48efc9b5e968f2661ebcf4e2272e90df44;hpb=c5e62511336d16a4b1648b9b84b6b6d80e560c21;p=dak.git diff --git a/dak/process_new.py b/dak/process_new.py index 11e9bf48..1c2231a3 100755 --- a/dak/process_new.py +++ b/dak/process_new.py @@ -42,8 +42,6 @@ ################################################################################ -from __future__ import with_statement - import copy import errno import os @@ -351,7 +349,7 @@ def check_pkg (upload): elif ftype == "dsc": print examine_package.check_dsc(changes['distribution'], f) print examine_package.output_package_relations() - except IOError, e: + except IOError as e: if e.errno == errno.EPIPE: utils.warn("[examine_package] Caught EPIPE; skipping.") else: @@ -392,7 +390,7 @@ def add_overrides (new, upload, session): type_id = get_override_type(new[pkg]["type"]).overridetype_id priority_id = new[pkg]["priority id"] section_id = new[pkg]["section id"] - Logger.log(["%s overrides" % (srcpkg), suite, new[pkg]["component"], new[pkg]["type"], new[pkg]["priority"], new[pkg]["section"]]) + Logger.log(["%s (%s) overrides" % (pkg, srcpkg), suite, new[pkg]["component"], new[pkg]["type"], new[pkg]["priority"], new[pkg]["section"]]) session.execute("INSERT INTO override (suite, component, type, package, priority, section, maintainer) VALUES (:sid, :cid, :tid, :pkg, :pid, :sectid, '')", { 'sid': suite_id, 'cid': component_id, 'tid':type_id, 'pkg': pkg, 'pid': priority_id, 'sectid': section_id}) for f in new[pkg]["files"]: @@ -611,13 +609,16 @@ def check_daily_lock(): cnf = Config() try: - os.open(cnf["Process-New::DinstallLockFile"], + lockfile = cnf.get("Process-New::DinstallLockFile", + os.path.join(cnf['Dir::Lock'], 'processnew.lock')) + + os.open(lockfile, os.O_RDONLY | os.O_CREAT | os.O_EXCL) - except OSError, e: + except OSError as e: if e.errno == errno.EEXIST or e.errno == errno.EACCES: raise CantGetLockError - os.unlink(cnf["Process-New::DinstallLockFile"]) + os.unlink(lockfile) @contextlib.contextmanager @@ -629,13 +630,16 @@ def lock_package(package): @param package: source package name to lock """ - path = os.path.join(Config()["Process-New::LockDir"], package) + cnf = Config() + + path = os.path.join(cnf.get("Process-New::LockDir", cnf['Dir::Lock']), package) + try: fd = os.open(path, os.O_CREAT | os.O_EXCL | os.O_RDONLY) - except OSError, e: + except OSError as e: if e.errno == errno.EEXIST or e.errno == errno.EACCES: user = pwd.getpwuid(os.stat(path)[stat.ST_UID])[4].split(',')[0].replace('.', '') - raise AlreadyLockedError, user + raise AlreadyLockedError(user) try: yield fd @@ -714,7 +718,7 @@ def do_pkg(changes_full_path, session): print "Hello? Operator! Give me the number for 911!" print "Dinstall in the locked area, cant process packages, come back later" - except AlreadyLockedError, e: + except AlreadyLockedError as e: print "Seems to be locked by %s already, skipping..." % (e) def show_new_comments(changes_files, session): @@ -784,8 +788,8 @@ def main(): if not Options["No-Action"]: try: - Logger = daklog.Logger(cnf, "process-new") - except CantOpenError, e: + Logger = daklog.Logger("process-new") + except CantOpenError as e: Options["Trainee"] = "True" Sections = Section_Completer(session)