X-Git-Url: https://git.decadent.org.uk/gitweb/?a=blobdiff_plain;f=dak%2Fexamine_package.py;h=fd06f519e8e9b4c0b24fc46bae28d6fd1853780f;hb=b612f3da207fa0d75a5d3b204ac8f02bb244231a;hp=2a1a711e04ed4dd50f98855bf18770376d095553;hpb=af486e867c2809515c09ae4f854a95355112010e;p=dak.git diff --git a/dak/examine_package.py b/dak/examine_package.py index 2a1a711e..fd06f519 100755 --- a/dak/examine_package.py +++ b/dak/examine_package.py @@ -1,7 +1,13 @@ #!/usr/bin/env python -# Script to automate some parts of checking NEW packages -# Copyright (C) 2000, 2001, 2002, 2003, 2006 James Troup +""" +Script to automate some parts of checking NEW packages + +@contact: Debian FTP Master +@copyright: 2000, 2001, 2002, 2003, 2006 James Troup +@copyright: 2009 Joerg Jaspert +@license: GNU General Public License version 2 or later +""" # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by @@ -32,28 +38,21 @@ ################################################################################ -import errno, os, pg, re, sys, md5 -import apt_pkg, apt_inst +import errno +import os +import pg +import re +import sys +import md5 +import apt_pkg +import apt_inst +import shutil +import commands from daklib import database from daklib import utils - -################################################################################ - -re_package = re.compile(r"^(.+?)_.*") -re_doc_directory = re.compile(r".*/doc/([^/]*).*") - -re_contrib = re.compile('^contrib/') -re_nonfree = re.compile('^non\-free/') - -re_arch = re.compile("Architecture: .*") -re_builddep = re.compile("Build-Depends: .*") -re_builddepind = re.compile("Build-Depends-Indep: .*") - -re_localhost = re.compile("localhost\.localdomain") -re_version = re.compile('^(.*)\((.*)\)') - -re_newlinespace = re.compile('\n') -re_spacestrip = re.compile('(\s)') +from daklib.regexes import html_escaping, re_html_escaping, re_version, re_spacestrip, \ + re_contrib, re_nonfree, re_localhost, re_newlinespace, \ + re_package, re_doc_directory ################################################################################ @@ -65,6 +64,7 @@ projectB = pg.connect(Cnf["DB::Name"], Cnf["DB::Host"], int(Cnf["DB::Port"])) database.init(Cnf, projectB) printed_copyrights = {} +package_relations = {} #: Store relations of packages for later output # default is to not output html. use_html = 0 @@ -88,7 +88,7 @@ PACKAGE can be a .changes, .dsc, .deb or .udeb filename.""" def escape_if_needed(s): if use_html: - return utils.re_html_escaping.sub(lambda x: utils.html_escaping.get(x.group(0)), s) + return re_html_escaping.sub(lambda x: html_escaping.get(x.group(0)), s) else: return s @@ -348,17 +348,39 @@ def create_depends_string (suite, depends_tree): comma_count += 1 return result -def output_deb_info(suite, filename): +def output_package_relations (): + """ + Output the package relations, if there is more than one package checked in this run. + """ + + if len(package_relations) < 2: + # Only list something if we have more than one binary to compare + package_relations.clear() + return + + to_print = "" + for package in package_relations: + for relation in package_relations[package]: + to_print += "%-15s: (%s) %s\n" % (package, relation, package_relations[package][relation]) + + package_relations.clear() + foldable_output("Package relations", "relations", to_print) + +def output_deb_info(suite, filename, packagename): (control, control_keys, section, depends, recommends, arch, maintainer) = read_control(filename) if control == '': return formatted_text("no control info") to_print = "" + if not package_relations.has_key(packagename): + package_relations[packagename] = {} for key in control_keys : if key == 'Depends': field_value = create_depends_string(suite, depends) + package_relations[packagename][key] = field_value elif key == 'Recommends': field_value = create_depends_string(suite, recommends) + package_relations[packagename][key] = field_value elif key == 'Section': field_value = section elif key == 'Architecture': @@ -414,10 +436,39 @@ def get_copyright (deb_filename): printed_copyrights[copyrightmd5] = "%s (%s)" % (package, deb_filename) return res+formatted_text(cright) +def get_readme_source (dsc_filename): + tempdir = utils.temp_dirname() + os.rmdir(tempdir) + + cmd = "dpkg-source --no-check --no-copy -x %s %s" % (dsc_filename, tempdir) + (result, output) = commands.getstatusoutput(cmd) + if (result != 0): + res = "How is education supposed to make me feel smarter? Besides, every time I learn something new, it pushes some\n old stuff out of my brain. Remember when I took that home winemaking course, and I forgot how to drive?\n" + res += "Error, couldn't extract source, WTF?\n" + res += "'dpkg-source -x' failed. return code: %s.\n\n" % (result) + res += output + return res + + path = os.path.join(tempdir, 'debian/README.source') + res = "" + if os.path.exists(path): + res += do_command("cat", path) + else: + res += "No README.source in this package\n\n" + + try: + shutil.rmtree(tempdir) + except OSError, e: + if errno.errorcode[e.errno] != 'EACCES': + res += "%s: couldn't remove tmp dir %s for source tree." % (dsc_filename, tempdir) + + return res + def check_dsc (suite, dsc_filename): (dsc) = read_changes_or_dsc(suite, dsc_filename) foldable_output(dsc_filename, "dsc", dsc, norow=True) foldable_output("lintian check for %s" % dsc_filename, "source-lintian", do_lintian(dsc_filename)) + foldable_output("README.source for %s" % dsc_filename, "source-readmesource", get_readme_source(dsc_filename)) def check_deb (suite, deb_filename): filename = os.path.basename(deb_filename) @@ -430,7 +481,7 @@ def check_deb (suite, deb_filename): foldable_output("control file for %s" % (filename), "binary-%s-control"%packagename, - output_deb_info(suite, deb_filename), norow=True) + output_deb_info(suite, deb_filename, packagename), norow=True) if is_a_udeb: foldable_output("skipping lintian check for udeb", "binary-%s-lintian"%packagename, @@ -485,7 +536,10 @@ def display_changes(suite, changes_filename): foldable_output(changes_filename, "changes", changes, norow=True) def check_changes (changes_filename): - changes = utils.parse_changes (changes_filename) + try: + changes = utils.parse_changes (changes_filename) + except ChangesUnicodeError: + utils.warn("Encoding problem with changes file %s" % (changes_filename)) display_changes(changes['distribution'], changes_filename) files = utils.build_file_list(changes) @@ -535,6 +589,7 @@ def main (): else: utils.fubar("Unrecognised file type: '%s'." % (f)) finally: + output_package_relations() if not Options["Html-Output"]: # Reset stdout here so future less invocations aren't FUBAR less_fd.close()