X-Git-Url: https://git.decadent.org.uk/gitweb/?a=blobdiff_plain;f=dak%2Fexamine_package.py;h=5eb0b21718629a35f68169a87aa754a9f950eb7c;hb=bed91400f8f58d0d44577984ac4360068b95a5b2;hp=748a3be4afe5815aa7bad922cbbd28c548d298ff;hpb=05e76c8434279daed67dc1020fe7dc5799800616;p=dak.git diff --git a/dak/examine_package.py b/dak/examine_package.py index 748a3be4..5eb0b217 100755 --- a/dak/examine_package.py +++ b/dak/examine_package.py @@ -40,7 +40,6 @@ Script to automate some parts of checking NEW packages import errno import os -import pg import re import sys import md5 @@ -48,8 +47,9 @@ import apt_pkg import apt_inst import shutil import commands -from daklib import database + from daklib import utils +from daklib.dbconn import DBConn, get_binary_from_name_suite from daklib.regexes import html_escaping, re_html_escaping, re_version, re_spacestrip, \ re_contrib, re_nonfree, re_localhost, re_newlinespace, \ re_package, re_doc_directory @@ -57,11 +57,7 @@ from daklib.regexes import html_escaping, re_html_escaping, re_version, re_space ################################################################################ Cnf = None -projectB = None - Cnf = utils.get_conf() -projectB = pg.connect(Cnf["DB::Name"], Cnf["DB::Host"], int(Cnf["DB::Port"])) -database.init(Cnf, projectB) printed_copyrights = {} package_relations = {} #: Store relations of packages for later output @@ -95,13 +91,13 @@ def escape_if_needed(s): def headline(s, level=2, bodyelement=None): if use_html: if bodyelement: - print """ + return """ %(title)s (click to toggle) - """%{"bodyelement":bodyelement,"title":utils.html_escape(s)} + \n"""%{"bodyelement":bodyelement,"title":utils.html_escape(s)} else: - print "%s" % (level, utils.html_escape(s), level) + return "%s\n" % (level, utils.html_escape(s), level) else: - print "---- %s ----" % (s) + return "---- %s ----\n" % (s) # Colour definitions, 'end' isn't really for use @@ -158,18 +154,20 @@ def format_field(k,v): def foldable_output(title, elementnameprefix, content, norow=False): d = {'elementnameprefix':elementnameprefix} + result = '' if use_html: - print """
- """%d - headline(title, bodyelement="%(elementnameprefix)s-body"%d) + result += """
\n"""%d + result += headline(title, bodyelement="%(elementnameprefix)s-body"%d) if use_html: - print """ """%d + result += """ \n"""%d if norow: - print content + result += content + "\n" else: - print output_row(content) + result += output_row(content) + "\n" if use_html: - print """
""" + result += """""" + return result ################################################################################ @@ -276,7 +274,7 @@ def read_changes_or_dsc (suite, filename): dsc_file = utils.open_file(filename) try: - dsc = utils.parse_changes(filename) + dsc = utils.parse_changes(filename, dsc_file=1) except: return formatted_text("can't parse .dsc control info") dsc_file.close() @@ -310,11 +308,12 @@ def read_changes_or_dsc (suite, filename): def create_depends_string (suite, depends_tree): result = "" if suite == 'experimental': - suite_where = " in ('experimental','unstable')" + suite_where = "in ('experimental','unstable')" else: - suite_where = " ='%s'" % suite + suite_where = "= '%s'" % suite comma_count = 1 + session = DBConn().session() for l in depends_tree: if (comma_count >= 2): result += ", " @@ -324,10 +323,9 @@ def create_depends_string (suite, depends_tree): result += " | " # doesn't do version lookup yet. - q = projectB.query("SELECT DISTINCT(b.package), b.version, c.name, su.suite_name FROM binaries b, files fi, location l, component c, bin_associations ba, suite su WHERE b.package='%s' AND b.file = fi.id AND fi.location = l.id AND l.component = c.id AND ba.bin=b.id AND ba.suite = su.id AND su.suite_name %s ORDER BY b.version desc" % (d['name'], suite_where)) - ql = q.getresult() - if ql: - i = ql[0] + res = get_binary_from_name_suite(d['name'], suite_where) + if res.rowcount > 0: + i = res.fetchone() adepends = d['name'] if d['version'] != '' : @@ -355,6 +353,7 @@ def output_package_relations (): if len(package_relations) < 2: # Only list something if we have more than one binary to compare + package_relations.clear() return to_print = "" @@ -363,7 +362,7 @@ def output_package_relations (): to_print += "%-15s: (%s) %s\n" % (package, relation, package_relations[package][relation]) package_relations.clear() - foldable_output("Package relations", "relations", to_print) + print foldable_output("Package relations", "relations", to_print) def output_deb_info(suite, filename, packagename): (control, control_keys, section, depends, recommends, arch, maintainer) = read_control(filename) @@ -465,9 +464,9 @@ def get_readme_source (dsc_filename): def check_dsc (suite, dsc_filename): (dsc) = read_changes_or_dsc(suite, dsc_filename) - foldable_output(dsc_filename, "dsc", dsc, norow=True) - foldable_output("lintian check for %s" % dsc_filename, "source-lintian", do_lintian(dsc_filename)) - foldable_output("README.source for %s" % dsc_filename, "source-readmesource", get_readme_source(dsc_filename)) + print foldable_output(dsc_filename, "dsc", dsc, norow=True) + print foldable_output("lintian check for %s" % dsc_filename, "source-lintian", do_lintian(dsc_filename)) + print foldable_output("README.source for %s" % dsc_filename, "source-readmesource", get_readme_source(dsc_filename)) def check_deb (suite, deb_filename): filename = os.path.basename(deb_filename) @@ -479,27 +478,27 @@ def check_deb (suite, deb_filename): is_a_udeb = 0 - foldable_output("control file for %s" % (filename), "binary-%s-control"%packagename, + print foldable_output("control file for %s" % (filename), "binary-%s-control"%packagename, output_deb_info(suite, deb_filename, packagename), norow=True) if is_a_udeb: - foldable_output("skipping lintian check for udeb", "binary-%s-lintian"%packagename, + print foldable_output("skipping lintian check for udeb", "binary-%s-lintian"%packagename, "") else: - foldable_output("lintian check for %s" % (filename), "binary-%s-lintian"%packagename, + print foldable_output("lintian check for %s" % (filename), "binary-%s-lintian"%packagename, do_lintian(deb_filename)) - foldable_output("contents of %s" % (filename), "binary-%s-contents"%packagename, + print foldable_output("contents of %s" % (filename), "binary-%s-contents"%packagename, do_command("dpkg -c", deb_filename)) if is_a_udeb: - foldable_output("skipping copyright for udeb", "binary-%s-copyright"%packagename, + print foldable_output("skipping copyright for udeb", "binary-%s-copyright"%packagename, "") else: - foldable_output("copyright of %s" % (filename), "binary-%s-copyright"%packagename, + print foldable_output("copyright of %s" % (filename), "binary-%s-copyright"%packagename, get_copyright(deb_filename)) - foldable_output("file listing of %s" % (filename), "binary-%s-file-listing"%packagename, + print foldable_output("file listing of %s" % (filename), "binary-%s-file-listing"%packagename, do_command("ls -l", deb_filename)) # Read a file, strip the signature and return the modified contents as @@ -532,7 +531,7 @@ def strip_pgp_signature (filename): def display_changes(suite, changes_filename): changes = read_changes_or_dsc(suite, changes_filename) - foldable_output(changes_filename, "changes", changes, norow=True) + print foldable_output(changes_filename, "changes", changes, norow=True) def check_changes (changes_filename): try: @@ -550,7 +549,7 @@ def check_changes (changes_filename): # else: => byhand def main (): - global Cnf, projectB, db_files, waste, excluded + global Cnf, db_files, waste, excluded # Cnf = utils.get_conf() @@ -567,6 +566,10 @@ def main (): if Options["Help"]: usage() + if Options["Html-Output"]: + global use_html + use_html = 1 + stdout_fd = sys.stdout for f in args: @@ -582,7 +585,7 @@ def main (): elif f.endswith(".deb") or f.endswith(".udeb"): # default to unstable when we don't have a .changes file # perhaps this should be a command line option? - check_deb('unstable', file) + check_deb('unstable', f) elif f.endswith(".dsc"): check_dsc('unstable', f) else: