X-Git-Url: https://git.decadent.org.uk/gitweb/?a=blobdiff_plain;f=dak%2Fcruft_report.py;h=fab47bf056d72bf910fd774ed48c45e584487ce6;hb=2edf9af0cc2d64eafbc4a98222e1288ce4536281;hp=07b0551b22175c5cd2f04974bc7730fc346bcf76;hpb=83b58ba130326886c984140ae05be84c6661b45e;p=dak.git

diff --git a/dak/cruft_report.py b/dak/cruft_report.py
index 07b0551b..fab47bf0 100755
--- a/dak/cruft_report.py
+++ b/dak/cruft_report.py
@@ -153,7 +153,8 @@ def parse_nfu(architecture):
     
     filename = "%s/%s-all.txt" % (Cnf["Cruft-Report::Options::Wanna-Build-Dump"], architecture)
 
-    # Not all architectures have a wanna-build dump, for example armel at the time of writing
+    # Not all architectures may have a wanna-build dump, so we want to ignore missin
+    # files
     if os.path.exists(filename):
         f = utils.open_file(filename)
         for line in f:
@@ -165,6 +166,8 @@ def parse_nfu(architecture):
                 ret.add(m.group(1))
 
         f.close()
+    else:
+        utils.warn("No wanna-build dump file for architecture %s", architecture)
     return ret
 
 ################################################################################
@@ -329,7 +332,7 @@ def main ():
         Cnf["Cruft-Report::Options::Mode"] = "daily"
 
     if not Cnf.has_key("Cruft-Report::Options::Wanna-Build-Dump"):
-        Cnf["Cruft-Report::Options::Wanna-Build-Dump"] = "./wanna-build-dump"
+        Cnf["Cruft-Report::Options::Wanna-Build-Dump"] = "/srv/ftp.debian.org/scripts/nfu"
 
     apt_pkg.ParseCommandLine(Cnf, Arguments, sys.argv)
 
@@ -432,8 +435,9 @@ def main ():
                 sys.stderr.write("Gunzip invocation failed!\n%s\n" % (output))
                 sys.exit(result)
 
-            nfu_packages.setdefault(architecture,[])
-            nfu_entries = parse_nfu(architecture)
+            if "nfu" in checks:
+                nfu_packages.setdefault(architecture,[])
+                nfu_entries = parse_nfu(architecture)
 
             packages = utils.open_file(temp_filename)
             Packages = apt_pkg.ParseTagFile(packages)
@@ -468,9 +472,10 @@ def main ():
                         duplicate_bins.setdefault(key, [])
                         if package not in duplicate_bins[key]:
                             duplicate_bins[key].append(package)
-                    if package in nfu_entries and \
-                        version != source_versions[source]: # only suggest to remove out-of-date packages
-                        nfu_packages[architecture].append((package,version,source_versions[source]))
+                    if "nfu" in checks:
+                        if package in nfu_entries and \
+                               version != source_versions[source]: # only suggest to remove out-of-date packages
+                            nfu_packages[architecture].append((package,version,source_versions[source]))
                     
             packages.close()
             os.unlink(temp_filename)