#include <sys/time.h>
#include <sys/ioctl.h>
#include <sys/socket.h>
-#include <arpa/inet.h>
#include <netinet/in.h>
#include <net/if.h>
#define DHCPV6_DUID_LLADDR 3
#define DHCPV6_REQ_DELAY 1
+#define DHCPV6_SOL_MAX_RT_MIN 60
+#define DHCPV6_SOL_MAX_RT_MAX 86400
+#define DHCPV6_INF_MAX_RT_MIN 60
+#define DHCPV6_INF_MAX_RT_MAX 86400
static bool dhcpv6_response_is_valid(const void *buf, ssize_t len,
const uint8_t transaction[3], enum dhcpv6_msg type,
static struct dhcpv6_retx dhcpv6_retx[_DHCPV6_MSG_MAX] = {
[DHCPV6_MSG_UNKNOWN] = {false, 1, 120, 0, "<POLL>",
dhcpv6_handle_reconfigure, NULL},
- [DHCPV6_MSG_SOLICIT] = {true, 1, 3600, 0, "SOLICIT",
+ [DHCPV6_MSG_SOLICIT] = {true, 1, DHCPV6_SOL_MAX_RT, 0, "SOLICIT",
dhcpv6_handle_advert, dhcpv6_commit_advert},
- [DHCPV6_MSG_REQUEST] = {true, 1, 30, 10, "REQUEST",
+ [DHCPV6_MSG_REQUEST] = {true, 1, DHCPV6_REQ_MAX_RT, 10, "REQUEST",
dhcpv6_handle_reply, NULL},
- [DHCPV6_MSG_RENEW] = {false, 10, 600, 0, "RENEW",
+ [DHCPV6_MSG_RENEW] = {false, 10, DHCPV6_REN_MAX_RT, 0, "RENEW",
dhcpv6_handle_reply, NULL},
- [DHCPV6_MSG_REBIND] = {false, 10, 600, 0, "REBIND",
+ [DHCPV6_MSG_REBIND] = {false, 10, DHCPV6_REB_MAX_RT, 0, "REBIND",
dhcpv6_handle_rebind_reply, NULL},
[DHCPV6_MSG_RELEASE] = {false, 1, 0, 5, "RELEASE", NULL, NULL},
[DHCPV6_MSG_DECLINE] = {false, 1, 0, 5, "DECLINE", NULL, NULL},
- [DHCPV6_MSG_INFO_REQ] = {true, 1, 120, 0, "INFOREQ",
+ [DHCPV6_MSG_INFO_REQ] = {true, 1, DHCPV6_INF_MAX_RT, 0, "INFOREQ",
dhcpv6_handle_reply, NULL},
};
static int request_prefix = -1;
static enum odhcp6c_ia_mode na_mode = IA_MODE_NONE, pd_mode = IA_MODE_NONE;
static bool accept_reconfig = false;
-// Server unicast address
-static struct in6_addr server_addr = IN6ADDR_ANY_INIT;
// Reconfigure key
static uint8_t reconf_key[16];
htons(DHCPV6_OPT_SIP_SERVER_A),
htons(DHCPV6_OPT_DNS_SERVERS),
htons(DHCPV6_OPT_DNS_DOMAIN),
- htons(DHCPV6_OPT_UNICAST),
htons(DHCPV6_OPT_NTP_SERVER),
htons(DHCPV6_OPT_AFTR_NAME),
htons(DHCPV6_OPT_PD_EXCLUDE),
+ htons(DHCPV6_OPT_SOL_MAX_RT),
+ htons(DHCPV6_OPT_INF_MAX_RT),
#ifdef EXT_PREFIX_CLASS
htons(DHCPV6_OPT_PREFIX_CLASS),
#endif
0, ALL_DHCPV6_RELAYS, ifindex};
struct msghdr msg = {&srv, sizeof(srv), iov, cnt, NULL, 0, 0};
- switch (type) {
- case DHCPV6_MSG_REQUEST:
- case DHCPV6_MSG_RENEW:
- case DHCPV6_MSG_RELEASE:
- case DHCPV6_MSG_DECLINE:
- if (!IN6_IS_ADDR_UNSPECIFIED(&server_addr) &&
- odhcp6c_addr_in_scope(&server_addr)) {
- srv.sin6_addr = server_addr;
- if (!IN6_IS_ADDR_LINKLOCAL(&server_addr))
- srv.sin6_scope_id = 0;
- }
- break;
- default:
- break;
- }
-
- if (sendmsg(sock, &msg, 0) < 0) {
- char in6_str[INET6_ADDRSTRLEN];
-
- syslog(LOG_ERR, "Failed to send DHCPV6 message to %s (%s)",
- inet_ntop(AF_INET6, (const void *)&srv.sin6_addr,
- in6_str, sizeof(in6_str)), strerror(errno));
- }
+ sendmsg(sock, &msg, 0);
}
return false;
}
- uint8_t *end = ((uint8_t*)buf) + len, *odata,
+ uint8_t *end = ((uint8_t*)buf) + len, *odata = NULL,
rcmsg = DHCPV6_MSG_UNKNOWN;
- uint16_t otype, olen;
+ uint16_t otype, olen = UINT16_MAX;
bool clientid_ok = false, serverid_ok = false, rcauth_ok = false,
ia_present = false, options_valid = true;
}
}
- if (!options_valid)
+ if (!options_valid || ((odata + olen) > end))
return false;
if (type == DHCPV6_MSG_INFO_REQ && ia_present)
uint16_t olen, otype;
uint8_t *odata, pref = 0;
struct dhcpv6_server_cand cand = {false, false, 0, 0, {0},
- IN6ADDR_ANY_INIT, NULL, NULL, 0, 0};
+ DHCPV6_SOL_MAX_RT,
+ DHCPV6_INF_MAX_RT, NULL, NULL, 0, 0};
bool have_na = false;
int have_pd = 0;
switch (error) {
case DHCPV6_NoPrefixAvail:
// Status code on global level
- if (pd_mode == IA_MODE_FORCE)
- return -1;
cand.preference -= 2000;
break;
- case DHCPV6_NoAddrsAvail:
- // Status code on global level
- if (na_mode == IA_MODE_FORCE)
- return -1;
- break;
-
default :
break;
}
} else if (otype == DHCPV6_OPT_PREF && olen >= 1 &&
cand.preference >= 0) {
cand.preference = pref = odata[0];
- } else if (otype == DHCPV6_OPT_UNICAST && olen == sizeof(cand.server_addr)) {
- cand.server_addr = *(struct in6_addr *)odata;
} else if (otype == DHCPV6_OPT_RECONF_ACCEPT) {
cand.wants_reconfigure = true;
+ } else if (otype == DHCPV6_OPT_SOL_MAX_RT && olen == 4) {
+ uint32_t sol_max_rt = ntohl(*((uint32_t *)odata));
+ if (sol_max_rt >= DHCPV6_SOL_MAX_RT_MIN &&
+ sol_max_rt <= DHCPV6_SOL_MAX_RT_MAX)
+ cand.sol_max_rt = sol_max_rt;
+ } else if (otype == DHCPV6_OPT_INF_MAX_RT && olen == 4) {
+ uint32_t inf_max_rt = ntohl(*((uint32_t *)odata));
+ if (inf_max_rt >= DHCPV6_INF_MAX_RT_MIN &&
+ inf_max_rt <= DHCPV6_INF_MAX_RT_MAX)
+ cand.inf_max_rt = inf_max_rt;
} else if (otype == DHCPV6_OPT_IA_PD && request_prefix) {
struct dhcpv6_ia_hdr *h = (struct dhcpv6_ia_hdr*)&odata[-4];
uint8_t *oend = odata + olen, *d;
}
if ((!have_na && na_mode == IA_MODE_FORCE) ||
- (!have_pd && pd_mode == IA_MODE_FORCE))
+ (!have_pd && pd_mode == IA_MODE_FORCE)) {
+ /*
+ * RFC7083 states to process the SOL_MAX_RT and
+ * INF_MAX_RT options even if the DHCPv6 server
+ * did not propose any IA_NA and/or IA_PD
+ */
+ dhcpv6_retx[DHCPV6_MSG_SOLICIT].max_timeo = cand.sol_max_rt;
+ dhcpv6_retx[DHCPV6_MSG_INFO_REQ].max_timeo = cand.inf_max_rt;
return -1;
+ }
if (na_mode != IA_MODE_NONE && !have_na) {
cand.has_noaddravail = true;
continue;
dhcpv6_parse_ia(ia_hdr, odata + olen + sizeof(*ia_hdr));
- } else if (otype == DHCPV6_OPT_UNICAST && olen == sizeof(server_addr)) {
- server_addr = *(struct in6_addr *)odata;
} else if (otype == DHCPV6_OPT_STATUS && olen >= 2) {
uint8_t *mdata = (olen > 2) ? &odata[2] : NULL;
uint16_t mlen = (olen > 2) ? olen - 2 : 0;
odhcp6c_get_state(STATE_AFTR_NAME, &cur_len);
if (cur_len == 0)
odhcp6c_add_state(STATE_AFTR_NAME, odata, olen);
- } else if (otype != DHCPV6_OPT_CLIENTID &&
+ } else if (otype == DHCPV6_OPT_SOL_MAX_RT && olen == 4) {
+ uint32_t sol_max_rt = ntohl(*((uint32_t *)odata));
+ if (sol_max_rt >= DHCPV6_SOL_MAX_RT_MIN &&
+ sol_max_rt <= DHCPV6_SOL_MAX_RT_MAX)
+ dhcpv6_retx[DHCPV6_MSG_SOLICIT].max_timeo = sol_max_rt;
+ } else if (otype == DHCPV6_OPT_INF_MAX_RT && olen == 4) {
+ uint32_t inf_max_rt = ntohl(*((uint32_t *)odata));
+ if (inf_max_rt >= DHCPV6_INF_MAX_RT_MIN &&
+ inf_max_rt <= DHCPV6_INF_MAX_RT_MAX)
+ dhcpv6_retx[DHCPV6_MSG_INFO_REQ].max_timeo = inf_max_rt;
+ }else if (otype != DHCPV6_OPT_CLIENTID &&
otype != DHCPV6_OPT_SERVERID) {
odhcp6c_add_state(STATE_CUSTOM_OPTS,
&odata[-4], olen + 4);
break;
case DHCPV6_UseMulticast:
- switch(orig) {
- case DHCPV6_MSG_REQUEST:
- case DHCPV6_MSG_RENEW:
- case DHCPV6_MSG_RELEASE:
- case DHCPV6_MSG_DECLINE:
- // Message needs to be retransmitted according to RFC3315 chapter 18.1.8
- server_addr = in6addr_any;
- *ret = 0;
- break;
- default:
- break;
- }
+ // TODO handle multicast status code
break;
case DHCPV6_NoAddrsAvail:
// Remove identical duid server candidate
for (i = 0; i < cand_len / sizeof(*c); ++i) {
if (cand->duid_len == c[i].duid_len &&
- !memcmp(cand->duid, c[i].duid, cand->duid_len)) {
+ !memcmp(cand->duid, c[i].duid, cand->duid_len)) {
free(c[i].ia_na);
free(c[i].ia_pd);
odhcp6c_remove_state(STATE_SERVER_CAND, i * sizeof(*c), sizeof(*c));
// Server candidates need deep delete for IA_NA/IA_PD
for (i = 0; i < cand_len / sizeof(*c); ++i) {
- if (c[i].ia_na)
- free(c[i].ia_na);
- if (c[i].ia_pd)
- free(c[i].ia_pd);
+ free(c[i].ia_na);
+ free(c[i].ia_pd);
}
odhcp6c_clear_state(STATE_SERVER_CAND);
}
if (cand->has_noaddravail && na_mode == IA_MODE_TRY) {
na_mode = IA_MODE_NONE;
+
+ dhcpv6_retx[DHCPV6_MSG_SOLICIT].max_timeo = cand->sol_max_rt;
+ dhcpv6_retx[DHCPV6_MSG_INFO_REQ].max_timeo = cand->inf_max_rt;
+
return dhcpv6_request(DHCPV6_MSG_SOLICIT);
}
ret = DHCPV6_STATEFUL;
}
+ dhcpv6_retx[DHCPV6_MSG_SOLICIT].max_timeo = cand->sol_max_rt;
+ dhcpv6_retx[DHCPV6_MSG_INFO_REQ].max_timeo = cand->inf_max_rt;
+
odhcp6c_remove_state(STATE_SERVER_CAND, 0, sizeof(*cand));
return ret;