#!/usr/bin/env python
-# General purpose package removal tool for ftpmaster
-# Copyright (C) 2000, 2001, 2002, 2003, 2004 James Troup <james@nocrew.org>
-# $Id: melanie,v 1.44 2005-11-15 09:50:32 ajt Exp $
+""" General purpose package removal tool for ftpmaster """
+# Copyright (C) 2000, 2001, 2002, 2003, 2004, 2006 James Troup <james@nocrew.org>
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
################################################################################
-import commands, os, pg, re, sys;
-import utils, db_access;
-import apt_pkg, apt_inst;
+import commands
+import os
+import re
+import sys
+import apt_pkg
+import apt_inst
-################################################################################
-
-re_strip_source_version = re.compile (r'\s+.*$');
-re_build_dep_arch = re.compile(r"\[[^]]+\]");
+from daklib.config import Config
+from daklib.dbconn import *
+from daklib import utils
+from daklib.dak_exceptions import *
+from daklib.regexes import re_strip_source_version, re_build_dep_arch
################################################################################
-Cnf = None;
-Options = None;
-projectB = None;
+Options = None
################################################################################
def usage (exit_code=0):
- print """Usage: melanie [OPTIONS] PACKAGE[...]
+ print """Usage: dak rm [OPTIONS] PACKAGE[...]
Remove PACKAGE(s) from suite(s).
-a, --architecture=ARCH only act on this architecture
# the fuck are we gonna do now? What are we gonna do?"
def game_over():
- answer = utils.our_raw_input("Continue (y/N)? ").lower();
+ answer = utils.our_raw_input("Continue (y/N)? ").lower()
if answer != "y":
print "Aborted."
- sys.exit(1);
+ sys.exit(1)
################################################################################
-def reverse_depends_check(removals, suites):
+def reverse_depends_check(removals, suites, arches=None):
+ cnf = Config()
+
print "Checking reverse dependencies..."
- components = Cnf.ValueList("Suite::%s::Components" % suites[0])
+ components = cnf.ValueList("Suite::%s::Components" % suites[0])
dep_problem = 0
- p2c = {};
- for architecture in Cnf.ValueList("Suite::%s::Architectures" % suites[0]):
- if architecture in ["source", "all"]:
- continue
- deps = {};
- virtual_packages = {};
+ p2c = {}
+ all_broken = {}
+ if arches:
+ all_arches = set(arches)
+ else:
+ all_arches = set([x.arch_string for x in get_suite_architectures(suites[0])])
+ all_arches -= set(["source", "all"])
+ for architecture in all_arches:
+ deps = {}
+ sources = {}
+ virtual_packages = {}
for component in components:
- filename = "%s/dists/%s/%s/binary-%s/Packages.gz" % (Cnf["Dir::Root"], suites[0], component, architecture)
+ filename = "%s/dists/%s/%s/binary-%s/Packages.gz" % (cnf["Dir::Root"], suites[0], component, architecture)
# apt_pkg.ParseTagFile needs a real file handle and can't handle a GzipFile instance...
- temp_filename = utils.temp_filename();
- (result, output) = commands.getstatusoutput("gunzip -c %s > %s" % (filename, temp_filename));
+ (fd, temp_filename) = utils.temp_filename()
+ (result, output) = commands.getstatusoutput("gunzip -c %s > %s" % (filename, temp_filename))
if (result != 0):
- utils.fubar("Gunzip invocation failed!\n%s\n" % (output), result);
- packages = utils.open_file(temp_filename);
+ utils.fubar("Gunzip invocation failed!\n%s\n" % (output), result)
+ packages = utils.open_file(temp_filename)
Packages = apt_pkg.ParseTagFile(packages)
while Packages.Step():
package = Packages.Section.Find("Package")
+ source = Packages.Section.Find("Source")
+ if not source:
+ source = package
+ elif ' ' in source:
+ source = source.split(' ', 1)[0]
+ sources[package] = source
depends = Packages.Section.Find("Depends")
if depends:
deps[package] = depends
virtual_packages[virtual_pkg] = 0
if package not in removals:
virtual_packages[virtual_pkg] += 1
- p2c[package] = component;
+ p2c[package] = component
packages.close()
- os.unlink(temp_filename);
+ os.unlink(temp_filename)
# If a virtual package is only provided by the to-be-removed
# packages, treat the virtual package as to-be-removed too.
unsat = 0
for dep_package, _, _ in dep:
if dep_package in removals:
- unsat += 1
+ unsat += 1
if unsat == len(dep):
- component = p2c[package];
+ component = p2c[package]
+ source = sources[package]
if component != "main":
- what = "%s/%s" % (package, component);
- else:
- what = "** %s" % (package);
- print "%s has an unsatisfied dependency on %s: %s" % (what, architecture, utils.pp_deps(dep));
+ source = "%s/%s" % (source, component)
+ all_broken.setdefault(source, {}).setdefault(package, set()).add(architecture)
dep_problem = 1
+ if all_broken:
+ print "# Broken Depends:"
+ for source, bindict in sorted(all_broken.items()):
+ lines = []
+ for binary, arches in sorted(bindict.items()):
+ if arches == all_arches:
+ lines.append(binary)
+ else:
+ lines.append('%s [%s]' % (binary, ' '.join(sorted(arches))))
+ print '%s: %s' % (source, lines[0])
+ for line in lines[1:]:
+ print ' ' * (len(source) + 2) + line
+ print
+
# Check source dependencies (Build-Depends and Build-Depends-Indep)
+ all_broken.clear()
for component in components:
- filename = "%s/dists/%s/%s/source/Sources.gz" % (Cnf["Dir::Root"], suites[0], component)
+ filename = "%s/dists/%s/%s/source/Sources.gz" % (cnf["Dir::Root"], suites[0], component)
# apt_pkg.ParseTagFile needs a real file handle and can't handle a GzipFile instance...
- temp_filename = utils.temp_filename();
+ (fd, temp_filename) = utils.temp_filename()
result, output = commands.getstatusoutput("gunzip -c %s > %s" % (filename, temp_filename))
if result != 0:
sys.stderr.write("Gunzip invocation failed!\n%s\n" % (output))
unsat = 0
for dep_package, _, _ in dep:
if dep_package in removals:
- unsat += 1
+ unsat += 1
if unsat == len(dep):
if component != "main":
- source = "%s/%s" % (source, component);
- else:
- source = "** %s" % (source);
- print "%s has an unsatisfied build-dependency: %s" % (source, utils.pp_deps(dep))
+ source = "%s/%s" % (source, component)
+ all_broken.setdefault(source, set()).add(utils.pp_deps(dep))
dep_problem = 1
sources.close()
os.unlink(temp_filename)
+ if all_broken:
+ print "# Broken Build-Depends:"
+ for source, bdeps in sorted(all_broken.items()):
+ bdeps = sorted(bdeps)
+ print '%s: %s' % (source, bdeps[0])
+ for bdep in bdeps[1:]:
+ print ' ' * (len(source) + 2) + bdep
+ print
+
if dep_problem:
print "Dependency problem found."
if not Options["No-Action"]:
else:
print "No dependency problem found."
print
-
+
################################################################################
def main ():
- global Cnf, Options, projectB;
-
- Cnf = utils.get_conf()
-
- Arguments = [('h',"help","Melanie::Options::Help"),
- ('a',"architecture","Melanie::Options::Architecture", "HasArg"),
- ('b',"binary", "Melanie::Options::Binary-Only"),
- ('c',"component", "Melanie::Options::Component", "HasArg"),
- ('C',"carbon-copy", "Melanie::Options::Carbon-Copy", "HasArg"), # Bugs to Cc
- ('d',"done","Melanie::Options::Done", "HasArg"), # Bugs fixed
- ('R',"rdep-check", "Melanie::Options::Rdep-Check"),
- ('m',"reason", "Melanie::Options::Reason", "HasArg"), # Hysterical raisins; -m is old-dinstall option for rejection reason
- ('n',"no-action","Melanie::Options::No-Action"),
- ('p',"partial", "Melanie::Options::Partial"),
- ('s',"suite","Melanie::Options::Suite", "HasArg"),
- ('S',"source-only", "Melanie::Options::Source-Only"),
- ];
+ global Options
+
+ cnf = Config()
+
+ Arguments = [('h',"help","Rm::Options::Help"),
+ ('a',"architecture","Rm::Options::Architecture", "HasArg"),
+ ('b',"binary", "Rm::Options::Binary-Only"),
+ ('c',"component", "Rm::Options::Component", "HasArg"),
+ ('C',"carbon-copy", "Rm::Options::Carbon-Copy", "HasArg"), # Bugs to Cc
+ ('d',"done","Rm::Options::Done", "HasArg"), # Bugs fixed
+ ('R',"rdep-check", "Rm::Options::Rdep-Check"),
+ ('m',"reason", "Rm::Options::Reason", "HasArg"), # Hysterical raisins; -m is old-dinstall option for rejection reason
+ ('n',"no-action","Rm::Options::No-Action"),
+ ('p',"partial", "Rm::Options::Partial"),
+ ('s',"suite","Rm::Options::Suite", "HasArg"),
+ ('S',"source-only", "Rm::Options::Source-Only"),
+ ]
for i in [ "architecture", "binary-only", "carbon-copy", "component",
"done", "help", "no-action", "partial", "rdep-check", "reason",
"source-only" ]:
- if not Cnf.has_key("Melanie::Options::%s" % (i)):
- Cnf["Melanie::Options::%s" % (i)] = "";
- if not Cnf.has_key("Melanie::Options::Suite"):
- Cnf["Melanie::Options::Suite"] = "unstable";
+ if not cnf.has_key("Rm::Options::%s" % (i)):
+ cnf["Rm::Options::%s" % (i)] = ""
+ if not cnf.has_key("Rm::Options::Suite"):
+ cnf["Rm::Options::Suite"] = "unstable"
- arguments = apt_pkg.ParseCommandLine(Cnf,Arguments,sys.argv);
- Options = Cnf.SubTree("Melanie::Options")
+ arguments = apt_pkg.ParseCommandLine(cnf.Cnf, Arguments, sys.argv)
+ Options = cnf.SubTree("Rm::Options")
if Options["Help"]:
- usage();
+ usage()
- projectB = pg.connect(Cnf["DB::Name"], Cnf["DB::Host"], int(Cnf["DB::Port"]));
- db_access.init(Cnf, projectB);
+ session = DBConn().session()
# Sanity check options
if not arguments:
- utils.fubar("need at least one package name as an argument.");
+ utils.fubar("need at least one package name as an argument.")
if Options["Architecture"] and Options["Source-Only"]:
- utils.fubar("can't use -a/--architecutre and -S/--source-only options simultaneously.");
+ utils.fubar("can't use -a/--architecture and -S/--source-only options simultaneously.")
if Options["Binary-Only"] and Options["Source-Only"]:
- utils.fubar("can't use -b/--binary-only and -S/--source-only options simultaneously.");
+ utils.fubar("can't use -b/--binary-only and -S/--source-only options simultaneously.")
if Options.has_key("Carbon-Copy") and not Options.has_key("Done"):
- utils.fubar("can't use -C/--carbon-copy without also using -d/--done option.");
+ utils.fubar("can't use -C/--carbon-copy without also using -d/--done option.")
if Options["Architecture"] and not Options["Partial"]:
- utils.warn("-a/--architecture implies -p/--partial.");
- Options["Partial"] = "true";
+ utils.warn("-a/--architecture implies -p/--partial.")
+ Options["Partial"] = "true"
- # Force the admin to tell someone if we're not doing a rene-led removal
- # (or closing a bug, which counts as telling someone).
+ # Force the admin to tell someone if we're not doing a 'dak
+ # cruft-report' inspired removal (or closing a bug, which counts
+ # as telling someone).
if not Options["No-Action"] and not Options["Carbon-Copy"] \
- and not Options["Done"] and Options["Reason"].find("[rene]") == -1:
- utils.fubar("Need a -C/--carbon-copy if not closing a bug and not doing a rene-led removal.");
+ and not Options["Done"] and Options["Reason"].find("[auto-cruft]") == -1:
+ utils.fubar("Need a -C/--carbon-copy if not closing a bug and not doing a cruft removal.")
# Process -C/--carbon-copy
#
# 2) the keyword 'package' - cc's $package@packages.debian.org for every argument
# 3) contains a '@' - assumed to be an email address, used unmofidied
#
- carbon_copy = [];
+ carbon_copy = []
for copy_to in utils.split_args(Options.get("Carbon-Copy")):
- if utils.str_isnum(copy_to):
- carbon_copy.append(copy_to + "@" + Cnf["Dinstall::BugServer"]);
+ if copy_to.isdigit():
+ carbon_copy.append(copy_to + "@" + cnf["Dinstall::BugServer"])
elif copy_to == 'package':
for package in arguments:
- carbon_copy.append(package + "@" + Cnf["Dinstall::PackagesServer"]);
- if Cnf.has_key("Dinstall::TrackingServer"):
- carbon_copy.append(package + "@" + Cnf["Dinstall::TrackingServer"]);
+ carbon_copy.append(package + "@" + cnf["Dinstall::PackagesServer"])
+ if cnf.has_key("Dinstall::TrackingServer"):
+ carbon_copy.append(package + "@" + cnf["Dinstall::TrackingServer"])
elif '@' in copy_to:
- carbon_copy.append(copy_to);
+ carbon_copy.append(copy_to)
else:
- utils.fubar("Invalid -C/--carbon-copy argument '%s'; not a bug number, 'package' or email address." % (copy_to));
+ utils.fubar("Invalid -C/--carbon-copy argument '%s'; not a bug number, 'package' or email address." % (copy_to))
if Options["Binary-Only"]:
- field = "b.package";
+ field = "b.package"
else:
- field = "s.source";
- con_packages = "AND %s IN (%s)" % (field, ", ".join(map(repr, arguments)));
+ field = "s.source"
+ con_packages = "AND %s IN (%s)" % (field, ", ".join([ repr(i) for i in arguments ]))
(con_suites, con_architectures, con_components, check_source) = \
- utils.parse_args(Options);
+ utils.parse_args(Options)
# Additional suite checks
- suite_ids_list = [];
- suites = utils.split_args(Options["Suite"]);
- suites_list = utils.join_with_commas_and(suites);
+ suite_ids_list = []
+ suites = utils.split_args(Options["Suite"])
+ suites_list = utils.join_with_commas_and(suites)
if not Options["No-Action"]:
for suite in suites:
- suite_id = db_access.get_suite_id(suite);
- if suite_id != -1:
- suite_ids_list.append(suite_id);
+ s = get_suite(suite, session=session)
+ if s is not None:
+ suite_ids_list.append(s.suite_id)
if suite == "stable":
print "**WARNING** About to remove from the stable suite!"
print "This should only be done just prior to a (point) release and not at"
print "any other time."
- game_over();
+ game_over()
elif suite == "testing":
print "**WARNING About to remove from the testing suite!"
print "There's no need to do this normally as removals from unstable will"
print "propogate to testing automagically."
- game_over();
+ game_over()
# Additional architecture checks
if Options["Architecture"] and check_source:
- utils.warn("'source' in -a/--argument makes no sense and is ignored.");
+ utils.warn("'source' in -a/--argument makes no sense and is ignored.")
# Additional component processing
- over_con_components = con_components.replace("c.id", "component");
+ over_con_components = con_components.replace("c.id", "component")
print "Working...",
- sys.stdout.flush();
- to_remove = [];
- maintainers = {};
+ sys.stdout.flush()
+ to_remove = []
+ maintainers = {}
# We have 3 modes of package selection: binary-only, source-only
# and source+binary. The first two are trivial and obvious; the
# latter is a nasty mess, but very nice from a UI perspective so
# we try to support it.
+ # XXX: TODO: This all needs converting to use placeholders or the object
+ # API. It's an SQL injection dream at the moment
+
if Options["Binary-Only"]:
# Binary-only
- q = projectB.query("SELECT b.package, b.version, a.arch_string, b.id, b.maintainer FROM binaries b, bin_associations ba, architecture a, suite su, files f, location l, component c WHERE ba.bin = b.id AND ba.suite = su.id AND b.architecture = a.id AND b.file = f.id AND f.location = l.id AND l.component = c.id %s %s %s %s" % (con_packages, con_suites, con_components, con_architectures));
- for i in q.getresult():
- to_remove.append(i);
+ q = session.execute("SELECT b.package, b.version, a.arch_string, b.id, b.maintainer FROM binaries b, bin_associations ba, architecture a, suite su, files f, location l, component c WHERE ba.bin = b.id AND ba.suite = su.id AND b.architecture = a.id AND b.file = f.id AND f.location = l.id AND l.component = c.id %s %s %s %s" % (con_packages, con_suites, con_components, con_architectures))
+ for i in q.fetchall():
+ to_remove.append(i)
else:
# Source-only
- source_packages = {};
- q = projectB.query("SELECT l.path, f.filename, s.source, s.version, 'source', s.id, s.maintainer FROM source s, src_associations sa, suite su, files f, location l, component c WHERE sa.source = s.id AND sa.suite = su.id AND s.file = f.id AND f.location = l.id AND l.component = c.id %s %s %s" % (con_packages, con_suites, con_components));
- for i in q.getresult():
- source_packages[i[2]] = i[:2];
- to_remove.append(i[2:]);
+ source_packages = {}
+ q = session.execute("SELECT l.path, f.filename, s.source, s.version, 'source', s.id, s.maintainer FROM source s, src_associations sa, suite su, files f, location l, component c WHERE sa.source = s.id AND sa.suite = su.id AND s.file = f.id AND f.location = l.id AND l.component = c.id %s %s %s" % (con_packages, con_suites, con_components))
+ for i in q.fetchall():
+ source_packages[i[2]] = i[:2]
+ to_remove.append(i[2:])
if not Options["Source-Only"]:
# Source + Binary
- binary_packages = {};
+ binary_packages = {}
# First get a list of binary package names we suspect are linked to the source
- q = projectB.query("SELECT DISTINCT b.package FROM binaries b, source s, src_associations sa, suite su, files f, location l, component c WHERE b.source = s.id AND sa.source = s.id AND sa.suite = su.id AND s.file = f.id AND f.location = l.id AND l.component = c.id %s %s %s" % (con_packages, con_suites, con_components));
- for i in q.getresult():
- binary_packages[i[0]] = "";
+ q = session.execute("SELECT DISTINCT b.package FROM binaries b, source s, src_associations sa, suite su, files f, location l, component c WHERE b.source = s.id AND sa.source = s.id AND sa.suite = su.id AND s.file = f.id AND f.location = l.id AND l.component = c.id %s %s %s" % (con_packages, con_suites, con_components))
+ for i in q.fetchall():
+ binary_packages[i[0]] = ""
# Then parse each .dsc that we found earlier to see what binary packages it thinks it produces
for i in source_packages.keys():
- filename = "/".join(source_packages[i]);
+ filename = "/".join(source_packages[i])
try:
- dsc = utils.parse_changes(filename);
- except utils.cant_open_exc:
- utils.warn("couldn't open '%s'." % (filename));
- continue;
+ dsc = utils.parse_changes(filename)
+ except CantOpenError:
+ utils.warn("couldn't open '%s'." % (filename))
+ continue
for package in dsc.get("binary").split(','):
- package = package.strip();
- binary_packages[package] = "";
+ package = package.strip()
+ binary_packages[package] = ""
# Then for each binary package: find any version in
# unstable, check the Source: field in the deb matches our
# source package and if so add it to the list of packages
# to be removed.
for package in binary_packages.keys():
- q = projectB.query("SELECT l.path, f.filename, b.package, b.version, a.arch_string, b.id, b.maintainer FROM binaries b, bin_associations ba, architecture a, suite su, files f, location l, component c WHERE ba.bin = b.id AND ba.suite = su.id AND b.architecture = a.id AND b.file = f.id AND f.location = l.id AND l.component = c.id %s %s %s AND b.package = '%s'" % (con_suites, con_components, con_architectures, package));
- for i in q.getresult():
- filename = "/".join(i[:2]);
+ q = session.execute("SELECT l.path, f.filename, b.package, b.version, a.arch_string, b.id, b.maintainer FROM binaries b, bin_associations ba, architecture a, suite su, files f, location l, component c WHERE ba.bin = b.id AND ba.suite = su.id AND b.architecture = a.id AND b.file = f.id AND f.location = l.id AND l.component = c.id %s %s %s AND b.package = '%s'" % (con_suites, con_components, con_architectures, package))
+ for i in q.fetchall():
+ filename = "/".join(i[:2])
control = apt_pkg.ParseSection(apt_inst.debExtractControl(utils.open_file(filename)))
- source = control.Find("Source", control.Find("Package"));
- source = re_strip_source_version.sub('', source);
+ source = control.Find("Source", control.Find("Package"))
+ source = re_strip_source_version.sub('', source)
if source_packages.has_key(source):
- to_remove.append(i[2:]);
+ to_remove.append(i[2:])
print "done."
if not to_remove:
print "Nothing to do."
- sys.exit(0);
+ sys.exit(0)
# If we don't have a reason; spawn an editor so the user can add one
# Write the rejection email out as the <foo>.reason file
if not Options["Reason"] and not Options["No-Action"]:
- temp_filename = utils.temp_filename();
+ (fd, temp_filename) = utils.temp_filename()
editor = os.environ.get("EDITOR","vi")
result = os.system("%s %s" % (editor, temp_filename))
if result != 0:
utils.fubar ("vi invocation failed for `%s'!" % (temp_filename), result)
- temp_file = utils.open_file(temp_filename);
+ temp_file = utils.open_file(temp_filename)
for line in temp_file.readlines():
- Options["Reason"] += line;
- temp_file.close();
- os.unlink(temp_filename);
+ Options["Reason"] += line
+ temp_file.close()
+ os.unlink(temp_filename)
# Generate the summary of what's to be removed
- d = {};
+ d = {}
for i in to_remove:
- package = i[0];
- version = i[1];
- architecture = i[2];
- maintainer = i[4];
- maintainers[maintainer] = "";
+ package = i[0]
+ version = i[1]
+ architecture = i[2]
+ maintainer = i[4]
+ maintainers[maintainer] = ""
if not d.has_key(package):
- d[package] = {};
+ d[package] = {}
if not d[package].has_key(version):
- d[package][version] = [];
+ d[package][version] = []
if architecture not in d[package][version]:
- d[package][version].append(architecture);
+ d[package][version].append(architecture)
- maintainer_list = [];
+ maintainer_list = []
for maintainer_id in maintainers.keys():
- maintainer_list.append(db_access.get_maintainer(maintainer_id));
- summary = "";
- removals = d.keys();
- removals.sort();
+ maintainer_list.append(get_maintainer(maintainer_id).name)
+ summary = ""
+ removals = d.keys()
+ removals.sort()
for package in removals:
- versions = d[package].keys();
- versions.sort(apt_pkg.VersionCompare);
+ versions = d[package].keys()
+ versions.sort(apt_pkg.VersionCompare)
for version in versions:
- d[package][version].sort(utils.arch_compare_sw);
- summary += "%10s | %10s | %s\n" % (package, version, ", ".join(d[package][version]));
- print "Will remove the following packages from %s:" % (suites_list);
+ d[package][version].sort(utils.arch_compare_sw)
+ summary += "%10s | %10s | %s\n" % (package, version, ", ".join(d[package][version]))
+ print "Will remove the following packages from %s:" % (suites_list)
print
print summary
print "Maintainer: %s" % ", ".join(maintainer_list)
if Options["Done"]:
- print "Will also close bugs: "+Options["Done"];
+ print "Will also close bugs: "+Options["Done"]
if carbon_copy:
print "Will also send CCs to: " + ", ".join(carbon_copy)
print
print "------------------- Reason -------------------"
- print Options["Reason"];
+ print Options["Reason"]
print "----------------------------------------------"
print
if Options["Rdep-Check"]:
- reverse_depends_check(removals, suites);
+ arches = utils.split_args(Options["Architecture"])
+ reverse_depends_check(removals, suites, arches)
# If -n/--no-action, drop out here
if Options["No-Action"]:
- sys.exit(0);
+ sys.exit(0)
print "Going to remove the packages now."
- game_over();
+ game_over()
- whoami = utils.whoami();
- date = commands.getoutput('date -R');
+ whoami = utils.whoami()
+ date = commands.getoutput('date -R')
# Log first; if it all falls apart I want a record that we at least tried.
- logfile = utils.open_file(Cnf["Melanie::LogFile"], 'a');
- logfile.write("=========================================================================\n");
- logfile.write("[Date: %s] [ftpmaster: %s]\n" % (date, whoami));
- logfile.write("Removed the following packages from %s:\n\n%s" % (suites_list, summary));
+ logfile = utils.open_file(cnf["Rm::LogFile"], 'a')
+ logfile.write("=========================================================================\n")
+ logfile.write("[Date: %s] [ftpmaster: %s]\n" % (date, whoami))
+ logfile.write("Removed the following packages from %s:\n\n%s" % (suites_list, summary))
if Options["Done"]:
- logfile.write("Closed bugs: %s\n" % (Options["Done"]));
- logfile.write("\n------------------- Reason -------------------\n%s\n" % (Options["Reason"]));
- logfile.write("----------------------------------------------\n");
- logfile.flush();
+ logfile.write("Closed bugs: %s\n" % (Options["Done"]))
+ logfile.write("\n------------------- Reason -------------------\n%s\n" % (Options["Reason"]))
+ logfile.write("----------------------------------------------\n")
+ logfile.flush()
- dsc_type_id = db_access.get_override_type_id('dsc');
- deb_type_id = db_access.get_override_type_id('deb');
+ dsc_type_id = get_override_type('dsc', session)
+ deb_type_id = get_override_type('deb', session)
# Do the actual deletion
print "Deleting...",
- sys.stdout.flush();
- projectB.query("BEGIN WORK");
+ sys.stdout.flush()
+
for i in to_remove:
- package = i[0];
- architecture = i[2];
- package_id = i[3];
+ package = i[0]
+ architecture = i[2]
+ package_id = i[3]
for suite_id in suite_ids_list:
if architecture == "source":
- projectB.query("DELETE FROM src_associations WHERE source = %s AND suite = %s" % (package_id, suite_id));
- #print "DELETE FROM src_associations WHERE source = %s AND suite = %s" % (package_id, suite_id);
+ session.execute("DELETE FROM src_associations WHERE source = :packageid AND suite = :suiteid",
+ {'packageid': package_id, 'suiteid': suite_id})
+ #print "DELETE FROM src_associations WHERE source = %s AND suite = %s" % (package_id, suite_id)
else:
- projectB.query("DELETE FROM bin_associations WHERE bin = %s AND suite = %s" % (package_id, suite_id));
- #print "DELETE FROM bin_associations WHERE bin = %s AND suite = %s" % (package_id, suite_id);
+ session.execute("DELETE FROM bin_associations WHERE bin = :packageid AND suite = :suiteid",
+ {'packageid': package_id, 'suiteid': suite_id})
+ #print "DELETE FROM bin_associations WHERE bin = %s AND suite = %s" % (package_id, suite_id)
# Delete from the override file
if not Options["Partial"]:
if architecture == "source":
- type_id = dsc_type_id;
+ type_id = dsc_type_id
else:
- type_id = deb_type_id;
- projectB.query("DELETE FROM override WHERE package = '%s' AND type = %s AND suite = %s %s" % (package, type_id, suite_id, over_con_components));
- projectB.query("COMMIT WORK");
+ type_id = deb_type_id
+ # TODO: Again, fix this properly to remove the remaining non-bind argument
+ session.execute("DELETE FROM override WHERE package = :package AND type = :typeid AND suite = :suiteid %s" % (over_con_components), {'package': package, 'typeid': type_id, 'suiteid': suite_id})
+ session.commit()
print "done."
# Send the bug closing messages
if Options["Done"]:
- Subst = {};
- Subst["__MELANIE_ADDRESS__"] = Cnf["Melanie::MyEmailAddress"];
- Subst["__BUG_SERVER__"] = Cnf["Dinstall::BugServer"];
- bcc = [];
- if Cnf.Find("Dinstall::Bcc") != "":
- bcc.append(Cnf["Dinstall::Bcc"]);
- if Cnf.Find("Melanie::Bcc") != "":
- bcc.append(Cnf["Melanie::Bcc"]);
+ Subst = {}
+ Subst["__RM_ADDRESS__"] = cnf["Rm::MyEmailAddress"]
+ Subst["__BUG_SERVER__"] = cnf["Dinstall::BugServer"]
+ bcc = []
+ if cnf.Find("Dinstall::Bcc") != "":
+ bcc.append(cnf["Dinstall::Bcc"])
+ if cnf.Find("Rm::Bcc") != "":
+ bcc.append(cnf["Rm::Bcc"])
if bcc:
- Subst["__BCC__"] = "Bcc: " + ", ".join(bcc);
+ Subst["__BCC__"] = "Bcc: " + ", ".join(bcc)
else:
- Subst["__BCC__"] = "X-Filler: 42";
- Subst["__CC__"] = "X-Katie: melanie $Revision: 1.44 $";
+ Subst["__BCC__"] = "X-Filler: 42"
+ Subst["__CC__"] = "X-DAK: dak rm\nX-Katie: melanie"
if carbon_copy:
- Subst["__CC__"] += "\nCc: " + ", ".join(carbon_copy);
- Subst["__SUITE_LIST__"] = suites_list;
- Subst["__SUMMARY__"] = summary;
- Subst["__ADMIN_ADDRESS__"] = Cnf["Dinstall::MyAdminAddress"];
- Subst["__DISTRO__"] = Cnf["Dinstall::MyDistribution"];
- Subst["__WHOAMI__"] = whoami;
- whereami = utils.where_am_i();
- Archive = Cnf.SubTree("Archive::%s" % (whereami));
- Subst["__MASTER_ARCHIVE__"] = Archive["OriginServer"];
- Subst["__PRIMARY_MIRROR__"] = Archive["PrimaryMirror"];
+ Subst["__CC__"] += "\nCc: " + ", ".join(carbon_copy)
+ Subst["__SUITE_LIST__"] = suites_list
+ Subst["__SUMMARY__"] = summary
+ Subst["__ADMIN_ADDRESS__"] = cnf["Dinstall::MyAdminAddress"]
+ Subst["__DISTRO__"] = cnf["Dinstall::MyDistribution"]
+ Subst["__WHOAMI__"] = whoami
+ whereami = utils.where_am_i()
+ Archive = cnf.SubTree("Archive::%s" % (whereami))
+ Subst["__MASTER_ARCHIVE__"] = Archive["OriginServer"]
+ Subst["__PRIMARY_MIRROR__"] = Archive["PrimaryMirror"]
for bug in utils.split_args(Options["Done"]):
- Subst["__BUG_NUMBER__"] = bug;
- mail_message = utils.TemplateSubst(Subst,Cnf["Dir::Templates"]+"/melanie.bug-close");
- utils.send_mail(mail_message);
+ Subst["__BUG_NUMBER__"] = bug
+ mail_message = utils.TemplateSubst(Subst,cnf["Dir::Templates"]+"/rm.bug-close")
+ utils.send_mail(mail_message)
- logfile.write("=========================================================================\n");
- logfile.close();
+ logfile.write("=========================================================================\n")
+ logfile.close()
#######################################################################################
if __name__ == '__main__':
main()
-