2 # vim:set et ts=4 sw=4:
4 """ Handles NEW and BYHAND packages
6 @contact: Debian FTP Master <ftpmaster@debian.org>
7 @copyright: 2001, 2002, 2003, 2004, 2005, 2006 James Troup <james@nocrew.org>
8 @copyright: 2009 Joerg Jaspert <joerg@debian.org>
9 @copyright: 2009 Frank Lichtenheld <djpig@debian.org>
10 @license: GNU General Public License version 2 or later
12 # This program is free software; you can redistribute it and/or modify
13 # it under the terms of the GNU General Public License as published by
14 # the Free Software Foundation; either version 2 of the License, or
15 # (at your option) any later version.
17 # This program is distributed in the hope that it will be useful,
18 # but WITHOUT ANY WARRANTY; without even the implied warranty of
19 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
20 # GNU General Public License for more details.
22 # You should have received a copy of the GNU General Public License
23 # along with this program; if not, write to the Free Software
24 # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
26 ################################################################################
28 # 23:12|<aj> I will not hush!
30 # 23:12|<aj> Where there is injustice in the world, I shall be there!
31 # 23:13|<aj> I shall not be silenced!
32 # 23:13|<aj> The world shall know!
33 # 23:13|<aj> The world *must* know!
34 # 23:13|<elmo> oh dear, he's gone back to powerpuff girls... ;-)
35 # 23:13|<aj> yay powerpuff girls!!
36 # 23:13|<aj> buttercup's my favourite, who's yours?
37 # 23:14|<aj> you're backing away from the keyboard right now aren't you?
38 # 23:14|<aj> *AREN'T YOU*?!
39 # 23:15|<aj> I will not be treated like this.
40 # 23:15|<aj> I shall have my revenge.
41 # 23:15|<aj> I SHALL!!!
43 ################################################################################
54 import apt_pkg, apt_inst
55 import examine_package
57 from sqlalchemy import or_
59 from daklib.dbconn import *
60 from daklib.queue import *
61 from daklib import daklog
62 from daklib import utils
63 from daklib.regexes import re_no_epoch, re_default_answer, re_isanum, re_package
64 from daklib.dak_exceptions import CantOpenError, AlreadyLockedError, CantGetLockError
65 from daklib.summarystats import SummaryStats
66 from daklib.config import Config
67 from daklib.policy import UploadCopy, PolicyQueueUploadHandler
76 ################################################################################
77 ################################################################################
78 ################################################################################
80 class Section_Completer:
81 def __init__ (self, session):
84 for s, in session.query(Section.section):
85 self.sections.append(s)
87 def complete(self, text, state):
91 for word in self.sections:
93 self.matches.append(word)
95 return self.matches[state]
99 ############################################################
101 class Priority_Completer:
102 def __init__ (self, session):
105 for p, in session.query(Priority.priority):
106 self.priorities.append(p)
108 def complete(self, text, state):
112 for word in self.priorities:
114 self.matches.append(word)
116 return self.matches[state]
120 ################################################################################
122 def takenover_binaries(upload, missing, session):
124 binaries = set([x.package for x in upload.binaries])
126 if m['type'] != 'dsc':
127 binaries.remove(m['package'])
129 source = upload.binaries[0].source.source
130 suite = upload.target_suite.overridesuite or \
131 upload.target_suite.suite_name
132 suites = [s[0] for s in session.query(Suite.suite_name).filter \
133 (or_(Suite.suite_name == suite,
134 Suite.overridesuite == suite)).all()]
135 rows = session.query(DBSource.source, DBBinary.package).distinct(). \
136 filter(DBBinary.package.in_(binaries)). \
137 join(DBBinary.source). \
138 filter(DBSource.source != source). \
139 join(DBBinary.suites). \
140 filter(Suite.suite_name.in_(suites)). \
141 order_by(DBSource.source, DBBinary.package).all()
144 ################################################################################
146 def print_new (upload, missing, indexed, session, file=sys.stdout):
147 check_valid(missing, session)
151 if m['type'] != 'deb':
152 package = '{0}:{1}'.format(m['type'], m['package'])
154 package = m['package']
155 section = m['section']
156 priority = m['priority']
158 line = "(%s): %-20s %-20s %-20s" % (index, package, priority, section)
160 line = "%-20s %-20s %-20s" % (package, priority, section)
165 takenover = takenover_binaries(upload, missing, session)
167 print '\n\nBINARIES TAKEN OVER\n'
169 print '%s: %s' % (t[0], t[1])
170 notes = get_new_comments(upload.policy_queue, upload.changes.source)
172 print "\nAuthor: %s\nVersion: %s\nTimestamp: %s\n\n%s" \
173 % (note.author, note.version, note.notedate, note.comment)
175 return len(notes) > 0
177 ################################################################################
179 def index_range (index):
183 return "1-%s" % (index)
185 ################################################################################
186 ################################################################################
188 def edit_new (overrides, upload, session):
189 # Write the current data to a temporary file
190 (fd, temp_filename) = utils.temp_filename()
191 temp_file = os.fdopen(fd, 'w')
192 print_new (upload, overrides, indexed=0, session=session, file=temp_file)
194 # Spawn an editor on that file
195 editor = os.environ.get("EDITOR","vi")
196 result = os.system("%s %s" % (editor, temp_filename))
198 utils.fubar ("%s invocation failed for %s." % (editor, temp_filename), result)
199 # Read the edited data back in
200 temp_file = utils.open_file(temp_filename)
201 lines = temp_file.readlines()
203 os.unlink(temp_filename)
205 overrides_map = dict([ ((o['type'], o['package']), o) for o in overrides ])
210 if line == "" or line[0] == '#':
213 # Pad the list if necessary
214 s[len(s):3] = [None] * (3-len(s))
215 (pkg, priority, section) = s[:3]
216 if pkg.find(':') != -1:
217 type, pkg = pkg.split(':', 1)
220 if (type, pkg) not in overrides_map:
221 utils.warn("Ignoring unknown package '%s'" % (pkg))
223 if section.find('/') != -1:
224 component = section.split('/', 1)[0]
227 new_overrides.append(dict(
236 ################################################################################
238 def edit_index (new, upload, index):
239 package = new[index]['package']
240 priority = new[index]["priority"]
241 section = new[index]["section"]
242 ftype = new[index]["type"]
245 print "\t".join([package, priority, section])
249 prompt = "[B]oth, Priority, Section, Done ? "
251 prompt = "[S]ection, Done ? "
252 edit_priority = edit_section = 0
254 while prompt.find(answer) == -1:
255 answer = utils.our_raw_input(prompt)
256 m = re_default_answer.match(prompt)
259 answer = answer[:1].upper()
266 edit_priority = edit_section = 1
272 readline.set_completer(Priorities.complete)
274 while not got_priority:
275 new_priority = utils.our_raw_input("New priority: ").strip()
276 if new_priority not in Priorities.priorities:
277 print "E: '%s' is not a valid priority, try again." % (new_priority)
280 priority = new_priority
284 readline.set_completer(Sections.complete)
286 while not got_section:
287 new_section = utils.our_raw_input("New section: ").strip()
288 if new_section not in Sections.sections:
289 print "E: '%s' is not a valid section, try again." % (new_section)
292 section = new_section
294 # Reset the readline completer
295 readline.set_completer(None)
297 new[index]["priority"] = priority
298 new[index]["section"] = section
299 if section.find('/') != -1:
300 component = section.split('/', 1)[0]
303 new[index]['component'] = component
307 ################################################################################
309 def edit_overrides (new, upload, session):
313 print_new (upload, new, indexed=1, session=session)
314 prompt = "edit override <n>, Editor, Done ? "
317 while not got_answer:
318 answer = utils.our_raw_input(prompt)
319 if not answer.isdigit():
320 answer = answer[:1].upper()
321 if answer == "E" or answer == "D":
323 elif re_isanum.match (answer):
325 if answer < 1 or answer > len(new):
326 print "{0} is not a valid index. Please retry.".format(answer)
331 new = edit_new(new, upload, session)
335 edit_index (new, upload, answer - 1)
340 ################################################################################
342 def check_pkg (upload, upload_copy, session):
344 save_stdout = sys.stdout
345 changes = os.path.join(upload_copy.directory, upload.changes.changesname)
346 suite_name = upload.target_suite.suite_name
347 handler = PolicyQueueUploadHandler(upload, session)
348 missing = [(m['type'], m["package"]) for m in handler.missing_overrides(hints=missing)]
350 sys.stdout = os.popen("less -R -", 'w', 0)
351 print examine_package.display_changes(suite_name, changes)
353 source = upload.source
354 if source is not None:
355 source_file = os.path.join(upload_copy.directory, os.path.basename(source.poolfile.filename))
356 print examine_package.check_dsc(suite_name, source_file)
358 for binary in upload.binaries:
359 binary_file = os.path.join(upload_copy.directory, os.path.basename(binary.poolfile.filename))
360 examined = examine_package.check_deb(suite_name, binary_file)
361 # We always need to call check_deb to display package relations for every binary,
362 # but we print its output only if new overrides are being added.
363 if ("deb", binary.package) in missing:
366 print examine_package.output_package_relations()
368 if e.errno == errno.EPIPE:
369 utils.warn("[examine_package] Caught EPIPE; skipping.")
372 except KeyboardInterrupt:
373 utils.warn("[examine_package] Caught C-c; skipping.")
375 sys.stdout = save_stdout
377 ################################################################################
379 ## FIXME: horribly Debian specific
381 def do_bxa_notification(new, upload, session):
384 new = set([ o['package'] for o in new if o['type'] == 'deb' ])
388 key = session.query(MetadataKey).filter_by(key='Description').one()
390 for binary in upload.binaries:
391 if binary.package not in new:
393 description = session.query(BinaryMetadata).filter_by(binary=binary, key=key).one().value
395 summary += "Package: {0}\n".format(binary.package)
396 summary += "Description: {0}\n".format(description)
399 '__DISTRO__': cnf['Dinstall::MyDistribution'],
400 '__BCC__': 'X-DAK: dak process-new',
401 '__BINARY_DESCRIPTIONS__': summary,
404 bxa_mail = utils.TemplateSubst(subst,os.path.join(cnf["Dir::Templates"], "process-new.bxa_notification"))
405 utils.send_mail(bxa_mail)
407 ################################################################################
409 def add_overrides (new_overrides, suite, session):
410 if suite.overridesuite is not None:
411 suite = session.query(Suite).filter_by(suite_name=suite.overridesuite).one()
413 for override in new_overrides:
414 package = override['package']
415 priority = session.query(Priority).filter_by(priority=override['priority']).first()
416 section = session.query(Section).filter_by(section=override['section']).first()
417 component = get_mapped_component(override['component'], session)
418 overridetype = session.query(OverrideType).filter_by(overridetype=override['type']).one()
421 raise Exception('Invalid priority {0} for package {1}'.format(priority, package))
423 raise Exception('Invalid section {0} for package {1}'.format(section, package))
424 if component is None:
425 raise Exception('Invalid component {0} for package {1}'.format(component, package))
427 o = Override(package=package, suite=suite, component=component, priority=priority, section=section, overridetype=overridetype)
432 ################################################################################
434 def run_user_inspect_command(upload, upload_copy):
435 command = os.environ.get('DAK_INSPECT_UPLOAD')
439 directory = upload_copy.directory
441 dsc = os.path.basename(upload.source.poolfile.filename)
444 changes = upload.changes.changesname
446 shell_command = command.format(
452 subprocess.check_call(shell_command, shell=True)
454 ################################################################################
456 def get_reject_reason(reason=''):
457 """get reason for rejection
460 @return: string giving the reason for the rejection or C{None} if the
461 rejection should be cancelled
464 if Options['Automatic']:
468 reason = utils.call_editor(reason)
469 print "Reject message:"
470 print utils.prefix_multi_line_string(reason, " ", include_blank_lines=1)
471 prompt = "[R]eject, Edit, Abandon, Quit ?"
473 while prompt.find(answer) == -1:
474 answer = utils.our_raw_input(prompt)
475 m = re_default_answer.search(prompt)
478 answer = answer[:1].upper()
487 ################################################################################
489 def do_new(upload, upload_copy, handler, session):
492 run_user_inspect_command(upload, upload_copy)
494 # The main NEW processing loop
498 queuedir = upload.policy_queue.path
499 byhand = upload.byhand
501 missing = handler.missing_overrides(hints=missing)
502 broken = not check_valid(missing, session)
504 changesname = os.path.basename(upload.changes.changesname)
508 print "-" * len(changesname)
510 print " Target: {0}".format(upload.target_suite.suite_name)
511 print " Changed-By: {0}".format(upload.changes.changedby)
514 #if len(byhand) == 0 and len(missing) == 0:
521 if Options["No-Action"] or Options["Automatic"]:
524 note = print_new(upload, missing, indexed=0, session=session)
527 has_unprocessed_byhand = False
529 path = os.path.join(queuedir, f.filename)
530 if not f.processed and os.path.exists(path):
531 print "W: {0} still present; please process byhand components and try again".format(f.filename)
532 has_unprocessed_byhand = True
534 if not has_unprocessed_byhand and not broken and not note:
535 if len(missing) == 0:
539 prompt = "Add overrides, "
541 print "W: [!] marked entries must be fixed before package can be processed."
543 print "W: note must be removed before package can be processed."
544 prompt += "RemOve all notes, Remove note, "
546 prompt += "Edit overrides, Check, Manual reject, Note edit, Prod, [S]kip, Quit ?"
548 while prompt.find(answer) == -1:
549 answer = utils.our_raw_input(prompt)
550 m = re_default_answer.search(prompt)
553 answer = answer[:1].upper()
555 if answer in ( 'A', 'E', 'M', 'O', 'R' ) and Options["Trainee"]:
556 utils.warn("Trainees can't do that")
559 if answer == 'A' and not Options["Trainee"]:
560 add_overrides(missing, upload.target_suite, session)
561 if Config().find_b("Dinstall::BXANotify"):
562 do_bxa_notification(missing, upload, session)
565 Logger.log(["NEW ACCEPT", upload.changes.changesname])
567 check_pkg(upload, upload_copy, session)
568 elif answer == 'E' and not Options["Trainee"]:
569 missing = edit_overrides (missing, upload, session)
570 elif answer == 'M' and not Options["Trainee"]:
571 reason = Options.get('Manual-Reject', '') + "\n"
572 reason = reason + "\n\n=====\n\n".join([n.comment for n in get_new_comments(upload.policy_queue, upload.changes.source, session=session)])
573 reason = get_reject_reason(reason)
574 if reason is not None:
575 Logger.log(["NEW REJECT", upload.changes.changesname])
576 handler.reject(reason)
579 if edit_note(get_new_comments(upload.policy_queue, upload.changes.source, session=session),
580 upload, session, bool(Options["Trainee"])) == 0:
583 elif answer == 'P' and not Options["Trainee"]:
584 if prod_maintainer(get_new_comments(upload.policy_queue, upload.changes.source, session=session),
588 Logger.log(["NEW PROD", upload.changes.changesname])
589 elif answer == 'R' and not Options["Trainee"]:
590 confirm = utils.our_raw_input("Really clear note (y/N)? ").lower()
592 for c in get_new_comments(upload.policy_queue, upload.changes.source, upload.changes.version, session=session):
595 elif answer == 'O' and not Options["Trainee"]:
596 confirm = utils.our_raw_input("Really clear all notes (y/N)? ").lower()
598 for c in get_new_comments(upload.policy_queue, upload.changes.source, session=session):
608 if handler.get_action():
609 print "PENDING %s\n" % handler.get_action()
611 ################################################################################
612 ################################################################################
613 ################################################################################
615 def usage (exit_code=0):
616 print """Usage: dak process-new [OPTION]... [CHANGES]...
617 -a, --automatic automatic run
618 -b, --no-binaries do not sort binary-NEW packages first
619 -c, --comments show NEW comments
620 -h, --help show this help and exit.
621 -m, --manual-reject=MSG manual reject with `msg'
622 -n, --no-action don't do anything
623 -q, --queue=QUEUE operate on a different queue
624 -t, --trainee FTP Trainee mode
625 -V, --version display the version number and exit
627 ENVIRONMENT VARIABLES
629 DAK_INSPECT_UPLOAD: shell command to run to inspect a package
630 The command is automatically run in a shell when an upload
631 is checked. The following substitutions are available:
633 {directory}: directory the upload is contained in
634 {dsc}: name of the included dsc or the empty string
635 {changes}: name of the changes file
637 Note that Python's 'format' method is used to format the command.
639 Example: run mc in a tmux session to inspect the upload
641 export DAK_INSPECT_UPLOAD='tmux new-session -d -s process-new 2>/dev/null; tmux new-window -n "{changes}" -t process-new:0 -k "cd {directory}; mc"'
645 tmux attach -t process-new
647 in a separate terminal session.
651 ################################################################################
653 @contextlib.contextmanager
654 def lock_package(package):
656 Lock C{package} so that noone else jumps in processing it.
658 @type package: string
659 @param package: source package name to lock
664 path = os.path.join(cnf.get("Process-New::LockDir", cnf['Dir::Lock']), package)
667 fd = os.open(path, os.O_CREAT | os.O_EXCL | os.O_RDONLY)
669 if e.errno == errno.EEXIST or e.errno == errno.EACCES:
670 user = pwd.getpwuid(os.stat(path)[stat.ST_UID])[4].split(',')[0].replace('.', '')
671 raise AlreadyLockedError(user)
678 def do_pkg(upload, session):
679 # Try to get an included dsc
683 group = cnf.get('Dinstall::UnprivGroup') or None
685 #bcc = "X-DAK: dak process-new"
686 #if cnf.has_key("Dinstall::Bcc"):
687 # u.Subst["__BCC__"] = bcc + "\nBcc: %s" % (cnf["Dinstall::Bcc"])
689 # u.Subst["__BCC__"] = bcc
692 with lock_package(upload.changes.source):
693 with UploadCopy(upload, group=group) as upload_copy:
694 handler = PolicyQueueUploadHandler(upload, session)
695 if handler.get_action() is not None:
696 print "PENDING %s\n" % handler.get_action()
699 do_new(upload, upload_copy, handler, session)
700 except AlreadyLockedError as e:
701 print "Seems to be locked by %s already, skipping..." % (e)
703 def show_new_comments(uploads, session):
704 sources = [ upload.changes.source for upload in uploads ]
705 if len(sources) == 0:
708 query = """SELECT package, version, comment, author
710 WHERE package IN :sources
711 ORDER BY package, version"""
713 r = session.execute(query, params=dict(sources=tuple(sources)))
716 print "%s_%s\n%s\n(%s)\n\n\n" % (i[0], i[1], i[2], i[3])
720 ################################################################################
722 def sort_uploads(new_queue, uploads, session, nobinaries=False):
725 suitesrc = [s.source for s in session.query(DBSource.source). \
726 filter(DBSource.suites.any(Suite.suite_name.in_(['unstable', 'experimental'])))]
727 comments = [p.package for p in session.query(NewComment.package). \
728 filter_by(trainee=False, policy_queue=new_queue).distinct()]
729 for upload in uploads:
730 source = upload.changes.source
731 if not source in sources:
733 sources[source].append({'upload': upload,
734 'date': upload.changes.created,
736 'binary': True if source in suitesrc else False,
737 'comments': True if source in comments else False})
739 if len(sources[src]) > 1:
740 changes = sources[src]
741 firstseen = sorted(changes, key=lambda k: (k['date']))[0]['date']
742 changes.sort(key=lambda item:item['date'])
743 for i in range (0, len(changes)):
744 changes[i]['date'] = firstseen
745 changes[i]['stack'] = i + 1
746 sorteduploads += sources[src]
748 sorteduploads = [u["upload"] for u in sorted(sorteduploads,
749 key=lambda k: (k["comments"], k["binary"],
750 k["date"], -k["stack"]))]
752 sorteduploads = [u["upload"] for u in sorted(sorteduploads,
753 key=lambda k: (k["comments"], -k["binary"],
754 k["date"], -k["stack"]))]
757 ################################################################################
760 accept_count = SummaryStats().accept_count
761 accept_bytes = SummaryStats().accept_bytes
767 sys.stderr.write("Accepted %d package %s, %s.\n" % (accept_count, sets, utils.size_type(int(accept_bytes))))
768 Logger.log(["total",accept_count,accept_bytes])
770 if not Options["No-Action"] and not Options["Trainee"]:
773 ################################################################################
776 global Options, Logger, Sections, Priorities
779 session = DBConn().session()
781 Arguments = [('a',"automatic","Process-New::Options::Automatic"),
782 ('b',"no-binaries","Process-New::Options::No-Binaries"),
783 ('c',"comments","Process-New::Options::Comments"),
784 ('h',"help","Process-New::Options::Help"),
785 ('m',"manual-reject","Process-New::Options::Manual-Reject", "HasArg"),
786 ('t',"trainee","Process-New::Options::Trainee"),
787 ('q','queue','Process-New::Options::Queue', 'HasArg'),
788 ('n',"no-action","Process-New::Options::No-Action")]
790 changes_files = apt_pkg.parse_commandline(cnf.Cnf,Arguments,sys.argv)
792 for i in ["automatic", "no-binaries", "comments", "help", "manual-reject", "no-action", "version", "trainee"]:
793 if not cnf.has_key("Process-New::Options::%s" % (i)):
794 cnf["Process-New::Options::%s" % (i)] = ""
796 queue_name = cnf.get('Process-New::Options::Queue', 'new')
797 new_queue = session.query(PolicyQueue).filter_by(queue_name=queue_name).one()
798 if len(changes_files) == 0:
799 uploads = new_queue.uploads
801 uploads = session.query(PolicyQueueUpload).filter_by(policy_queue=new_queue) \
802 .join(DBChange).filter(DBChange.changesname.in_(changes_files)).all()
804 Options = cnf.subtree("Process-New::Options")
809 if not Options["No-Action"]:
811 Logger = daklog.Logger("process-new")
812 except CantOpenError as e:
813 Options["Trainee"] = "True"
815 Sections = Section_Completer(session)
816 Priorities = Priority_Completer(session)
817 readline.parse_and_bind("tab: complete")
820 sys.stderr.write("Sorting changes...\n")
821 uploads = sort_uploads(new_queue, uploads, session, Options["No-Binaries"])
823 if Options["Comments"]:
824 show_new_comments(uploads, session)
826 for upload in uploads:
827 do_pkg (upload, session)
831 ################################################################################
833 if __name__ == '__main__':